openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	e72d940b5b	Feature/37108 improve design of GitHub tab (#9329 ) * Rename Git button to 'Git snippets' * Change font for Github tab header * Improve design of pr status badges * Reorganize the design of PR headers * Improve design of PR checks * Improve design of git snippets menu * Remove WP description from commit message and command * Fix frontend specs for github integration * Adding dots to the end of phrases. * Github Integration: reduce dom depth. remove last border under PR * Add target blank to PR details link & other fixes * Fix work_package_github_tab_spec.rb * Remove fdescribe * Improve layout of Github pull requests tab header * Add title to Github check icon * Refactor classnames for github pull requests This introduces `op-pull-request` and `op-pr-check` as BEM blocks, both in their own sass files, but the files still scoped to the pull request component. * Fix frontend spec. Added karma Chrome debug config. * Fix frontend specs after refactoring styles Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Philipp Tessenow	2f9d252456	Show github pull requests in the GitHub tab (#9148 ) * WIP: prototype wiring up the API with the angular frontend * little refactorings in namespace and loading logic * frontend styling and polishing * pairing with aleix * Avoid empty pullRequest.githubUser to be displayed * added feature specs, a workaround for a pr-reload-bug in angular, and some readme improvements * Title for partial PRs added * GitActionsMenuComponent tests * Test improvements * GitHubTabComponent tests * TabHeaderComponent tests * TabPrsComponent tests * revert change to karma runner * start styling * i18n in component * avoid container element * git actions menu tests * Github interfaces * PullRequestComponent tests * Comment removed * Typings improvements * Merge fixes * Tests fixes * fix: wp list id links working with tabs * remove partial github pr state A PR might still be incomplete but enough data can be pulled from a github issuee notification to fill in most of the information * avoid duplicate spec * Fix import paths of op-icon Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Philipp Tessenow	a46de71009	[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 ) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs	4 years ago

Author

SHA1

Message

Date

Wieland Lindenthal

e72d940b5b

Feature/37108 improve design of GitHub tab (#9329 )

* Rename Git button to 'Git snippets'

* Change font for Github tab header

* Improve design of pr status badges

* Reorganize the design of PR headers

* Improve design of PR checks

* Improve design of git snippets menu

* Remove WP description from commit message and command

* Fix frontend specs for github integration

* Adding dots to the end of phrases.

* Github Integration: reduce dom depth. remove last border under PR

* Add target blank to PR details link & other fixes

* Fix work_package_github_tab_spec.rb

* Remove fdescribe

* Improve layout of Github pull requests tab header

* Add title to Github check icon

* Refactor classnames for github pull requests

This introduces `op-pull-request` and `op-pr-check` as BEM blocks, both in their own sass files, but the files still scoped to the pull request component.

* Fix frontend spec. Added karma Chrome debug config.

* Fix frontend specs after refactoring styles

Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>

4 years ago

Philipp Tessenow

2f9d252456

Show github pull requests in the GitHub tab (#9148 )

* WIP: prototype wiring up the API with the angular frontend

* little refactorings in namespace and loading logic

* frontend styling and polishing

* pairing with aleix

* Avoid empty pullRequest.githubUser to be displayed

* added feature specs, a workaround for a pr-reload-bug in angular, and some readme improvements

* Title for partial PRs added

* GitActionsMenuComponent tests

* Test improvements

* GitHubTabComponent tests

* TabHeaderComponent tests

* TabPrsComponent tests

* revert change to karma runner

* start styling

* i18n in component

* avoid container element

* git actions menu tests

* Github interfaces

* PullRequestComponent tests

* Comment removed

* Typings improvements

* Merge fixes

* Tests fixes

* fix: wp list id links working with tabs

* remove partial github pr state

A PR might still be incomplete but enough data can be pulled from a github issuee notification to fill in most of the information

* avoid duplicate spec

* Fix import paths of op-icon

Co-authored-by: Aleix Suau <info@macrofonoestudio.es>
Co-authored-by: ulferts <jens.ulferts@googlemail.com>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>

4 years ago

Philipp Tessenow

a46de71009

[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 )

* Let GitHub integration show changes in a separate tab

* added new github integration icons to icon font
* add tab content:  working tab-header and copy-menu

* modernise github_integrations ruby code

* refactored some code to be more modern ruby (if wrote most of it 7
  years ago and couldn't look at some parts without squinting too much)
* make some intended-to-be-private module methods actually private
* fixed all rubocop errors in the /modules/github_integration
* re-organized tests a little
* gave our rubocop.yml some RSpec-related defaults -- happy to discuss
  these, but I think we can live with these as a good starting point

👆 all without actually (intentionally) changing the behaviour

* removed dead angular template code

* codeclimate found more things than rubocop :)

* removed create-pr-button since we decided against implementing that feature

* added missing translations

* properly cache the github related part of the wp api

* lower case pull requests in translations

* fix specs

4 years ago

3 Commits (7160f0fff808e023742f641b56a2009772c90fef)