openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	67e06ee2b2	Remove double escaping With OpenProject 5.0, we moved to Open3 pseudo-shell, which no longer requires escaping seperate arguments (unless the whole command is passed as a single string, which will result in an actual shell that would require escaping). The `shell_quote` functionality was still used though and causes issues with remote subversion passwords, which will be improperly escaped.	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Henriette Dinger	48f593645c	Add small icons for timelines and start fixing specs	9 years ago
Henriette Dinger	463aa185da	Update icon classes from 'not-watch' until 'pulldown-arrow4'	9 years ago
Henriette Dinger	844663fef2	Change icon classes from 'attention1' until 'headphone'	9 years ago
Markus Kahl	ef27046915	only seed cost permissions for members once	9 years ago
Markus Kahl	9dd70324b4	only seed permissions once	9 years ago
Markus Kahl	563aff35f1	seed reporting permissions only once	9 years ago
Stefan Botzenhart	ba3c727dcc	Remove pending specs	9 years ago
Oliver Günther	cd7ec57ee6	Empty check for newer Git versions Git recently introduced a new format for outputting warnings on empty repositories in `ce11360467` This commit extends the empty test for this output	9 years ago
Jonas Heinrich	fc4b2b4676	Adds specs for configuration	9 years ago
Markus Kahl	da58898c29	clear subscription spec	9 years ago
Alex Coles	164a60ffa8	Use #be_html_eql matcher in TextFormatting spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	fb82c9c1ba	Replace anonymous class in ActsAsOpEngine spec Rails 4.2 is not able generate an appropriate `railtie_name` (aliased to `engine_name`) for anonymous classes - this, in turn, breaks initializer definitions. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2fc2ea3ae5	Update expected HTML in FormTagHelper spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Henriette Dinger	ca02263058	updated icon font, fixed broken specs and design bugs	9 years ago
Oliver Günther	f982465a5d	Force tmpdir for storage spec We observed `lib/open_project/storage_spec.rb` to fail occasionally, which I assume has something to do with the existence of the attachments directory. The changed spec forces a tmpdir to be created and evaluates storage information on that path.	9 years ago
Oliver Günther	48f53ba5fc	Remove invalid subject variable from spec	9 years ago
Oliver Günther	f00e827807	Format output SCM vendors in storage	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Alex Coles	5f8b364cac	Update expected HTML in FormTagHelper spec Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	2769e16819	[21275] Show information on storage paths as admin/info section This commit adds a separate section in the admin/info section to show used and available storage for: * Attachment storage * Manageable repository vendors	9 years ago
Jan Sandbrink	715c664cbe	generalize module included in all delayed jobs now also applies to other activities one might want to execute before all delayed jobs (as discussed with @ulferts)	9 years ago
Jan Sandbrink	10d61b01e7	let delayed jobs reset the request store This is especially neccessary since our Settings use the request store to determine, whether they need to invalidate the cache key. If the request store was never reset, the settings in our delayed jobs would be cached at an old value forever (until the next restart).	9 years ago
Oliver Günther	612a1809f4	Confirmed that UTF-16 incorrectly returns nil This commit adds a spec for the UTF-16 invalid detection as binary, which is consistent with previous behavior, but the whole content encoding problem should be addressed.	9 years ago
Oliver Günther	bfa0c4d69d	Extend repository with UTF-16 encoded file, extend specs accordingly	9 years ago
Oliver Günther	86f847043b	Allow configuration to disable arbitrary SCM types This commit provides: - Configuration options for disabling any number of available types of that particular SCM vendor. - Changes to the underlying structure to allow determination of which types are available on a class level.	9 years ago
Oliver Günther	9336cff8bb	Extended specs This commit adds / extends the following specs: RepositoriesController: Ensure empty repository page is shown for empty repositories adapters/subversion: Test correct use of --login, --password arguments	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Jens Ulferts	11b906dfd7	introducing a setting to disable cf class caching The setting is not yet used.	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	61d77c721b	Fix TextFormatting#format_text specs w/requests * Make intent slightly clearer with a shared context. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	ccb2a6032e	repair legacy specs fix the application helper legacy spec fix text formatting spec to reflect anchors only mode w/o request Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jan Sandbrink	c4e51404c2	move uploaded file creation out of api endpoint	10 years ago
Markus Kahl	2a465785d1	allow digit-only but not empty passwords	10 years ago
Markus Kahl	7e40c11ca4	moved strategies; refactoring	10 years ago
Alex Coles	3276c4ebb5	Add/update Copyright headers in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8e32063189	Minor whitespace fix in FormTagHelper spec [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3de4f651c3	Fix #styled_label_tag default titles without block With content passed as an argument this never worked as planned (see commits `178e2825`, `f2cb3805`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c5161ae0ef	Add spec for TextFormatting {{toc}} macro parsing Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Florian Kraft	178e282576	update the form tag helper to allow for default title in label	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { \|c\| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jan Sandbrink	365f7d78b4	disable a test that is a evergreen	10 years ago

1 2 3 4 5

231 Commits (7287f22b15dde058cd0fea3eece2238f90e31cc9)