690 Commits (7450c77e88f0cbf214cf0c2a0483b1aeda53ad89)

Author	SHA1	Message	Date
Oliver Günther	894ba4ae6d	Ensure LDAP users can get activated with any registration setting ... LDAP users get an auth_source_id attached to them during registration, since they are effectively not self-registrating in the system, the register service should allow them with any self_registration setting. At the same time, the refactoring ensure that even an LDAP user that logs in for the first time is being redirected to home to get the welcome tour.	4 years ago
Oliver Günther	f1e25499cd	Need to pass controller to sevice for OIDC callback ... OIDC sets a cookie in the login hook so we need some access to the controller	4 years ago
Oliver Günther	235e8ab87c	Avoid using the user errors to mark activation failed ... This will cause the registration modal to show that internal error key, which we do not want	4 years ago
Oliver Günther	da754e0f43	Add spec for RegisterUserService	4 years ago
Oliver Günther	d52f7e2ba1	Add spec for omniauth service	4 years ago
Oliver Günther	d2a6886230	Retain flash values when logging in user	4 years ago
Oliver Günther	8090d21ae2	Custom message for user activation from invite	4 years ago
Oliver Günther	e364f23b06	Always return the registration service call, ensuring to get the message	4 years ago
Oliver Günther	50cdb76f62	Pass back the user in all service results	4 years ago
Oliver Günther	3f828d7fbd	Fix returned result	4 years ago
Oliver Günther	4d66b7c425	Ensure the user is marked as active in automatic activiation	4 years ago
Oliver Günther	2ef33d2a3a	Add helper to look for an error key in the ServiceResult errors	4 years ago
Oliver Günther	14b8e3fa35	Ensure that only non-nil values are passed from registration form	4 years ago
Oliver Günther	4b0509b197	Create separate service to get an active user from Omniauth ... Omniauth login flow is quite elaborate. It does: - check whether the request is valid (perfect use case for contract) - find or initialize a user from the auth hash - try to register that user according to Setting.self_registration This PR introduces two services to do these things 1. The omniauth request flow handler 2. A registration service to handle user activation/registration according to setting	4 years ago
Oliver Günther	8db5e90193	[34312] Update and use default settings for gantt query ... https://community.openproject.com/wp/34312	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651) ... * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
Oliver Günther	89e0c8c899	Add new project CF to enabled columns by default	4 years ago
Oliver Günther	41f8dbaff2	Refactor custom fields into services	4 years ago
Oliver Günther	24005a9e6d	[34000] Ensure user custom fields can be copied ... User CFs were not copiable because they depend on project members being copied. They need to be overridable in the copy form however, so we need to be able to set this before and after members are copied. The only option is to allow visible members to be selected there. https://community.openproject.com/wp/34000	4 years ago
Oliver Günther	6526ca2814	Map filters from api and queries in one filter mapper object ... This allows mapping the parent filter and other foreign key references that should be updated during copy.	4 years ago
Oliver Günther	4aad0c8b72	Generate URL params for gantt view and insert projects	4 years ago
ulferts	05c9e3fca6	Feature/default dates for children (#8605) ... * fix start_date expectation based on setting * extract methods * set dates of parent work package * pass parent on form request * have initial dates displayed correctly in wp create form	4 years ago
Markus Kahl	59f6de21c6	copy dashboards with all widgets and updated references where necessary	4 years ago
Oliver Günther	becefba1c4	Allow template to set the default advanced settings once selected ... Previously, advanced settings were simply hidden when project templates were selected. This however prohibits setting/overriding certain attributes, such as the parent project. This commit results in: - Selecting a template will reload the page - When advanced settings were opened, confirms from the user that the page should be reloaded - The template is being applied to the new project to ensure the attributes are being used - The user can then override or delete whatever params she wnats	4 years ago
Oliver Günther	b7f93b96cf	Better error handling if project copy dependencies fails ... The project copying can succeed but with errors of some dependencies, this commit modifies the modal to show these errors instead of automatically redirecting.	4 years ago
Oliver Günther	e1a88a9a40	[34001] Ensure filters always receive the query context ... In the mentioned project, the query copy service fails to execute because a filter has lost its context right after `query.save`. There is a hook for `after_commit` which is not relevant here since we're in a transaction, but the context is lost regardless. Instead, we could ensure whenever accessing the filters, the context is set correctly. https://community.openproject.com/wp/34001	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580) ... * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	8656c2664b	fix archiving projects via api ... When archiving, we need to assume the old `active` status to see if any modifications can be made. On top of that, whenever that status is changed the archive/unarchive service needs to be called as well so that e.g. the child projects are also archived	4 years ago
ulferts	0b15c2841d	allow `filter` for firlters params ... Users sometimes get stuck by typing filter instead of filters for the query params filters property. We can be lenient here.	4 years ago
ulferts	74fe191997	handle switching from manual to automatic	4 years ago
ulferts	7065c162fd	disregard manually scheduled nodes when scheduling work package graphs ... Instead of fetching all work packages from a subset of the whole graph constructed by hierarchy and follows relationships upon scheduling, only work packages eligible for automatic rescheduling are returned. In order to avoid quering the database multiple times, the whole subgraph is returned at once using a recursive CTE.	4 years ago
ulferts	cd85434ea6	aaj no longer requires loading a lot of associated objects	4 years ago
Oliver Günther	65fe7ce06f	Return the unmapped work package ID in case of wp not copied ... When a foreign work package is linked, it will not get copied during the project copy service. In this case, just use the original to retain it.	4 years ago
Oliver Günther	2523040abf	Improve lookup of versions and work package user assignments	4 years ago
Oliver Günther	9c0ed65c55	Make dependent services use project.(association).create when possible	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images ... Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
Oliver Günther	70cf07cc20	Disable notifications for user in the bsae copy service	4 years ago
Oliver Günther	cbe57a9e32	Add common \`should_copy?\` method for the project copy service	4 years ago
Oliver Günther	ace6af5b4e	Refactor archive service to use model from BaseContract	4 years ago
Oliver Günther	5b308c53ac	Fix params[:only] check for wiki dependent service	4 years ago
Oliver Günther	2271b79fc6	Correctly base all services on base_contracted with a model ... BaseContracted service uses a `model` reference that it doesn't define itself, neither does some of the dependent services. To avoid this, make sure the BaseContracted gets an optional model attribute that can be set.	4 years ago
Oliver Günther	530e9174b0	Add test for base callable service	4 years ago
Oliver Günther	01954c26bc	Refactor copy services to use shared state	4 years ago
Oliver Günther	582e9dce07	Retain the public attribute AFTER the SetAttributeservice ... The public attribute gets reset in the SetAttributeService	4 years ago
Oliver Günther	95d1549858	Move legacy project copy spec to service spec	4 years ago
Oliver Günther	0230f41385	Retain order in copied work packages if query is manually sorted	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
ulferts	9c9ef5b6fd	method extraction	4 years ago
ulferts	f612752b9a	handle erroneously missing start_date when scheduling	4 years ago