3091 Commits (74878c41af7a388ece23cd1eca848e38c52a6ef1)

Author	SHA1	Message	Date
Oliver Günther	7cb8d62e92	Fix max_attempts for StorageUpdaterJob ... This sets `max_attempts` for StorageUpdaterJob to 1, as we prefer having an external event retrigger storage counting rather than retrying from delayed_job. The reason behind this is failing counting due to I/O or other unforeseen issues (e.g. mount not available, .. ). In this case, recounting soon after will not solve the problem and only increase load on disk.	9 years ago
Alexander Bach	d2fee1e293	Adjust test expectation to direction changes	9 years ago
Alexander Bach	9fc6ab537e	Add routing specs for modified route	9 years ago
Jan Sandbrink	0702683116	Fix bad method call for version custom fields ... exploring the down sides of isolated unit testing :(	9 years ago
Oliver Günther	d81b20fee4	Restyle navigation and instructons on show and empty ... This commit provides: * Adjustments on breadcrumbs according to styling * Restored indent in repository table * Disallow closing checkout instructions on empty page The repository indent for opened folders was removed in the re-styling of tables in 7a844aa9d5	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Oliver Günther	14e74596a3	Allow multiple toolbars to exist, extend toolbar functionality ... Previously, toolbars were thought to be unique on a page and thus identified by id. As repository now contains multiple, this was changed to class-based selectors. This commit also adds functionality in toolbars for: * Including select2 fields (proper scaling). To avoid too small selects, toolbar select2 fields are at least 150px wide * Including inline labels in toolbars * Prepended and appended inputs * Icon-only icons (they require font-size changes and a small offset)	9 years ago
Oliver Günther	5ff736ad55	Force english locale on browser profile	9 years ago
Jan Sandbrink	3f269e43ae	Add link to delete an attachment to its representer	9 years ago
Jan Sandbrink	e7a6ae629e	Add specs for update links with missing permissions ... - also (for now) remove title text which was not localized - consistently use link helpers for the corresponding specs	9 years ago
Jan Sandbrink	e7291fba8c	Unify permission handling in representer spec	9 years ago
Jan Sandbrink	aad39544f5	Hide addAttachment link when user is not allowed	9 years ago
Jan Sandbrink	5de0f15898	Correctly link activities ... - they might not be embedded - create an endpoint for activities - document it properly - adapt angular client	9 years ago
Jan Sandbrink	14a55b82d1	Do not embed linked resources in WP collections	9 years ago
Oliver Günther	22b7d2550e	Fix broken localized tests	9 years ago
Jan Sandbrink	5d473e9a9c	fix HTTP response of DELETE attachment ... this was wrongfully HTTP 202 (Accepted), which would only be valid if we did the deletion in a delayed/deferred way. For now using HTTP 204 (No Content), since we have no response body.	9 years ago
Jens Ulferts	db3681661d	fixes attachment download path in api ... Kudos to @oliverguenter for the fix	9 years ago
Oliver Günther	5b147e32d5	Storage performance and accuracy improvements ... This commit allows storage counting to shell out to `du` where available. The method uses du with `-bs` to count the apparent file size in bytes. Note that apparent size is NOT the same as the real required size on file system, but is used to be consistent with other sizes displayed in OpenProject (e.g., attachments size) When du is either unavailable or incompatible, in that it doesn't return the requested count, the ruby fallback counting method is used. This method has been slightly altered to use `File.stat` instead of `File.new(path).size` for reduced computational overhead compared to `du`.	9 years ago
Henriette Dinger	ca02263058	updated icon font, fixed broken specs and design bugs	9 years ago
Stefan Botzenhart	5dfa7802b7	Add controller spec for Project#custom_fields	9 years ago
Oliver Günther	15428ea827	Use styleguide pagination in PaginationHelper ... This commit updates the PaginationHelper to use the styleguide pagination style.	9 years ago
Alexander Bach	78efda7ee8	Remove project homepage field from all the specs	9 years ago
Stefan Botzenhart	7e74650e02	Fix rubocop concerns	9 years ago
Jan Sandbrink	d8ec635e9e	simplify interface for assignable values ... - one method to rule them all - eases overriding -> does not require to define method for new types on base class - allows to infer values_callback from property name (schema representer)	9 years ago
Stefan Botzenhart	984e06ea6b	Add concise method for settings page object	9 years ago
Stefan Botzenhart	406d365546	Add routing specs for settings	9 years ago
Stefan Botzenhart	e95fd22218	Move custom field selection for a project to its own tab ... * edit_project permission shall apply * add notice if action fails	9 years ago
Oliver Günther	925bc256cb	Fix failing specs on config with cost plugin ... The cost plugin overrides the default time entries module. However we can still convince the core to use the time entries module, simply by restricting the enabled module set.	9 years ago
Jan Sandbrink	9e8d051027	reintroduce form_embedded argument for schema ... we can't live without it :/	9 years ago
Jan Sandbrink	1ac1188ef8	fix spec double and remove users from groupable CFs ... - spec double was not up to date with reality of return values - user custom fields are not successfully groupable, because the order statement is a list	9 years ago
Jan Sandbrink	32e638449b	hide lockVersion from work package columns	9 years ago
Oliver Günther	701c49ab31	Correct parsing of string and octal chmod values	9 years ago
Jan Sandbrink	8e4321959e	improve code style	9 years ago
Jan Sandbrink	80fc96dee3	replace deprecated AR method	9 years ago
Oliver Günther	f982465a5d	Force tmpdir for storage spec ... We observed `lib/open_project/storage_spec.rb` to fail occasionally, which I assume has something to do with the existence of the attachments directory. The changed spec forces a tmpdir to be created and evaluates storage information on that path.	9 years ago
Oliver Günther	7e7386f3b6	Rework instruction display ... - Defaults to localized instruction when none is provided in the settings - Make readonly input visually clickable, not disabled - Renamed `permission?` to `permissions?`	9 years ago
Jan Sandbrink	637fadf602	add endpoint to list work package columns in a project	9 years ago
Oliver Günther	b98241e1cd	Compare with timezone info in legacy specs	9 years ago
Jan Sandbrink	bfcc769cfd	split implementations for work package schema ... - was already quite case-ish, depending on its creation via WP or via project + type - I plan on adding a third case, which would not improve the situation for a single class	9 years ago
Oliver Günther	0b0d17baec	Use repository from fixture in legacy spec	9 years ago
Jan Sandbrink	c03e1cfee9	replace deprecated :response calls by :rendered	9 years ago
Oliver Günther	c9d3dabab2	Delete repository: Fix internal error on lacking permissions ... While rolling out on dev, we found that apache by default modifies the access permissions of a repository. This in turn causes the deletion of a repository to no longer complete sucessfully, but return with a permission error. This error was not caught an escalated into a 500 on the repository settings.	9 years ago
Jan Sandbrink	114c602a09	replace deprecated find(:first/:last, ...) finders	9 years ago
Oliver Günther	1219e08c1c	Remove deprecated finders in repository spec	9 years ago
Alexander Bach	b9be211f35	Add watcher notification job specs	9 years ago
Alexander Bach	81606714d9	Add specs for new mailer method	9 years ago
Oliver Günther	ef322e89dd	Cleanup	9 years ago
Oliver Günther	3fce1d6f2e	Added service and controller specs	9 years ago
Jens Ulferts	b042205c8c	adapt spec, introduce features/page_objects ... The features/page_objects folder should house all the page objects used within specs	9 years ago
Jan Sandbrink	e978876acc	fix expectations in legacy spec ... - real code is actually able to deal with arrays being returned from sortable - simplified group by sorting	9 years ago