openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	edf713fbd5	Rework managed repositories error handling This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Oliver Günther	bb2a09490b	Remove delayed running of management workers. This commit (temporarily) removes the delayed creation and deletion of managed repositories for the sake of improvded error handling. After consultation with @ulferts, we suggest to improve the `Delayed::Job` pipeline to create means for identifying jobs (referenced ID) and to create a unified service to manage database AND filesystem access in a transactional manner. Also provides the following corrections: - Improve migration speed - Delete parent projects only by their identifier, not the managed root	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Alex Coles	ea713284a8	Fix syntax (w/Rubocop) in workers Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	2fbbccb50c	move error handling up RecordNotFound would now already occur due to :recipient call in :perform method.	9 years ago
Jan Sandbrink	4bee848f3d	style	9 years ago
Jan Sandbrink	7d634d57ad	execute mail jobs in context of their recipient	10 years ago
Jan Sandbrink	95c0d0a013	pull recipient & author up into MailNotificationJob	10 years ago
Jan Sandbrink	d43803ce85	use more specific names than user author and recipient are matching the domain they are employed in (mail delivery) closer. Especially the name 'current_user' only happens to be the thing being assigned as author, but does not transport any special meaning in itself.	10 years ago
Evghenii Barhatov	a609680483	Allow raising exceptions from notification jobs	10 years ago
Evghenii Barhatov	25862b3244	Allow raising exceptions from notification jobs	10 years ago
Jan Sandbrink	1f3b47f461	test and fix mail delivery - add specs testing the observable behaviour - keep the interceptor mostly intact - use the same hack already known	10 years ago
Markus Kahl	0bb1a7b4a9	extract what little common code there was	10 years ago
Markus Kahl	21553ea918	avoid 500 upon mail failure when creating issues also log the errors with specific tag so they can be found	10 years ago
Markus Kahl	0633aa7b1e	created delayed job object for wp update emails	10 years ago
Markus Kahl	ba7d247817	use IDs in CopyProjectJob; send mail synchronously also moved the job into the workers directory	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Markus Kahl	a33c8fa312	API v3 delete user	10 years ago

1 2

80 Commits (74c81447a405c33319b8b4344b7f926991ef6331)