openproject

Commit Graph

Author	SHA1	Message	Date
Alex Coles	0f9240037a	Fix TimeEntry cleanup on work package bulk delete Fix `WorkPackage.cleanup_associated_before_destructing_if_required` semantics so that the first argument can either be an individual `WorkPackage` (as the spec originally expected) or a collection (as in actual usages). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	abf4a011f0	Fix copying of versions on Project copy Adds a more robust solution for copying closed versions and associating with copied work packages (see original patch `10ec20a8`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	19ed4dc9ab	Replace more deprecated shoulda matchers in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	dc7b71a110	Use #describe with String arg not symbol See core commit: `3785fdc9ed` Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	ad5b7b3c62	make spec localization independent	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	33748ede31	Remove by qualifier in neg. #change expectation No longer supported. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6cd0cad516	Remove #errors_on usages in specs This behaviour would now require `rspec-collection_matchers`. See https://github.com/yujinakayama/transpec#note-about-expectmodelto-havenerrors_onattr Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	15f52bcdc6	Added validation for estimated hours values	10 years ago
Alex Coles	c13b9a59ff	Convert specs to RSpec 3.2.0 syntax with Transpec This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 11 conversions from: it { should ... } to: it { is_expected.to ... } * 3 conversions from: be_true to: be_truthy * 1 conversion from: be_false to: be_falsey * 1 conversion from: failure_message_for_should { } to: failure_message { } * 1 conversion from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	de309f0eee	polish	10 years ago
Markus Kahl	104b70cc62	work package notification mail specs	10 years ago
Jan Sandbrink	925a1fb706	don't pick the (random) last journal pick the first (and hopefully only) journal that has customizable journals	10 years ago
Jan Sandbrink	264c58980b	change expectation back to falsey be_false == be_falsey, both expect falsey results alternative would be "be false", which expects real false... confused	10 years ago
Jan Sandbrink	0dcd0a0c84	fix weird specs probably only worked because of unintended validation error from automatic validation: - testing to pass nil as value, though nil-values were explicitly ignored - assuming a single journal entry, though the WP is saved twice really needed to be fixed, because of new implementation: - valdiation errors now indicate CF id and are more specific	10 years ago
Alexander Bach	f403d6aaaa	Increase category validation strictness	10 years ago
Alexander Bach	03494dae0a	Some style improvements	10 years ago
Alexander Bach	92618be3ed	Added tests for category writing	10 years ago
Jens Ulferts	a70bbd7045	improve performance of watcher determination	10 years ago
Markus Kahl	3885978d87	fixed toppler [1] by not using anon user to update [1] a test that may or may not fail depending on the time of day, the weather, or the kind of pants you wear.	10 years ago
Jens Ulferts	0f6357eec6	fixes wp validation for inexistent versions	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Hagen Schink	f074e6fe54	Test that non-existing WP status returns only one validation error	10 years ago
Hagen Schink	2dc0446701	Move WP move test to spec and update its specification With the additional validation of a WP's children, a move of a WP to another project is only valid if cross project relations are allowed. The old test didn't consider that setting and just assumed that a WP move is valid across project borders in any case (even if cross project relations are forbidden).	10 years ago
Jens Ulferts	c4f2463629	replaces deprecated method	10 years ago
Alex Coles	f95c9d15f3	Prefer #map over #collect in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	56b07b0a87	Cleanup whitespace Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	714966de5c	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 13 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 4 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 2 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	cb08667307	Mark broken WorkPackage specs as pending `is_expected.to` (equivalent to `expect(subject).to`) with an explicit subject appears to have different semantics to plain `should`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	8346d25853	Fix incorrectly added type metadata Broken in `e137ed81` Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Jens Ulferts	dbf4680c05	fixes spec flicker by ensuring settings	11 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { \|example\| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	b25b2e7cb5	Fix incorrectly converted validation assertions Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	8cd802c0df	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 1.12.0 with the following command: transpec * 234 conversions from: obj.should to: expect(obj).to * 139 conversions from: == expected to: eq(expected) * 25 conversions from: obj.should_not to: expect(obj).not_to * 20 conversions from: be_true to: be_truthy * 19 conversions from: be_false to: be_falsey * 9 conversions from: obj.stub!(:message) to: allow(obj).to receive(:message) * 8 conversions from: =~ [1, 2] to: match_array([1, 2]) * 5 conversions from: it { should ... } to: it { is_expected.to ... } * 2 conversions from: collection.should have(n).items to: expect(collection.size).to eq(n) * 1 conversion from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 1 conversion from: lambda { }.should_not to: expect { }.not_to * 1 conversion from: obj.stub(:message) to: allow(obj).to receive(:message)	11 years ago
Alex Coles	efe24e1049	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 1.12.0 with the following command: transpec * 100 conversions from: it { should ... } to: it { is_expected.to ... } * 17 conversions from: expect(collection).to have(n).items to: expect(collection.size).to eq(n) * 10 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 9 conversions from: be_true to: be_truthy * 9 conversions from: expect(obj).to have(n).errors_on(...) to: expect(obj.errors_on(...).size).to eq(n) * 8 conversions from: obj.should to: expect(obj).to * 4 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 2 conversions from: be_false to: be_falsey * 2 conversions from: expect(obj).to have(n).error_on(...) to: expect(obj.error_on(...).size).to eq(n) * 2 conversions from: pending 'is an example' { } to: skip 'is an example' { } * 1 conversion from: before { example } to: before { \|example\| example } * 1 conversion from: expect(collection).to have_at_least(n).items to: expect(collection.size).to be >= n * 1 conversion from: obj.unstub(:message) to: allow(obj).to receive(:message).and_call_original * 1 conversion from: pending to: skip	11 years ago
Alex Coles	81682a7417	Fix whitespace in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Michael Frister	68c7f933af	JournalManager: Fix attempting to create two journals with same version Calculate journal version based on existing maximum instead of count. Up to now, when removing a journal note with another journal entry existing afterwards, there could be a single journal with version 2, resulting in validation errors for the next attempt to add a journal.	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { \|example\| example } * 1 conversion from: pending to: skip	11 years ago
Martin Linkhorst	d92a32be6f	remove superfluous disabling of async jobs	11 years ago
Alex Coles	90c906d599	Fix typos, spelling in spec descriptions Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Hagen Schink	109e770e5f	Adapt specs to non-key usage	11 years ago
Alex Coles	a1718ca674	Replace #=~ (operator matcher) with #match_array RSpec expect syntax no longer supports this operator matcher. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Hagen Schink	321932ca7d	Adds spec	11 years ago
Hagen Schink	678b0bc187	Adds spec	11 years ago

1 2 3 4 5

211 Commits (752743a349dbe013fe46c6a00778cd77d42ce1a8)