48 Commits (7979f9eea7b20256e1c157058e3d46df9a0095b9)

Author	SHA1	Message	Date
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	f121e610db	Pass current_user into all AttachmentRepresenters	9 years ago
Jan Sandbrink	3f269e43ae	Add link to delete an attachment to its representer	9 years ago
Jan Sandbrink	5d473e9a9c	fix HTTP response of DELETE attachment ... this was wrongfully HTTP 202 (Accepted), which would only be valid if we did the deletion in a delayed/deferred way. For now using HTTP 204 (No Content), since we have no response body.	9 years ago
Jan Sandbrink	b332ef06aa	make collection representer explicitly unpaginated	9 years ago
Jan Sandbrink	fd3312a0f2	extract attachment storing into service ... - service cares about adding a journal too - only store the attachment when the journal can be saved (i.e. the WP is valid)	9 years ago
Jan Sandbrink	88e052a53e	style ... [ci skip]	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	8e015c9e95	add specs for metadata representer	10 years ago
Jan Sandbrink	08fa23d82e	please the hound	10 years ago
Jan Sandbrink	6075d3d7c9	extract method	10 years ago
Jan Sandbrink	c4e51404c2	move uploaded file creation out of api endpoint	10 years ago
Jan Sandbrink	7d443154b3	parse attachment metadata using a representer ... - adding general error handling for parse errors - changing the default error message for parse errors, which was very form specific before	10 years ago
Jan Sandbrink	603f30f794	some cleanup ... I just extracted some methods... the basic mess is the same, but hidden behind some methods... think of a pig with make up, it looks good, but it is still a pig.	10 years ago
Jan Sandbrink	ee05610d5d	add specs for the unhappy pathes ... those are quite a lot of specs for an integrative test however at the moment there is (too) much logic in the endpoint itself, so this seems to be neccessary	10 years ago
Jan Sandbrink	9a9d6aca2c	ensure correct file size errors are displayed	10 years ago
Jan Sandbrink	9cd03b0586	correct (but ugly) upload error handling	10 years ago
Jan Sandbrink	db3b9da3a8	make attachment upload WORK ... lets see if we can make it GOOD, I think it already is FAST ^^	10 years ago
Jan Sandbrink	8585637981	list attachments of a WP via APIv3	10 years ago
Jan Sandbrink	b41539f9fb	delete attachments via APIv3	10 years ago
Jan Sandbrink	cde374a6d5	rework attachments endpoint according to spec ... - drop useless properties - add essential properties - for now limit to work packages only	10 years ago
Jan Sandbrink	900b2a4c45	Backporting APIv3 categories to OP 4.0 ... Backport was neccessary to implement missing categories filter without adding more technical debt. These changes will be merged into 4.1 and following branches and vanish in that merge (merge-strategy "ours") YOU SHOULD NOT SEE ANY CONTENTS FROM THIS COMMIT ANYWHERE AFTER 4.0.x! This commit was built from the commits of the GitHub-PR mentioned below, as well as some code dependencies for that. The GitHub-PR was https://github.com/opf/openproject/pull/2505	10 years ago
Jan Sandbrink	a9e9881c4f	style	10 years ago
Jan Sandbrink	b1ba33c75b	specify classes explicitly rather than implicitly ... This is a new try for the APIv3 classes, we either: - FULLY qualify a class and let the autoloader do the rest - don't qualify at all, but require the class explicitly Thus we do not (yet) completely give up on the rails autoloader, but we circumvent a fair amount of its magic (and problems). The hope is to eliminate the following problems in development mode: - NameErrors because the autoloader infers the wrong prefix - "object is not missing constant" errors occuring more rarely Let's see how that turns out to work...	10 years ago
Jan Sandbrink	5a104cbcf2	fully qualify class for better dev mode	10 years ago
Jan Sandbrink	f0863f9d53	allow to patch existing API endpoints	10 years ago
Jan Sandbrink	a72ea0d5af	more consequently use route_param ... this seems to be the GRAPE-iest way possible	10 years ago
Jan Sandbrink	83a42d82b9	fix auto loading of DateTimeFormatter during dev ... Apparantly the rails autoloader gets confused by trying to load a class from an included module. We can help it, by explicitly referencing (thus loading) the fully qualified class name first... I wish there was a better solution, but I couldn't find one...	10 years ago
Jan Sandbrink	cf54634a55	satisfy hound ... also make the private modifier less useless	10 years ago
Jan Sandbrink	c6323dbc10	refactor output of dates and times ... - all (?) APIv3 resources now use a common formatter - all APIv3 resources now use common names for "createdAt" and "updatedAt" - existing tests were adapted when they were wrong before (according to specs) - no unit tests for common formatter extracted yet	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	746f7cce74	Use API V3's path helper	10 years ago
Hagen Schink	6ec63bc9af	Update reform and its dependencies	10 years ago
Hagen Schink	db8bfba3af	Remove usage of reform from API V3	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	47b57c576c	Use paths instead of URLs in Resource links ... See specification commit: 7f40188581 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	92e8384266	Add missing Copyright headers in lib (API) code ... [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0bf314f149	Specify a custom Formatter for hal+json ... This avoids having to explicitly call #to_json: https://github.com/intridea/grape#api-formats Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Marek Takac	cf1d1bf9d9	Added specs for attachment API resource	10 years ago
Marek Takac	4bd16203ec	Added authorization for API show attachment endpoint	10 years ago
Marek Takac	5f050d3537	Created show attachment API endpoint	10 years ago
Marek Takac	e1ad040b3a	Created API attachment representer	10 years ago
Marek Takac	11a4fcb69d	Created API attachment model	10 years ago