78 Commits (7e1da485e5075d88121baf8fd4f581d7b0ac4642)

Author	SHA1	Message	Date
Markus Kahl	530aa631d5	don't count children twice when summing estimated hours	5 years ago
Oliver Günther	b81b5c3e3c	[29832] Split whitespace in like query ... https://community.openproject.com/wp/29832	6 years ago
Jens Ulferts	17023c9394	optimize search filter by moving condition to join criteria	6 years ago
Oliver Günther	1cd325bd5a	Ensure sql join in manual filter and sort column is isolated in query ... We depend on ordered_work_packages association for determining sort and filter for manual sorting. We could restrict the join result with where(query_id: context.id) later but that prevents the execution planner from optimizing on the explicit join clause. This PR introduces a sql join that depends on the query_id and thus retrieves the correct order performantly.	6 years ago
Oliver Günther	8ab4f2a663	Boards module (#7008) ... * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Push boards on grid * Use base class in scope [ci skip] * Extend api for options * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Save queries in grids [ci skip] * Renaming queries [ci skip] * Add existing work packages to board [ci skip] * Introduce card view component for work packages * Extend grids to allow project scope for boards (#7025) Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards). For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented. * introduce project association for boards * have dedicated grid registration classes * update and create form for board grids * extract defaults into grid registration [ci skip] * Add drag and drop to card view [ci skip] * Add options to grid * Fix option migration name * Renaming boards [ci skip] * Frontend deletion of boards * Avoid map on NodeList which doesnt exist [ci skip] * Add inline create to boards [ci skip] * Smaller create button [ci skip] * Add navigation for boards * Make inner grid same height * Replace index page with table * Workaround for widget registration [ci skip] * Fixed height for cards and tables [ci skip] * Implement escape as cancel d&d action [ci skip] * Fix and extend grid specs for name and options * Extend board specs for required name * Fix migration for MySQL references https://stackoverflow.com/a/45825566/420614 * Make board list extend from widget Since we cannot configure widgets yet, it's not yet possible to use a board-list widget anywhere. * Fix specs * Fix escape listener removal [ci skip] * Fix renamed to_path in relation spec [ci skip] * Allow deletion of grids for boards * Avoid reloading resource multiple times with replays * Frontend synchronization on deletion [ci skip] * Delete through table * Use work packages board path * Use work packages board path * Fix augmented columns breaking re-rendering * Fix duplicated permission with forums * Strengthen tab switch in specs * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * private queries * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * Move boards below work packages * Add Board configuration modal * Fix reloading with onPush * Saving / Switching of display mode [ci skip] * Extract wp-query-selectable-title into common component * Fix renaming of board-list * Fix auto-hide notifications in boards * Add permissions to seeders * Reorder lists in board * Linting * Remove default gravatar from settings * Show assignees avatar in the card view of WPs * Fix specs * Add missing method * Fix timeline icon * Use URL as input to be able to show avatars for groups, too * Fix test * Add further specs * Use correct data attribute to avoid unnecessary data base calls * Add further specs * Deletion of board lists * Pass permission via gon to decide whether we can create boards * Fix rename spec * Cherry-pick of 7873d59 and 30abc7f	6 years ago
Wieland Lindenthal	b060d83412	Feature/29218/search autocompleter (#6942) ... * Search autocompletion on work package subjects * cleaning up * Add status dot to autocompleter results * Add feature test for global search autocomplete * fix: remove update at from suggestions * Style search autocompleter results * fix: loading animation position * Extend search autocompletion to also search on work package IDs, too, allowing even the hash sign (#) to prefix an ID. * Move stop spinning into a separate method. * increase delay for search autocomplete * Travis debugging: reverse order of expectations * Travis: fix specs for search autocomplete * Fix spec for search auto completer * Ensure WP highlighting is always loaded, when needed. * fix spacing between animated bars of loading indicator [ci skip]	6 years ago
Wieland Lindenthal	d800854de0	Fix bug. Wrong operator was set.	6 years ago
Wieland Lindenthal	ce6c208e7e	Add CommentFilter and include it into SearchFilter	6 years ago
Wieland Lindenthal	a48ef771d3	Add operator "everywhere" to SearchFilter. ... Remove duplicate listing of NotEquals operator.	6 years ago
Wieland Lindenthal	2a47d8f512	Refactor SearchFilter to combine other filters.	6 years ago
Wieland Lindenthal	c64cbc38d1	Add DescriptionFilter for work packages	6 years ago
Wieland Lindenthal	4fc70d8951	Create SearchFilter on work packages that searches on: ... - subject - description - attachment file name - attachment file content	6 years ago
Oliver Günther	1d65582a50	[29184] Validate with old parent templated value ... https://community.openproject.com/wp/29184	6 years ago
Oliver Günther	ae8db4011a	Fix more deprecations	6 years ago
Wieland Lindenthal	fd88776ceb	Add relations tables to Types via form configuration (#6773) ... * WIP: PrecedesFilter and FollowsFilter for WorkPackages * Create Type Form Groups per Query Type * generalize filters on relations avoiding alias * fix flickering spec * Rename dependency represeners for Follower and Predecessor Filters * Allow configuring templated queries within query configuring modal * Use `{id}` as templated value, instead of a now deprecated `templated` string * Rewrite ParentFilter to follow same structure as other relation filters. * Set Follower and Predecessor filters as hidden in Frontend * Default query shall show closed WPs, too * Remove relation filter type selection from form configuration view as we extend query configuration modal instead. * Allow ExternalQueryConfiguration to be more specific and prepend relation filters in its modal. * Quick unrelated fix on the way: the instruction text should start below the columns input and not to the right of it * - Add all missing relation filters. - Use verbs for naming instead of nouns to stay consistent with UI. * fix typo * Add relation filters to hidden filters and fix a rebase bug * Typo in docs * Fix broken rebase conflict resolution * Add part of and includes filter * adding specs for relation filters * rename RelatesFilter to RelatesToFilter * Rename shared example as direction does not matter anymore. * Fix spec for IncludesFilter * Fix name conflict for `includes` by calling typed_dag's `direct` later. * Fix shared filter examples as the parent filter does not get added per default anymore. * Fix spec after renaming PredecessorFilter to PrecedesFilter * Fix integration spec for type configuration form * Add filter dependency specs * Differentiate between WorkPackageFormChildrenQueryGroup and WorkPackageRelationQueryGroup types * Create inline-create for relation tables * Rewrite filters to use actual relation_type as key * Reload relations on change, change symbols * Fix relation filter i18n strings * Test presence of all relation filters frontend. * Extend integration test for form configuration to not only cover hierarchy, but also undirectional and directional relation types. * Consistent naming of filter dependency representer files * Satisfy codeclimate * Add missing copyright notes * Fixing PartofFilter and its specs * Reverse relation direction when created inline * WIP integration test for Relation Query Component and Children Query Component. * Correctly reload children tables when refreshed * Fix FilterOnUndirectedMixin * Fix removing of relation from embedded table after reload * Adding intergration tests for removing and adding relation or children, initiated form either embedded table or relations tab. * Fix specs * Fix implementation of duplicates and duplicated They are reversed in typed_dag and causes confusion [ci skip]	6 years ago
ulferts	4209539da9	Feature/angular calendar (#6766) ... * replace rails based calendar with angular * render empty calendar * update query on month switch * introduce specific interval filter * show colors * remove now unused filter partial * start on retaining the view in the url * hide datesInterval filter * I18n for calendars title * stengthen explicity of expected filters * spec moving to the next month * fix FilterSerializer reference * remove outdated feature spec * rework calendar controller specs * avoid undefined columns * bump ng-calendar to 1.7.0 * Revert "fix FilterSerializer reference" This reverts commit 2bb2e574cdd664a02a4eb9c3e94b5a170aec0a67. * Revert "avoid undefined columns" This reverts commit bcbb381b34b095526d3ee1aa15d6263a658c03c0. * load initial query only after calendar has been loaded * implement month remembering * implement history back and forth * cleanup code * remove unused methods * remove order value from filters * replace rails calendar widget completely * fix shrinkwrap * move module into correct namespace * linting * remove unused js * calculate full calendar height dynamically * setting calendar locale from service * retain week on reload * show notification in case of too many results * show tooltip on hover * go to work package on click * deactivate tooltip before wp show * narrow down style to tooltip * [28885] Improve html title consistency when navigating to queries Currently, query names are not reflected in the HTML title. This results in 'wrong' titles being shown when entering a split or full view and then returning back to the list. https://community.openproject.com/wp/28885 [ci skip]	6 years ago
Wieland Lindenthal	41475549a6	Remove CSS classes that were only used in feature spec	6 years ago
Jens Ulferts	eb726a41a8	provide the query as context for cf filters ... This is important e.g. * when determining validity of filter values * when querying for valid filter values in the filter schema representers	6 years ago
Wieland Lindenthal	1dcb43623e	Add more highlighting specs for api v3	6 years ago
Jens Ulferts	98ed6b521c	allow filtering by accountable group	6 years ago
Oliver Günther	14fd7d2eb4	[28475] Fix usage of value objects in subproject filter ... https://community.openproject.com/wp/28475	6 years ago
Oliver Günther	1c0a3cf82b	Avoid plucking only :id on a mapped query that orders by name ... This will fail in postgres	6 years ago
Oliver Günther	1c7626efe8	[28348] Coalesce values for contains filter ... https://community.openproject.com/wp/28348	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Jens Ulferts	fa2b0fa1d9	clean up templated filter values	7 years ago
ulferts	3881b47e26	add parent filter to wp query (#6235) ... [ci skip]	7 years ago
Wieland Lindenthal	4e16b1a692	Fix: These tests should not do anything when the DB does not support TSVector	7 years ago
Wieland Lindenthal	c8d610e2ba	Satisfy rubucop	7 years ago
Wieland Lindenthal	af5f21b757	Add EnterpriseToken logic to attachment filter specs	7 years ago
Wieland Lindenthal	5b58d77c05	Adding pretty generic specs for attachment filters.	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	a1812699f0	validate actions	7 years ago
Oliver Günther	67b57b8a04	Code style	7 years ago
Oliver Günther	7dc9df3aee	Adapt specs to factory pattern	7 years ago
Oliver Günther	e7294110c0	[26392] Don't map value objects to nil (#5955) ... https://community.openproject.com/wp/26392 [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again ... The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	75d2f010ba	[25108][26176] Assigned_to filter returns group values ... Since 7.0.0, the `assigned_to is <user>` filter also returns work packages assigned to a group that `<user>` belongs to. Since this is misleading and judged a bug by several customers, instead add a new filter that provides exactly this behavior, while using `assigned_to` only for the exact value specified there. https://community.openproject.com/wp/26176 https://community.openproject.com/wp/25108	7 years ago
ulferts	4d95cc815f	Feature/guarded relation columns (#5784) ... * refactor case statement * guard relation columns by enterprise token [ci skip]	7 years ago
ulferts	39bbf082bf	fix author filter for projectless users (#5718) ... As the principals returned by the principals API where limited to those that are members in projects the user can see, users not having any project would not be returned. This is intended in so far as to prevent getting all users easily. But the user herself should be visible in any case. [ci skip]	7 years ago
ulferts	55695ed756	adds query columns by relation type (#5625) ... [ci skip]	8 years ago
ulferts	20dd8a6e0a	Feature/work package id filter (#5614) ... * add filter for work packages by id to query * hide the id filter in front end As we do not yet have satisfying means to display the filter values for selection, we hide the filter and use it internally only [ci skip]	8 years ago
ulferts	ace7098eb3	add relations columns to query (#5606) ... * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
ulferts	86c2f3d59d	Fix/increase query api robustness (#5574) ... * removes unavailable filters on valid_subset! * remove invalid columns on valid_subset! * cleanup query form and collection * code prettification * add status to spec in order to have valid queries [ci skip]	8 years ago
ulferts	2a71172837	prepare the query before reading results (#5547) ... * prepare the query before reading results * use string for list cf filter value because all other list filter also use a string * handle invalid group, columns, sort on query read [ci skip]	8 years ago
Jens Ulferts	8aebddb606	splash groups on assignee filter	8 years ago
Jens Ulferts	1fe880ad1b	prevent query filters loosing their context	8 years ago
Jens Ulferts	a4ae0e9b65	allow active, invited and registered users to be filter values	8 years ago
Jens Ulferts	b01681d328	increase custom field filter robustness	8 years ago
Jens Ulferts	8a08856748	replace string object by custom option for list custom fields	8 years ago