1330 Commits (7eae8f3f86e900659c15dda8b5a953acf51a5daa)

Author	SHA1	Message	Date
Jens Ulferts	b8c7d77683	unpersisted WPs are considered leaves	9 years ago
Jens Ulferts	5e6d657a35	remove no longer required dynamic spec generation	9 years ago
Jens Ulferts	11d7e428ad	reuse version calculation on eager loaded projects ... Eager loading projects assigns the same object instance to each work package having the same project_id. When the first project evaluates the assignable versions, the result can be memoized to be used by other work package having the same project	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Markus Kahl	c1d56bffea	followed deprecation warning	9 years ago
Markus Kahl	b071308444	fixed broken permitted param specs	9 years ago
Jens Ulferts	0980f01a95	copy over symbol in custom value to customizable ... We need to have access to the original symbol so that the API v3 can post process the errors on the custom fields just like it does every other field. When only a string is provided, the symbol :unknown is stored which will lead to the API rendering error messages like "can't be blank" (without the erroneous field name).	9 years ago
Oliver Günther	353039fcfe	Allow PermittedParams to receive new keys from plugins ... Previously, PermittedParams allowed only the extension of existing keys with new attributes from plugins. Since we now need to extend strong_params from global roles in impermanent memberships, we can prevent load-order dependencies by injecting a new key in the permitted params hash into the core.	9 years ago
Stefan Botzenhart	a71e253841	Rename spec description ... This is require so we can disable it within a plugin. Somehow rspec example disabler has problems with quotes.	9 years ago
Stefan Botzenhart	ba3c727dcc	Remove pending specs	9 years ago
Jens Ulferts	c7ea46c82a	avoid creation of production class in spec ... Defining the constant CostQuery::SqlStatement will result in ruby/rails no longer looking for it in the file system. What was intended here was to reopen the class to add mocks. But if the test runs before the class is loaded initially, it defines the class and ruby will no longer look at any other place for the original file. The class created then has only a subset of the methods the original class has resulting in test failures.	9 years ago
Stefan Botzenhart	6f2418eacc	Remove warning undefined constant CostQuery::Validation	9 years ago
Mohamed Wael Khobalatte	e10cc2d6ad	Pass project_id instead of project instance to version_attributes	9 years ago
Stefan Botzenhart	a30a2c83f0	Fix rubocop issues	9 years ago
Stefan Botzenhart	463a115d6c	Fix rubocop issues	9 years ago
Stefan Botzenhart	19bf02ab0f	Show and hide the results container ... This fixes a markup bug in firefox where the no-results container was not visible after the last global role was removed.	9 years ago
Stefan Botzenhart	3030d1336e	Fix rubocop issues	9 years ago
Oliver Günther	589ba8e7b1	Relocate repositories locally and remote ... This commit introduces relocating a repository as a followup after a project's identifier has been renamed.	9 years ago
Mohamed Wael Khobalatte	18ac022927	Add specs for new strong_params methods	9 years ago
Mohamed Wael Khobalatte	a1bf92212d	Fix legacy and cucumber specs failing because of strong params	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Oliver Günther	02807e02a8	Refactor CopyProjectJob to class	9 years ago
Jens Ulferts	b0a86a69c2	refactor types action on projects controller ... * Introduced a service to reduce complexity in the controller * Used permitted params to ensure params syntax * Introduced a scope for querying for types used by a work package of the project	9 years ago
Mohamed Wael Khobalatte	7e7868b5a9	Send `watcher set` emails only when said watcher allows email notifications.	9 years ago
Jens Ulferts	c3ab585e80	remove dead code	9 years ago
Jens Ulferts	60a7e8a0d3	add spec for saving of preferences refered to as other ... Was wondering if sending of "others_will_change!" is necessary but apparently, it is not	9 years ago
Jens Ulferts	7eb8bdad53	invert setting for self notification ... Using the positive version to make it easier to understand. In order to avoid having to write a migration, the model layer encapsulates the transformation. Direct assignments to :no_self_notified is still possible.	9 years ago
Stefan Botzenhart	89c982f003	Remove manual spec retries	9 years ago
Oliver Günther	acb4431d8a	Implement UserPreferences endpoint ... Provides the implementation to the user preferences endpoint.	9 years ago
Mohamed Wael Khobalatte	4764684089	Ensure warning-free use of `raise_error`	9 years ago
Mohamed Wael Khobalatte	c885551329	Pass id to AR's `exists?` and `find` instead of an instance	9 years ago
Stefan Botzenhart	1c01b5801e	Use login_as helper method throughout all specs	9 years ago
Stefan Botzenhart	1f603b3d1e	Retry principal spec	9 years ago
Stefan Botzenhart	33dbbc2f39	Provide fixtures for legacy specs	9 years ago
Jens Ulferts	5937cf4999	fix typo	9 years ago
Jens Ulferts	d279e2a3ce	use delegation for available assignees/responsibles ... And only spec that delegation. The specs on project test the actual behaviour.	9 years ago
Jan Sandbrink	e9031a38b1	Reintroduce clear statements that were still neccessary	9 years ago
Markus Kahl	4eda276ecb	always clear delivieries so one does not have to worry about it	9 years ago
Jens Ulferts	0b2f482797	move :preference to principal ... This allows for eager loading preference. As the UserPreferences are pretty specific to users we don't want groups to actually receive a UserPreference, though. The methods added by has_one are therefore undefined on the Group model.	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Jan Sandbrink	f766454123	Make specs resilient against timezone issues ... x.days.ago and x.days.from_now will return UTC times relative to the current time. Date.today will return the current date for your timezone. Under CEST this means between 0:00 and 2:00 Date.today == 1.day.from_now.to_date I declare that this is not a bug of the cost entry, but a bug of the spec, since the CostEntry.spent_on and Rate.valid_from only deal with dates, not with datetimes. (i.e. conversion from datetime to date is the callers responsibility)	9 years ago
Oliver Günther	15273724c3	Homescreen functionality ... This commit adds the homescreen functionality to OpenProject, replacing the default welcome screen. This adds support for: * Blocks of content for various privilege levels (latest projects, users, news, etc.) * Links to common functionality (administration, community) Relevant work package: https://community.openproject.org/work_packages/19722	9 years ago
Oliver Günther	c13afd01c4	Force disabled_types to be symbols ... To avoid exposed types from misconfiguration (or installations where string-based configuration is a requirement), we convert the input from `disabled_types` to be symbols.	9 years ago
Oliver Günther	9ff73c2c31	Set enabled SCM types in storage spec	9 years ago
Stefan Botzenhart	3fccb90c57	Use factory girl instead of object daddy	9 years ago
Oliver Günther	22b7d2550e	Fix broken localized tests	9 years ago
Alex Coles	930a48a192	Fix patched WorkPackage#done? ... Use `Enumerable#include?` rather than `ActiveRecord::Relation#include?` as `done_statuses` may not yet be persisted. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8ea8a13a8c	Fix obsolete .first w/cond. in Operator spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	770a4a6097	Remove redundant .all call in AR query chains ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	c31caa5eba	Migrate obsolete AR finder/query methods ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago