openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	eefbb413e7	performant visible condition on relations query (#6290 ) [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Jens Ulferts	b25b266cbf	reduce duplication	8 years ago
Jens Ulferts	bebf6ec086	fix filtering relations in v3	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	debaeb4b5f	eager load for representer	8 years ago
Markus Kahl	bc444a86ec	filters for relation API	8 years ago
Markus Kahl	6023755e06	polish	8 years ago
Markus Kahl	304806b322	moved create relation into work package scope	8 years ago
Markus Kahl	cdf472d9ba	more specs e.g. for validations including permissions	8 years ago
Markus Kahl	7f6d74a88e	basic crud	8 years ago
Markus Kahl	994e0db591	add rel desc; brought representer up to spec	8 years ago
manuschiller	0b2ec6cfcb	fix codeclimate: line was too long	8 years ago
manuschiller	1795f1bf47	fix empty params after whitelisting	8 years ago
manuschiller	0bb457076b	fix empty params after whitelisting	8 years ago
manuschiller	3897ac4d2d	Fix empty symbol properties of declared_params	8 years ago
Jens Ulferts	8136a3a26f	implements a relations collection * Replaced the non standard array on the work package resource with the collection * Adds an endpoint for querying for the resource * adds a link pointing to the endpoint to the work package resource Does not add an end point for querying for a single relation. There is a link in the relation resource but it points into the void. Does also not improve the weird behaviour of changing the relation type based on the work package passed into the representer	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in `74228b59`. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	dea02be5b8	return proper error when adding invalid relations Error could probably be improved, but so can the whole relations endpoint... I'd consider this a strong case of broken window syndrome and will fix it as soon as we fix the whole relations endpoint...	10 years ago
Jan Sandbrink	a250ede762	return proper error when adding invalid relations Error could probably be improved, but so can the whole relations endpoint... I'd consider this a strong case of broken window syndrome and will fix it as soon as we fix the whole relations endpoint...	10 years ago
Jan Sandbrink	b1ba33c75b	specify classes explicitly rather than implicitly This is a new try for the APIv3 classes, we either: - FULLY qualify a class and let the autoloader do the rest - don't qualify at all, but require the class explicitly Thus we do not (yet) completely give up on the rails autoloader, but we circumvent a fair amount of its magic (and problems). The hope is to eliminate the following problems in development mode: - NameErrors because the autoloader infers the wrong prefix - "object is not missing constant" errors occuring more rarely Let's see how that turns out to work...	10 years ago
Jan Sandbrink	f0863f9d53	allow to patch existing API endpoints	10 years ago
Jan Sandbrink	a72ea0d5af	more consequently use route_param this seems to be the GRAPE-iest way possible	10 years ago
Hagen Schink	db8bfba3af	Remove usage of reform from API V3	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Marek Takac	99bda3c64a	Set relations delete endpoint to use correct id	10 years ago
Marek Takac	ff6714bfaf	Changed delete to destroy when removing relation	10 years ago
Marek Takac	3d6948662e	Changed the way relation is saved in relations API	10 years ago
Alex Coles	a89522e2df	Remove calls to #to_json in RelationsAPI Rely instead on custom Formatter: see `0bf314f1` Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Richard	e50db0208a	Use full error messages for relations validation.	10 years ago
Richard	62c9f793bb	Rename relations api namespace from id to relation_id.	10 years ago
Richard	b5f1346a4f	Track down super irritating related to/by bug	10 years ago
Marek Takac	68a526844d	Added authorization to creating and deleting relations	10 years ago
Marek Takac	651d524194	Added endpoint for deleting relationships	10 years ago
Marek Takac	613b71df0f	Added endpoint for creating relations	10 years ago

40 Commits (7fbb262e07d76201dd30cc82985a8d639a0d4baa)