798 Commits (7fbb262e07d76201dd30cc82985a8d639a0d4baa)

Author	SHA1	Message	Date
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Jens Ulferts	4cadd5fefc	remove monkey patching of production classes in spec	10 years ago
Jens Ulferts	e721e32266	allows for disabling caching ... This is necessary e.g. when switching databases within a process	10 years ago
Jens Ulferts	c638dfda0d	cleanup specs to avoid duplication	10 years ago
Alex Coles	424889897a	Migrate AR finder/query methods in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	61d77c721b	Fix TextFormatting#format_text specs w/requests ... * Make intent slightly clearer with a shared context. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	485c67f747	rework focus specs for accessiblity ... Specing for focus seems to be unreliable when using css selectors in selenium. Therefore a custom matcher is introduced to try to work around the issues. Additionally, it makes the specs easier to read.	10 years ago
Florian Kraft	8147a82a71	extract page maximization into shared context ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Florian Kraft	2db63a04a6	maximize the window before executing the specs ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Jan Sandbrink	08fa23d82e	please the hound	10 years ago
Jan Sandbrink	516c9a5f3e	move mock method out of production code	10 years ago
Alex Coles	3276c4ebb5	Add/update Copyright headers in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	131b00b04c	Make labelled shared examples assert title present ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c2e715373e	Use #describe with String arg not symbol ... See core commit: http://github.com/opf/openproject/commit/3785fdc9edb187b9e5239879d6f5e41 1a10ae3df	10 years ago
Jens Ulferts	6e74704268	allow to specify class on form container	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm ... Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Alex Coles	b79f21bb21	Avoid ambiguous method naming in matchers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c13b9a59ff	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 11 conversions from: it { should ... } to: it { is_expected.to ... } * 3 conversions from: be_true to: be_truthy * 1 conversion from: be_false to: be_falsey * 1 conversion from: failure_message_for_should { } to: failure_message { } * 1 conversion from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	763e576be7	Add a #within_path option to #be_html_eql matcher ... * Update TabularFormBuilder spec to use #within_path Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	054cff6013	Make #be_html_eql matcher raise on invalid path ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	cf40b1628b	Fix if statement indent in #be_html_spec matcher ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2a96e2682f	Add #be_html_eql matcher ... We use our own matcher rather than the `be_equivalent_to` matcher provided by equivalent-xml, because: * we want match fragments at a specific (CSS) path. * we want similar semantics to json_spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	a70bbd7045	improve performance of watcher determination	10 years ago
Jens Ulferts	46258c6e0b	remove duplicate form-container + unnecessary dom attributes	10 years ago
Alex Coles	89572a281c	Fix SettingsHelper field label: false handling ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e6397977ce	Extract duplicated shared examples into own file ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	ddd6e3157c	disable spec because of selenium/FF35 incompatibility	10 years ago
Alex Coles	f0b95955a0	Normalise syntax with Rubocop ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	31d1d4b297	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	0ab10c0e1e	refactoring	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	25b1733356	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Philipp Tessenow	2568c2a2d7	whitespace fixes and other minor things	10 years ago
Philipp Tessenow	6f3f9ac515	add specs for backup task	10 years ago
Alex Coles	356ec0bdee	Cleanup whitespace ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	f2af0595e1	Cleanup whitespace ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Hagen Schink	40847c0a6e	Add preview object authorization specs	11 years ago
Hagen Schink	f814fcf8b6	Make preview a normal view	11 years ago
Hagen Schink	b986fce447	Add specs	11 years ago
Alex Coles	7b30d42348	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 60 conversions from: obj.should to: expect(obj).to * 23 conversions from: == expected to: eq(expected) * 15 conversions from: obj.stub!(:message) to: allow(obj).to receive(:message) * 8 conversions from: be_true to: be_truthy * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 5 conversions from: be_false to: be_falsey * 5 conversions from: it { should ... } to: it { is_expected.to ... } * 2 conversions from: =~ [1, 2] to: match_array([1, 2]) * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: pending to: skip * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: obj.should_not to: expect(obj).not_to	11 years ago
Alex Coles	81682a7417	Fix whitespace in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { |example| example } * 1 conversion from: pending to: skip	11 years ago
Alex Coles	cf7d214906	Fix disable_flash_sweep spec helper ... Broken in previous commit 26ade602: RSpec::Mocks.allow_message is a lower-level API method, allowing us to define a stub outside of an ExampleGroup context. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago