791 Commits (803fd06a9a8ece8ebec00be07103aef319a29191)

Author	SHA1	Message	Date
ulferts	5edb64b2df	use default filter behaviour for wps available for relations ... That way, we can treat the end point as just another wp endpoint with filter capabilities. Currently, there is a couple of custom logic still present but that is only due to wanting to not break the public API. In the long run, the whole end point could be removed as the same filtering is now available using /api/v3/work_packages with an appropriate filter.	6 years ago
ulferts	41bb309094	disable wp schema caching until it is turned save for it again ... [ci skip]	6 years ago
Oliver Günther	f492113c94	[30275] Allow global type select, restrict available projects ... This allows to select all available types globally, and restrict the projects to the ones that have the type available. The same functionality applies to embedded tables, where a filter on a type will ensure that only the projects with the type selected will be returned. https://community.openproject.com/wp/30275	6 years ago
ulferts	1f537b20a2	avoid setting author outside of service	6 years ago
ulferts	6e5b81dc3f	add schema specific wp contract	6 years ago
ulferts	5b758c1419	differentiate between user and system set attributes	6 years ago
ulferts	a5defb73c5	add dedicated permission to regulate assigning a version	6 years ago
Oliver Günther	3f131c659c	[29487] Apply filter criteria to embedded table inline reference ... This applies all non-relation filters to the inline referencing functionality of embedded relation/child tables. https://community.openproject.com/wp/29487	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	8af3f78247	consider both directions for relates to candidates	6 years ago
Oliver Günther	9a7ff60976	Replace jquery-autocomplete in wp-relations-autocomplete	6 years ago
Oliver Günther	5e9e7f4e6c	Explicitly forward private to_ary ... Avoids the repeated warnings of the kind ``` /home/oliver/openproject/dev/lib/api/caching/cached_representer.rb:194: warning: delegator does not forward private method #to_ary /home/oliver/openproject/dev/lib/api/caching/cached_representer.rb:194: warning: delegator does not forward private method #to_ary /home/oliver/openproject/dev/lib/api/caching/cached_representer.rb:194: warning: delegator does not forward private method #to_ary /home/oliver/openproject/dev/lib/api/caching/cached_representer.rb:194: warning: delegator does not forward private method #to_ary ```	6 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs ... Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Oliver Günther	5dee711090	Use SetAttributeService	6 years ago
Oliver Günther	9d7837d472	Add description to type defaults	6 years ago
Oliver Günther	0791c55870	Remove the internal setting with 500 max entries ... Instead, use the maximum allowed page size for the maximum number. This will match what the users have selected and be reasonable without adding another user-visible setting. https://community.openproject.com/wp/30103	6 years ago
Oliver Günther	24b663948d	Avoid using gon for boards permissions	6 years ago
Jens Ulferts	a4d8b74287	eager load for readonly? check	6 years ago
Oliver Günther	5431f39f54	[29199] Correctly pass permission to identify new WP button ... https://community.openproject.com/wp/29199 [ci skip]	6 years ago
Oliver Günther	ae8db4011a	Fix more deprecations	6 years ago
Wieland Lindenthal	fd88776ceb	Add relations tables to Types via form configuration (#6773) ... * WIP: PrecedesFilter and FollowsFilter for WorkPackages * Create Type Form Groups per Query Type * generalize filters on relations avoiding alias * fix flickering spec * Rename dependency represeners for Follower and Predecessor Filters * Allow configuring templated queries within query configuring modal * Use `{id}` as templated value, instead of a now deprecated `templated` string * Rewrite ParentFilter to follow same structure as other relation filters. * Set Follower and Predecessor filters as hidden in Frontend * Default query shall show closed WPs, too * Remove relation filter type selection from form configuration view as we extend query configuration modal instead. * Allow ExternalQueryConfiguration to be more specific and prepend relation filters in its modal. * Quick unrelated fix on the way: the instruction text should start below the columns input and not to the right of it * - Add all missing relation filters. - Use verbs for naming instead of nouns to stay consistent with UI. * fix typo * Add relation filters to hidden filters and fix a rebase bug * Typo in docs * Fix broken rebase conflict resolution * Add part of and includes filter * adding specs for relation filters * rename RelatesFilter to RelatesToFilter * Rename shared example as direction does not matter anymore. * Fix spec for IncludesFilter * Fix name conflict for `includes` by calling typed_dag's `direct` later. * Fix shared filter examples as the parent filter does not get added per default anymore. * Fix spec after renaming PredecessorFilter to PrecedesFilter * Fix integration spec for type configuration form * Add filter dependency specs * Differentiate between WorkPackageFormChildrenQueryGroup and WorkPackageRelationQueryGroup types * Create inline-create for relation tables * Rewrite filters to use actual relation_type as key * Reload relations on change, change symbols * Fix relation filter i18n strings * Test presence of all relation filters frontend. * Extend integration test for form configuration to not only cover hierarchy, but also undirectional and directional relation types. * Consistent naming of filter dependency representer files * Satisfy codeclimate * Add missing copyright notes * Fixing PartofFilter and its specs * Reverse relation direction when created inline * WIP integration test for Relation Query Component and Children Query Component. * Correctly reload children tables when refreshed * Fix FilterOnUndirectedMixin * Fix removing of relation from embedded table after reload * Adding intergration tests for removing and adding relation or children, initiated form either embedded table or relations tab. * Fix specs * Fix implementation of duplicates and duplicated They are reversed in typed_dag and causes confusion [ci skip]	6 years ago
Jens Ulferts	6e022fadbe	fix/remove tests	6 years ago
Jens Ulferts	5bba60202e	use form resource to create new grid	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Oliver Günther	ccc74577e4	[28745] Do not allow inline create for children of milestones ... https://community.openproject.com/wp/28745	6 years ago
Jens Ulferts	08a7ee52b3	introduce time entry create endpoint in api v3 ... The endpoint allows creation of time entries with the fixed attributes project, activities, ... as well as with custom fields that might be configured for time entries. There is no endpoint for form and schema, yet which micht make it difficult for clients to figure out the correct parameters.	6 years ago
Wieland Lindenthal	fd271b2324	Use camel cased attribute name availableRelationCandidates` in `_links` instead of underscored version	6 years ago
Wieland Lindenthal	600e949880	Fix #28639. Use api_v3_path helpers for linking work package's available relation candidates	6 years ago
Jens Ulferts	58f6e9a172	eager load attachments to avoid n+1 query ... The attachments are needed for rendering the work package description where attached images are rendered inline	6 years ago
Jens Ulferts	66acc49818	eager load attachments to avoid n+1 query ... The attachments are needed for rendering the work package description where attached images are rendered inline	6 years ago
Oliver Günther	3a69c1a6d8	[28452] Avoid adding a CF multiple times to eager loaded WPs ... If there is a custom field that is for_all, and it occurs multiple times in the custom_fields_projects join table, it will be added multiple times to the work packages availabe CFs. https://community.openproject.com/wp/28452	6 years ago
Oliver Günther	aa9897561b	[28455] Ensure model contracts are initiaited immediately before saving	6 years ago
Oliver Günther	8438848838	[28435] Fix custom field with is_for_all eager loading ... When a custom field is `is_for_all`, and in the join table from custom fields to projects, there exist a value to project A (e.g., before the CF was marked is_for_all in the first place): Lookups to the work packages in Project B with eager loading will result in this custom field missing, because the `LEFT OUTER JOIN` in usages have already mapped it to Project A. https://community.openproject.com/wp/28435	6 years ago
Jens Ulferts	804d59c735	use correct subclass link for assignee and responsible	6 years ago
Jens Ulferts	c1853a5cdd	fix expected namespace for groups on assignee and responsible property	6 years ago
Oliver Günther	0b96d2876c	Cached avatar image	6 years ago
Jens Ulferts	7f740a8178	extend to posts and plugins	6 years ago
Oliver Günther	4823f8cfa5	PDF attachments embedding in table export	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Jens Ulferts	3b8a520ff2	avoid wrapping on wp payload ... Wrapping can interfere with a couple of method e.g. setting the errors	7 years ago
Markus Kahl	6126b4311a	added error handling in create too	7 years ago
Markus Kahl	f2919d3cb6	show dependent errors if work package update (PATCH) fails	7 years ago
ulferts	e1027189bb	eager load associated work packages of relations (#6315) ... [ci skip]	7 years ago
Jens Ulferts	26320fe614	eager load for relations	7 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list ... Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
ulferts	eefbb413e7	performant visible condition on relations query (#6290) ... [ci skip]	7 years ago
Jens Ulferts	ac59ad6a89	introduce group resource stub	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago