197 Commits (823cf17ad6aba08c22fa6c314ca93b453e018f0f)

Author	SHA1	Message	Date
ulferts	5edb64b2df	use default filter behaviour for wps available for relations ... That way, we can treat the end point as just another wp endpoint with filter capabilities. Currently, there is a couple of custom logic still present but that is only due to wanting to not break the public API. In the long run, the whole end point could be removed as the same filtering is now available using /api/v3/work_packages with an appropriate filter.	6 years ago
Oliver Günther	1280716663	[30106] Hide query groups when project filter reduced in valid subset ... https://community.openproject.com/wp/30106	6 years ago
Oliver Günther	bc06da3a00	[30231] Allow users edit_work_packages permission to save query ... https://community.openproject.com/wp/30231	6 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs ... Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Oliver Günther	111fc3a8af	[29873] Fix parsing of form query params in project context ... The query params passed to a form were parsed without a project context being present. If we parse them the other way around (payload first, upgrading query string later), the project context is set and e.g., project-context CF filters are present. https://community.openproject.com/wp/29873	6 years ago
Oliver Günther	8ab4f2a663	Boards module (#7008) ... * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Push boards on grid * Use base class in scope [ci skip] * Extend api for options * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Save queries in grids [ci skip] * Renaming queries [ci skip] * Add existing work packages to board [ci skip] * Introduce card view component for work packages * Extend grids to allow project scope for boards (#7025) Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards). For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented. * introduce project association for boards * have dedicated grid registration classes * update and create form for board grids * extract defaults into grid registration [ci skip] * Add drag and drop to card view [ci skip] * Add options to grid * Fix option migration name * Renaming boards [ci skip] * Frontend deletion of boards * Avoid map on NodeList which doesnt exist [ci skip] * Add inline create to boards [ci skip] * Smaller create button [ci skip] * Add navigation for boards * Make inner grid same height * Replace index page with table * Workaround for widget registration [ci skip] * Fixed height for cards and tables [ci skip] * Implement escape as cancel d&d action [ci skip] * Fix and extend grid specs for name and options * Extend board specs for required name * Fix migration for MySQL references https://stackoverflow.com/a/45825566/420614 * Make board list extend from widget Since we cannot configure widgets yet, it's not yet possible to use a board-list widget anywhere. * Fix specs * Fix escape listener removal [ci skip] * Fix renamed to_path in relation spec [ci skip] * Allow deletion of grids for boards * Avoid reloading resource multiple times with replays * Frontend synchronization on deletion [ci skip] * Delete through table * Use work packages board path * Use work packages board path * Fix augmented columns breaking re-rendering * Fix duplicated permission with forums * Strengthen tab switch in specs * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * private queries * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * Move boards below work packages * Add Board configuration modal * Fix reloading with onPush * Saving / Switching of display mode [ci skip] * Extract wp-query-selectable-title into common component * Fix renaming of board-list * Fix auto-hide notifications in boards * Add permissions to seeders * Reorder lists in board * Linting * Remove default gravatar from settings * Show assignees avatar in the card view of WPs * Fix specs * Add missing method * Fix timeline icon * Use URL as input to be able to show avatars for groups, too * Fix test * Add further specs * Use correct data attribute to avoid unnecessary data base calls * Add further specs * Deletion of board lists * Pass permission via gon to decide whether we can create boards * Fix rename spec * Cherry-pick of 7873d59 and 30abc7f	6 years ago
Oliver Günther	e9cc09840d	Add hidden flag for project-context queries ... Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context.	6 years ago
Wieland Lindenthal	ee1fc0b34b	Fix SearchFilter input to be text	6 years ago
Wieland Lindenthal	2a47d8f512	Refactor SearchFilter to combine other filters.	6 years ago
Wieland Lindenthal	fd88776ceb	Add relations tables to Types via form configuration (#6773) ... * WIP: PrecedesFilter and FollowsFilter for WorkPackages * Create Type Form Groups per Query Type * generalize filters on relations avoiding alias * fix flickering spec * Rename dependency represeners for Follower and Predecessor Filters * Allow configuring templated queries within query configuring modal * Use `{id}` as templated value, instead of a now deprecated `templated` string * Rewrite ParentFilter to follow same structure as other relation filters. * Set Follower and Predecessor filters as hidden in Frontend * Default query shall show closed WPs, too * Remove relation filter type selection from form configuration view as we extend query configuration modal instead. * Allow ExternalQueryConfiguration to be more specific and prepend relation filters in its modal. * Quick unrelated fix on the way: the instruction text should start below the columns input and not to the right of it * - Add all missing relation filters. - Use verbs for naming instead of nouns to stay consistent with UI. * fix typo * Add relation filters to hidden filters and fix a rebase bug * Typo in docs * Fix broken rebase conflict resolution * Add part of and includes filter * adding specs for relation filters * rename RelatesFilter to RelatesToFilter * Rename shared example as direction does not matter anymore. * Fix spec for IncludesFilter * Fix name conflict for `includes` by calling typed_dag's `direct` later. * Fix shared filter examples as the parent filter does not get added per default anymore. * Fix spec after renaming PredecessorFilter to PrecedesFilter * Fix integration spec for type configuration form * Add filter dependency specs * Differentiate between WorkPackageFormChildrenQueryGroup and WorkPackageRelationQueryGroup types * Create inline-create for relation tables * Rewrite filters to use actual relation_type as key * Reload relations on change, change symbols * Fix relation filter i18n strings * Test presence of all relation filters frontend. * Extend integration test for form configuration to not only cover hierarchy, but also undirectional and directional relation types. * Consistent naming of filter dependency representer files * Satisfy codeclimate * Add missing copyright notes * Fixing PartofFilter and its specs * Reverse relation direction when created inline * WIP integration test for Relation Query Component and Children Query Component. * Correctly reload children tables when refreshed * Fix FilterOnUndirectedMixin * Fix removing of relation from embedded table after reload * Adding intergration tests for removing and adding relation or children, initiated form either embedded table or relations tab. * Fix specs * Fix implementation of duplicates and duplicated They are reversed in typed_dag and causes confusion [ci skip]	6 years ago
Jens Ulferts	d887439016	linting	6 years ago
Oliver Günther	ad43a7ea95	Prepare for core integration	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Jens Ulferts	f9a8846271	rework hidden filters to avoid hacking	6 years ago
Jens Ulferts	dcbabcbaf3	invalidate cached cf filters on changes to cf	6 years ago
Wieland Lindenthal	0d3c109db7	Fix saving of queries with highlighted attributes. ... - Use column IDs instead of their href. - Fix validation. validates_inclusion_of was not doing the job as does not check for intersection - Extend parameter parsing for hightlighted_attributes - Extend contract	6 years ago
Oliver Günther	4eed7e68f3	Implement frontend part of partially selectable attributes	6 years ago
Oliver Günther	6541cbe073	Add highlightable column	6 years ago
Jens Ulferts	98ed6b521c	allow filtering by accountable group	6 years ago
Oliver Günther	f3e2100247	Save highlighting mode to query	6 years ago
Jens Ulferts	bc9aa302c9	let writability of query public attribute depend on permission	6 years ago
Jens Ulferts	319f33e924	remove textile	6 years ago
Jens Ulferts	2956d0b652	bust filter dependency cache on form_embedded changes	7 years ago
Oliver Günther	fbff2bf5fb	[27685] Allow to disable certain tabs of the embedded configuration modal (#6301) ... Also ensures that the hierarchy mode is always disabled for the embedded modal in the type configuration https://community.openproject.com/wp/27685 [ci skip]	7 years ago
Oliver Günther	ce64a30625	Add columns to query_params_representer, and allow different format ... depending on the target: - URL params: Rails automatically transforms arrays to `column[]=val1&column[]=val2" - JSON: Pass columns as `columns[]` so that frontend encodeUri will automatically pass multiple values for this key, resulting in the Rails query scheme.	7 years ago
Oliver Günther	d591e8ae4c	[27600] Add link to query_form to represent allowing new queries to be saved (#6293) ... When an existing query (and its form) is loaded, members with permissions to create new queries, but NOT to update existing ones can not save existing queries as new ones. This is due to the `create`, `update` and `commit` (on form) links are dependent on the query resource itself, not on general permissions of the queries project. https://community.openproject.com/wp/27600 [ci skip]	7 years ago
Jens Ulferts	77116b5cdb	ensure not to have user specific query cached in schema	7 years ago
Jens Ulferts	fa2b0fa1d9	clean up templated filter values	7 years ago
Jens Ulferts	14dd5c77f4	introduce a :context value for parent filter	7 years ago
ulferts	3881b47e26	add parent filter to wp query (#6235) ... [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Jens Ulferts	a1812699f0	validate actions	7 years ago
Oliver Günther	8fa78e4b5a	Fix more specs	7 years ago
Oliver Günther	7dc9df3aee	Adapt specs to factory pattern	7 years ago
Oliver Günther	941ed90b6a	Extract Custom Field mixin and subfilters ... Allows re-use of custom field filters in different contexts, with additional logic per custom field type (e.g., user with me values)	7 years ago
ulferts	d90513b968	hack availability of wp id filter (#6036) ... The id filter is currently implemented as a stub. It is usable from the wp api but using it via the query api and by that via the front end fails intentionally as we currenlty have no solution to display the potentiall filter values efficiently. As there could be thousands of possible values, this problem is quite hard. This hack circumvents the problem by not showing the filter in the query representer. The filter is applied but the user will not be informed of the existence of the filter or its values. As this is more of an easter egg, this is probably ok for now. [ci skip]	7 years ago
Markus Kahl	8f4139578a	available budgets depend on project	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897) ... * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again ... The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	75d2f010ba	[25108][26176] Assigned_to filter returns group values ... Since 7.0.0, the `assigned_to is <user>` filter also returns work packages assigned to a group that `<user>` belongs to. Since this is misleading and judged a bug by several customers, instead add a new filter that provides exactly this behavior, while using `assigned_to` only for the exact value specified there. https://community.openproject.com/wp/26176 https://community.openproject.com/wp/25108	7 years ago
Oliver Günther	ddcf35f3f7	Fix invalid value_objects being passed to representer ... There are queries that seem to pass values not available in APIv3 path helper to the instance representer. ``` Original error: #<NoMethodError: undefined method `anonymous_user' for API::V3::Utilities::PathHelper::ApiV3Path:Class Did you mean? anonymous?> Stacktrace: /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:82:in `block (2 levels) in <class:QueryFilterInstanceRepresenter>' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:80:in `block in <class:QueryFilterInstanceRepresenter>' ```	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable ... https://community.openproject.com/wp/25999	7 years ago
Oliver Günther	e02a65e372	[26141] Use valid subset of query to save it (#5859) ... https://community.openproject.com/wp/26141 [ci skip]	7 years ago
Oliver Günther	ece6fa5d23	[26128] Fix local jump error (#5856) ... [ci skip]	7 years ago
ulferts	0c1c8d443a	don't use project as cache key if project is nil (#5806) ... [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711) ... * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
Oliver Günther	aa386f994d	[25606] Saving query with nil group_by does not apply it (#5684) ... This was caused by the groupBy deserialization only applying when it is non-nil [ci skip]	7 years ago
Jens Ulferts	5982ede894	adapt to altered representable interface	7 years ago