61 Commits (83cdefaa55198319031f176576f84d9080e5742b)

Author	SHA1	Message	Date
Oliver Günther	9a3d822b35	[38842] Allow customized not found message ... https://community.openproject.org/wp/38842	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	0666c89828	Feature/35708 wp typeahead filter (#9426) ... * breakup wp resource specs into separate files * introduce and employ typeahead filter on work packages Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
ulferts	f8b28b300c	treat nil value as non false ... The default BooleanEquals filter treats null same as false. Because of that, notifications that are not meant for ian were displayed. The BooleanEqualsStrict filter only filters for false as expected so that the notifications are not displayed.	3 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973) ... * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987) ... AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	51e7f1f048	adapt specs to altered non writable message	5 years ago
ulferts	e003ad0af7	turn scope and label unwritable	5 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs ... Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	cbb0d90fde	Use Rack::Test in all request specs	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jan Sandbrink	5de0f15898	Correctly link activities ... - they might not be embedded - create an endpoint for activities - document it properly - adapt angular client	9 years ago
Jan Sandbrink	563cb3c5c7	migrate APIv3 to aggregated journals ... - turns out agrgegated journals needed more features - turns out specs were incomplete and bogus	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	7d443154b3	parse attachment metadata using a representer ... - adding general error handling for parse errors - changing the default error message for parse errors, which was very form specific before	10 years ago
Jan Sandbrink	819468ccba	fix specs to respect new error identifier	10 years ago
Markus Kahl	5a0f4606cc	updated error code expectation	10 years ago
Jan Sandbrink	900b2a4c45	Backporting APIv3 categories to OP 4.0 ... Backport was neccessary to implement missing categories filter without adding more technical debt. These changes will be merged into 4.1 and following branches and vanish in that merge (merge-strategy "ours") YOU SHOULD NOT SEE ANY CONTENTS FROM THIS COMMIT ANYWHERE AFTER 4.0.x! This commit was built from the commits of the GitHub-PR mentioned below, as well as some code dependencies for that. The GitHub-PR was https://github.com/opf/openproject/pull/2505	10 years ago
Jan Sandbrink	0f69e73421	expect a good Content-Type for all errors	10 years ago
Jan Sandbrink	e1948206fa	extract method into ResourceLinkParser ... - similar code was already used in two different places - now the error message makes sense for both occurences	10 years ago
Jan Sandbrink	3b45954314	HTTP 415 is even more apropriate than HTTP 400	10 years ago
Alexander Bach	92e23145d4	Some easy style fixes	10 years ago
Alexander Bach	409073f7e3	Generalized 404 error message	10 years ago
Alexander Bach	21c50fd41a	Accessing a project without permission now returns 404 instead of 403	10 years ago
Jan Sandbrink	7a74738ae6	add missing integration tests	10 years ago
Jens Ulferts	a3839a19c2	avoid explicit ids in spec	10 years ago
Jens Ulferts	9893070368	removes explicit id from spec	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	d063be30f6	Adapt spec to formattable activity comment	10 years ago
Hagen Schink	1aa6c806e3	Test localized error messages in API V3	10 years ago
Hagen Schink	8922eb3040	Test API V3 WP form response on invalid JSON	10 years ago
Hagen Schink	570456eb9e	Test that API V3 textile detects wrong content type	10 years ago
Hagen Schink	a482205aec	Test that collections adhere to the specifiction	10 years ago
Jens Ulferts	0220c67cc0	improves code understandability	10 years ago
Jens Ulferts	8bd9f7a889	employs mocking of Setting	10 years ago
Hagen Schink	99094c1d77	Test API V3's textile render endpoint	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	d6430d7f02	Test that stale object error results in a 409	10 years ago
Hagen Schink	2a59258572	Correct typo	10 years ago
Hagen Schink	101a890250	Test error message includes punctuation	10 years ago
Hagen Schink	fdcb0d9017	Test error message for multiple validation errors	10 years ago
Hagen Schink	48310129a6	Apply code conventions	10 years ago
Hagen Schink	06f624db0d	Add tests for multiple validation errors ... This is not yet implemented for reasons stated in the TODO.	10 years ago
Hagen Schink	856d093814	Test read-only error details	10 years ago