1092 Commits (896ddc32adac7d72d77f2e08654f678e74b0d490)

Author	SHA1	Message	Date
Alexander Bach	a8e1aadec7	replace changed_data by details ... working towards making the alias obsolete...	9 years ago
Jan Sandbrink	ca03e6543a	fix specs	9 years ago
Oliver Günther	0610280e6f	Cleanup	9 years ago
Oliver Günther	c16c1e75d4	Extend SysController to allow WS to check / update storage	9 years ago
Jan Sandbrink	6c1e4dbf4f	send aggregated notifications ... - only sending the last mail of an aggregation chain - displaying the aggregated state of the change - replaces old classes for mail notifications - old special error handling for missing users is obsoleted, since recipients are determined at jobs runtime - special cases for missing author and journal are considered	9 years ago
Oliver Günther	9336cff8bb	Extended specs ... This commit adds / extends the following specs: RepositoriesController: Ensure empty repository page is shown for empty repositories adapters/subversion: Test correct use of --login, --password arguments	9 years ago
Oliver Günther	caf5e4a706	Formatting and clean up	9 years ago
Oliver Günther	c5b200d7a0	Review corrections ... - Remove repositories paths using project.id instead of `project_id` - Allow managed repositories to be unlinked in the instance (But doesn't remove repository directory). - Remove leftover settings partial	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Jens Ulferts	8133b1a488	i18n agnostic spec	9 years ago
Alex Coles	d052f189d5	Prefer #map over #collect ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	a66f166498	Normalise syntax with Rubocop ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	22502bb008	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ccb4268793	Normalise syntax with Rubocop ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16fb352d8d	Use 1.9+ Hash syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	138d3dba29	fix some specs ... - error messages now contain punctuation - when :save returns false, there should be errors present - errors in form representers are now API errors	9 years ago
peter	6a7ab0edb8	fix invalid response for /api/v2/authentication.json	9 years ago
Alex Coles	1d1d56217d	Without message chain, prefer #receive in spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	985a15f08a	Remove obsolete TODO in VersionsController spec ... [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8338b7a6e1	Update OP::Authentication to use uppercase headers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	69aaa74e5f	Update OP::Authentication to use uppercase headers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	9 years ago
Alex Coles	81de05e5fe	Remove deprecated Relation#all in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2d9cfd97f4	Remove deprecated Relation#all in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	c24c58a273	fixed specs; use default realm; test custom realm	9 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	9 years ago
kgalli	d1b82564af	Refactoring: increase readability	9 years ago
Jonas Heinrich	9db7d41311	Makes the notification to an error	9 years ago
Jonas Heinrich	8f7907b6f7	Catches error while sending notifications	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	424889897a	Migrate AR finder/query methods in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	9eb7cfbe9b	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	9 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Jan Sandbrink	d59b54a63c	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	10 years ago
Jens Ulferts	9b93316283	explicitly expecting a setting	10 years ago
Alex Coles	11bc0ac2cb	Update VersionsController#update spec to use PATCH ... See core commit: 077e42ba06 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1c7f61b943	Remove option passed to render_template matcher ... Analog to core commit: 1bb21b23c7 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e480aae38d	Split CostTypesController#toggle_delete method ... Split into separate #destroy, #restore methods. * Add skeleton CostTypesController spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	077e42ba06	Make VersionsController#update use PATCH ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2640852fe3	Fix MembersController#autocomplete_for_member routing ... * make routing less convoluted (as in 18835799). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5841ae9e41	Fix MyController spec broken in 0a0f6c7b ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	18835799dd	Make ProjectsController#types use PATCH ... * make routing less convoluted: switch to a regular member route. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	516c9a5f3e	move mock method out of production code	10 years ago
Jan Sandbrink	bc3437c3b0	replace create_uploaded_file in specs ... mock_uploaded_file creates a Rack::Test::UploadedFile, which should behave equally to a real uploaded file, but is also treated correctly by Rack::Test	10 years ago
Alex Coles	e6cf754b53	Fix CopyProjectsController spec broken in 0c56b72d ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	d060e654a5	Use vanilla Rails validations for CustomField#name ... Globalize should support regular Rails validations. Additionally `validate_name` was no longer working as expected, possibly due to changes in `CustomField::Translation` lifecycle. * Do not test translation implementation details in CustomFieldController spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago