9 Commits (8a0700a29b2fab708a15a8cf077fc264fe4ce226)

Author	SHA1	Message	Date
ulferts	d1f419385f	Feature/member custom notifications (#9173) ... * include custom message in membership forms * keep pristine params to be able to pass it to the state * fix indentation on projects api docs * pass grape instance around in default endpoints The grape instance has readily available access to all the objects (params, current_user) so less individual parameters need to be passed. This also avoids having to store the grape endpoint in a potentials not thread safe variable * send custom message out on membership creation * send custom message on membership update * send custom message even if setting disabled * restore params interface * add custom message description to schema * describe notificationMessage in the api documentation * extract meta payload functionality into mixin * ensure password in spec meets requirements * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043) ... Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	b8ca382d34	Group API (#9034) ... * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867)	4 years ago
ulferts	7b31311713	Chore/rename timestamp on time entry (#8754) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on	4 years ago
ulferts	f28013f332	allow adding members to invalid groups ... If a group is invalid (e.g. because it has a required custom field) it should still be possible to add members to that group. Therefore, the contract no longer checks the model itself but only the user performing the operation.	4 years ago
Oliver Günther	2878a57460	Add integration spec for AddUsersService	5 years ago