217 Commits (8aedcee01b8f0cecf50766287f0c970b16ba8bae)

Author	SHA1	Message	Date
Markus Kahl	15e920892e	added missing custom option lookup during creation (#6198) ... [ci skip]	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Markus Kahl	a89ed0b0eb	make sure there are no duplicate parameters	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533) ... * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
ulferts	4b7e3ff26d	Feature/limit attribute help text visibility (#5749) ... * code prettification * avoid help text for newly added cf requiring restart When using the class method statically, the values are determined upon reading the class. By that, a restart is required before newly added custom fields are added to the list and removed custom fields will still be listed * limit visibility of attribute help texts [ci skip]	7 years ago
Markus Kahl	e3e7878b89	follow robustness principle and allow custom option values	7 years ago
Jens Ulferts	1fe880ad1b	prevent query filters loosing their context	8 years ago
Oliver Günther	93dcd386f4	Remove usage of CF translations	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	b129f14079	replace removed method AR method #type_cast_from_database	8 years ago
Jens Ulferts	d106fcf226	don't raise if disable_api has never been defined	8 years ago
Oliver Günther	06af06c083	Remove skip_before_action that does not exist in an V2 controller	8 years ago
Oliver Günther	fe0e8dd919	Rename before_filter to before_action	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Jens Ulferts	9ee2e8057c	eager load color	8 years ago
Oliver Günther	1f75bd22b0	Use XML parser middleware	9 years ago
Oliver Günther	3cbc4e71b8	Disable CSRF for add-in ... The TaskConnector add-in doesn't handle CSRF tokens.	9 years ago
Alex Coles	07551ae585	Switch to new AR API for boolean typecasting ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	21d3af35b1	Set allowed mime types to respond_to ... This sets the allowed response types to be used with `respond_with`. Note that this will again need to be moved with 4.2 http://guides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to	9 years ago
Oliver Günther	5129f05678	Fix NameError for Pagination	9 years ago
Alex Coles	f320305531	Revert "Temp. comment includes in API v2 ProjectController" ... `FriendlyId::Finders` should ensure an identifier-aware `find` on an `ActiveRecord::Relation` chain. This reverts commit 51512f1522.	9 years ago
Alex Coles	347f363026	Remove unloadable from controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
peter	6a7ab0edb8	fix invalid response for /api/v2/authentication.json	9 years ago
Alex Coles	0ad3cfb4b2	Prefer do…end for controller respond_to blocks ... `rubocop -a` does not currently normalise formatting consistently (see ec1bb39f). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	75cecdb21a	Omit extraneous [] in APIv2 CustomFieldsController ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2d9cfd97f4	Remove deprecated Relation#all in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	51512f1522	Temp. comment includes in API v2 ProjectController ... `includes().find` appears to have issues with polymorphic associations in Rails 4.0.x. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e02eb0181d	Migrate AR finder/query methods in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a464c01203	Force bool coercion in API v2 WorkflowsController ... Boolean values are not properly coerced when using `.select` with custom SQL String on PostgreSQL. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	3629ded2ae	Handle ActionController::ParameterMissing globally ... See 6d11fac2. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6d11fac2f8	Handle ActionController::ParameterMissing in APIv2 ... This is a behaviour difference with the strong_parameters plugin for Rails 3.2, which does this by default. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	8a28b1a730	Prefer #map over #collect in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	bb0e6e6aa5	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	336446c59d	Use 1.9+ Hash syntax in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0604de3d8b	Fully qualify ::Type class constant ... See 0b941955. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	d7486ab811	allows api v2 types controller accessible for :view_work_packages permission	10 years ago
Jens Ulferts	61c05affd4	checks for permission before api/v2/types#index	10 years ago
Jens Ulferts	077e0b2f78	types controller is admin only now	10 years ago
Alex Coles	0b941955ce	Fully qualify ::Type class constant ... This fixes a naming collision with AR internals: undefined method `find' for ActiveRecord::AttributeMethods::Serialization::Type:Class Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	7ff6f4fe94	Fully qualify parent class in API v2 Controllers ... This fixes the following issue: Circular dependency detected while autoloading constant Api::V2::ProjectsController Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Michael Frister	f88443714e	API v2: Document some useless code	10 years ago
Michael Frister	8d08e71ed5	API v2: Change boolean value to use true/false ... While this is not the OpenProject API, we use true/false for other APIs and for other parameters in the application, like `layout=false`. true/false also seems more intuitive.	10 years ago
Jens Ulferts	befb9f054e	removes unnecessary visibility filter on Version scope ... Authorization is handled an project level here and thus does not need to be done for the version itself. Authorising on the Version in addition has the drawback to only return versions in projects which the user can see work packages in. It does not take into account that the version can be shared.	10 years ago
Jens Ulferts	2f8920f3c7	minor code improvements	10 years ago