66 Commits (8aedcee01b8f0cecf50766287f0c970b16ba8bae)

Author	SHA1	Message	Date
ulferts	a28ec25957	Fix/parent sorting missing elements (#6118) ... * Revert "remove unused sortable join (#6099)" This reverts commit c1be19a6da. * prevent descendant wps to not be present in filter result on parent sort On sorting by parent, we need to join the query with a subselect that returns only the topmost hierarchy relation (i.e. the relation that has the highest hierarchy value) per work package. Otherwise, if more than one row is returned per wp for the subquery, the work package is also counted multiple times against the provided limit which leads to less work packages being returned than expected. [ci skip]	7 years ago
ulferts	c1be19a6da	remove unused sortable join (#6099) ... [ci skip]	7 years ago
ulferts	7d30fcbc8e	allow AR to alias on distinct (#6106) ... When passing a string to #order AR has no chance to alias columns. This can clash when two columns from different tables having the same name are part of the query (e.g. id). By providing an array, AR applies aliases to columns it needs to have in the projection on SELECT DISTINCT ... ORDER BY statements. [ci skip]	7 years ago
Oliver Günther	0d55bc0308	[26675] Remove implicit ID sorting on parent sort (#6039) ... * [26675] Remove implicit ID sorting on parent sort https://community.openproject.com/wp/26675 * parent sort -> breadth first sort, top down [ci skip]	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag ... Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable ... https://community.openproject.com/wp/25999	7 years ago
ulferts	c70aa76ea0	mimic AR join alias calculation for query (#5682) ... * mimic AR join alias calculation for query * remove unused columns parameter on v3 query get [ci skip]	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637) ... * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
ulferts	ace7098eb3	add relations columns to query (#5606) ... * add relations columns to query * refactory query columns * rename QueryColumn to QueryColumn::Property QueryColumn is now only an abstract supertype [ci skip]	8 years ago
Oliver Günther	6b372acae6	Implement timeline zoom level as query enum	8 years ago
Jens Ulferts	4df369884a	employ the subproject filter to handle subproject setting	8 years ago
Jens Ulferts	1fe880ad1b	prevent query filters loosing their context	8 years ago
Jens Ulferts	8a08856748	replace string object by custom option for list custom fields	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	780906a051	prevent WorkPackage#visible to result in duplicate entries for pluck ... If Project.allowed_to is joined to WorkPackage, the result set will have as many entries, as the user has roles (with the queried for permission) in a given project. Normally, this is not a problem as rails prevents instantiating duplicate WorkPackages on a single call. But when we only pluck, then, in combination with limit, we will end up with too few results as we get duplicate rows and only take the first x once.	8 years ago
Jens Ulferts	a5a13cf8d7	remove problematic distinct	8 years ago
Jens Ulferts	3246747ae0	adapt to newly introduced query	8 years ago
Jens Ulferts	209169c6f8	start summing up only on summable columns	8 years ago
Oliver Günther	a8a5ff5d16	[23189] Reference statuses and projects in empty grouping (#4466) ... The group_by query for a result of only empty work packages resulted in an invalid statement. ``` Query::StatementInvalid: PG::UndefinedTable: ERROR: missing FROM-clause entry for table "statuses" LINE 1: SELECT COUNT(*) FROM "work_packages" WHERE ((statuses.is_clo... ```	9 years ago
Jens Ulferts	81bb6c6e5c	remove instance variable caching ... Caching is no longer usefull here as the AR::Scope is cached but not the results of that scope. It was usefull when the queries for work packages where cached.	9 years ago
Alex Coles	db078e0964	Fix for ActiveRecord::Base.reflections API change ... `WorkPackage.reflections.keys` now returns Strings rather than symbols. This solution is not ideal: calling `to_sym` is often a code smell. It might be acceptable to pass through Strings to `includes`, but this warrants further discussion. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	8870838ce9	Ensure compatibility of sum-functions with Array callers ... this is neccessary to allow building sums for grouped results. The long-term goal should be to also move the grouping to the SQL side. Currently grouping will make a query very slow ("normal" with respect to its prior performance, but "slow" with respect to the performance of the grouping-free sum implementation).	9 years ago
Jan Sandbrink	02e7b9f5a8	Move summing of column values into QueryColumn ... - letting a column indicate whether it is summable (avoiding errors when trying to sum the "subject" or other silly things) - summing normal QueryColumns SQL side - doing SQL side filtering for CF-columns to improve performance for sparsely filled custom fields Possible improvements: - fully computing custom field sums SQL side (for dense custom fields) - only using a single query for all summed columns, instead of one SQL query per column	9 years ago
Jan Sandbrink	ef9cc87338	Always cache work_packages of Query::Results ... replacing the already cached :all_work_packages by the usual :work_packages	9 years ago
Jan Sandbrink	4803cba41c	implement grouping	9 years ago
Jan Sandbrink	2a65240e52	always include relevant columns ... - caller does not need to do it anymore - caller is still allowed to do it, because it can also add own conditions...	9 years ago
Jan Sandbrink	986be45dde	allow to calculate property sums	9 years ago
Jan Sandbrink	1c2aabbc45	allow sorting of WP lists	9 years ago
Alex Coles	787a35c9db	Add explicit join references in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	624b50d5bb	Remove deprecated Relation#all in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Jens Ulferts	9e91538a53	extract method refactoring	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0604de3d8b	Fully qualify ::Type class constant ... See 0b941955. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Richard	4b4939a9a1	WIP. Fixed failing work packages controller specs.	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Richard	7463bdf450	Passing group sums data along with index json.	11 years ago
Sebastian Schuster	4a3d34e397	Fixed 500 when displaying sums	11 years ago
Till Breuer	20039208e5	Add queries module again ... The module references breaks inside the calendars controller scope otherwise	11 years ago
Till Breuer	43e2d41e1c	Validate query filters of type date and date past	11 years ago
Till Breuer	09aa962907	Bypass query filter value validations if operator does not require values	11 years ago
Till Breuer	2dbf01dd6a	Stringify keys of serialized filter hashes ... This ensures backwards code compatibility. Can be reverted for aesthetic reasons later on.	11 years ago
Till Breuer	5bc3959dad	Move filter types by fields concerning work packages to corresponding filter subclass	11 years ago
Till Breuer	cfb5e1a58b	Move query filter-related code to models/query because it existed first	11 years ago
Till Breuer	4c04a6c8dd	Rename query#available_filters	11 years ago
Hagen Schink	ca36cbb311	Renames query column attribute 'alias' to 'join'	11 years ago
Hagen Schink	d9b370800b	Handles missing group by column	11 years ago