40 Commits (8c4cfdefa0147cf6dc1280e9e63450603ef67545)

Author	SHA1	Message	Date
Mohamed Wael Khobalatte	6f1d668c39	Fix issue with versions/new being not accessible	9 years ago
Mohamed Wael Khobalatte	626779d92d	Use assert_select instead of deprecated assert_tag	9 years ago
Stefan Botzenhart	1c01b5801e	Use login_as helper method throughout all specs	9 years ago
Oliver Günther	471fc04663	Fix ActionController::InvalidCrossOriginRequest in specs ... https://github.com/rails/rails/pull/13345 introduced CSRF protection to gets with JavaScript responses.	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	077e42ba06	Make VersionsController#update use PATCH ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e49a3c0deb	Update HTML attr order in VersionsController spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	fda43ac304	Replace VersionsController#create RJS with jQuery ... Matches `CategoriesController#create` implementation: see 4cc9aaf8. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	07d4ea4edd	Fix version select style on wp form inline create ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	8f34831777	Adapt VersionsController spec for actual template ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5309023428	Use idiomatic matchers in VersionsController spec	10 years ago
Alex Coles	43bba513df	Update HTML attr order in VersionsController spec	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	879fcd49f6	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Johannes Wollert	1d3e81fb25	check for the absence of a successful XSS-attack rather than the means to avoid it	10 years ago
Johannes Wollert	85d1315343	care less about all the html generated by the version controller, just look for the important stuff	10 years ago
Sebastian Schuster	d13ccc572e	Fixes on the fly version creation	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	d30ce48539	Begin replacement of server-rendered context menu ... Removes WorksPackages::ContextMenusController, its views and specs, and ContextMenuHelpers. This patch begins the work needed to serialise a given WorkPackage's 'actions' in the v3 API response, based on a user's permissions. This should support a client-rendered context menu (or any other contextual UI for that matter). Much code was simply copy-and-pasted from ContextMenusController into Api::V3::WorkPackagesController. This code still requires considerable refactoring and optimisation. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { |example| example } * 1 conversion from: pending to: skip	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Sebastian Schuster	2500e1ea01	Fixes on the fly version creation	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Jens Ulferts	8174632f5e	allows to redirect to a back url on version#update	11 years ago
Jens Ulferts	adb62846a4	replaces rjs and inline js with unobstrusive js	11 years ago
Hagen Schink	75ba27d23f	Fixes specs	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Jens Ulferts	a57179978d	avoids leaving User.current set after spec	11 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice ... This was done using the rake task: rake copyright:update	12 years ago
Christian Ratz	c2c19ac1d5	moved versions controller test to specs ... - added spec for opf # 528	12 years ago