openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	28127eb8ed	remove unnecessary model initialization	8 years ago
Jens Ulferts	b3a21283c7	replace the rendering of a hash by a specific WorkPackageSumRepresenter That way, the sums follow the general implementation schema and plugins are able to customize displaying the sums.	8 years ago
ulferts	9a6d5585f4	preload permissions before collection rendering (#4646 )	8 years ago
Oliver Günther	78dc9548f3	[Bugfix] Work package grouping header (#4360 ) * Refactor how table grouping is applied and refreshed Currently, changes to groupBy causes the work package to be immediately refreshed before the actual groups are collected from the backend. This watch has been removed, since its unneeded. The work package table is now tracked by the row id and the current group, which causes the ng-repeat to re-evaluate when the group changes, thus fixing the group header bug. Additionally, we now carry the groupByColumn in the wpTableService, where the other grouping values are derived as well. * Allow nil aggregation group This should fix https://community.openproject.com/work_packages/22816/activity * Hide empty group header when groupName not defined This avoids showing an empty header for inline create row. Also forces the create button to disappear when the table is explictly refreshed (e.g., when grouping on another attribute).	9 years ago
Markus Kahl	50e40f324a	wp form config polish (#4364 ) * allow hiding fields with defaults; consider name_source * sort types by name; move projects config to bottom * updated translations (default => active) * no extra visibility behaviour for new WPs * allow hiding even type; always show details header though otherwise the 'show all attributes' button may vanish * updated specs to include new info	9 years ago
Markus Kahl	5f9579ec1a	put visibility info into wp schema and use that	9 years ago
Markus Kahl	148a3fff14	work package form configuration	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290 ) * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago
Oliver Günther	62e2d776d5	Avoid RuntimeError when aggregating with nil representers (#4321 ) When aggregating columns, e.g., a custom field that contains nil values, the AggregationGroup receives an empty represented. This commit fixes that by allowing the represented object to be nil ``` RuntimeError (no represented object passed): lib/api/decorators/single.rb:54:in `initialize' lib/api/decorators/aggregation_group.rb:39:in `initialize' lib/api/v3/work_packages/work_package_list_helpers.rb:138:in `new' lib/api/v3/work_packages/work_package_list_helpers.rb:138:in `block in generate_groups' lib/api/v3/work_packages/work_package_list_helpers.rb:132:in `each' lib/api/v3/work_packages/work_package_list_helpers.rb:132:in `map' lib/api/v3/work_packages/work_package_list_helpers.rb:132:in `generate_groups' lib/api/v3/work_packages/work_package_list_helpers.rb:127:in `apply_and_generate_groups' lib/api/v3/work_packages/work_package_list_helpers.rb:42:in `work_packages_by_params' lib/api/v3/work_packages/work_packages_by_project_api.rb:42:in `block (2 levels) in <class:WorkPackagesByProjectAPI>' app/middleware/params_parser_with_exclusion.rb:38:in `call' ```	9 years ago
Jens Ulferts	ff3d42fa33	add a project independent endpoint to create work packages Includes the auxillary end points: * form * schema * available_projects	9 years ago
Jens Ulferts	f2eb288e7c	completely fix showing sums	9 years ago
Jens Ulferts	d060d251bf	eager load in decorator Eager loads the represented work packages based on a class variable. This might look like it would break encapsulation at first and it does. When it comes to eager loading one has to break encapsulation at some point. At least this way, we are very near to what we are going to represent and thus know which models we need. Additionally, this enables plugins to register for being eager loaded	9 years ago
Jens Ulferts	2cb05bfc27	remove no longer necessary scope alteration	9 years ago
Jens Ulferts	0267938c36	introduce spent_time model	9 years ago
Jens Ulferts	27e2cce32b	add priority to list of attributes inherited from children	9 years ago
Jan Sandbrink	58aa36ae2a	Check for nil representers explicitly Passing nil as model into a representer happens usually only due to an error. If a subclass needs to be able to pass nil as represented, it can specify that by overrding. This however, should be an exception, not the rule.	9 years ago
Jan Sandbrink	88ed4d2df9	Promote ::create to a common interface method This one is already used by the representers that require a custom field injector. However, by having a separate method this also means collections (or the new DecoratorFactory) need to take care and call the ::create method instead of ::new. I therefore made create the default interface to create representers, which is now used by Factories and Collections. Note: I did not yet change all representer instantiations to ::create. I hope this will happen gradually.	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	14a55b82d1	Do not embed linked resources in WP collections	9 years ago
Jan Sandbrink	d8ec635e9e	simplify interface for assignable values - one method to rule them all - eases overriding -> does not require to define method for new types on base class - allows to infer values_callback from property name (schema representer)	9 years ago
Jan Sandbrink	9e8d051027	reintroduce form_embedded argument for schema we can't live without it :/	9 years ago
Jan Sandbrink	637fadf602	add endpoint to list work package columns in a project	9 years ago
Jan Sandbrink	d5fe64bd5e	move writability decision into WP schema - reducing the method count (aka interface size) of the schema - giving it more control - still allow outside override in representer (for plugin compatibility)	9 years ago
Jan Sandbrink	602d488c66	fix reference to value links	9 years ago
Jan Sandbrink	2ddcd55b71	extract groups into own representer	9 years ago
Jan Sandbrink	ee03c7df82	allow filtering using JSON from query representer	9 years ago
Jan Sandbrink	e7abc0e3d5	first version of a paginated collection - common base class with UnpaginatedCollection - one implementor	9 years ago
Jan Sandbrink	b332ef06aa	make collection representer explicitly unpaginated	9 years ago
Jan Sandbrink	563cb3c5c7	migrate APIv3 to aggregated journals - turns out agrgegated journals needed more features - turns out specs were incomplete and bogus	9 years ago
Jan Sandbrink	1ac80edc3c	use common name conversion in linked properties some day we could do that for ALL properties...	9 years ago
Alexander Bach	870518f217	Unified permission checks	10 years ago
Alexander Bach	e73609c3ae	Unified permission checks	10 years ago
Jan Sandbrink	9cc0806024	extract parsable link into own representer	10 years ago
Jan Sandbrink	cde374a6d5	rework attachments endpoint according to spec - drop useless properties - add essential properties - for now limit to work packages only	10 years ago
Jan Sandbrink	900b2a4c45	Backporting APIv3 categories to OP 4.0 Backport was neccessary to implement missing categories filter without adding more technical debt. These changes will be merged into 4.1 and following branches and vanish in that merge (merge-strategy "ours") YOU SHOULD NOT SEE ANY CONTENTS FROM THIS COMMIT ANYWHERE AFTER 4.0.x! This commit was built from the commits of the GitHub-PR mentioned below, as well as some code dependencies for that. The GitHub-PR was https://github.com/opf/openproject/pull/2505	10 years ago
Jan Sandbrink	4d6a991468	allow to omit title by setting it to nil	10 years ago
Jan Sandbrink	6182f67925	make getting a link value more flexible	10 years ago
Jan Sandbrink	7e9d310d4f	allow to hide title in self links	10 years ago
Jan Sandbrink	b1ba33c75b	specify classes explicitly rather than implicitly This is a new try for the APIv3 classes, we either: - FULLY qualify a class and let the autoloader do the rest - don't qualify at all, but require the class explicitly Thus we do not (yet) completely give up on the rails autoloader, but we circumvent a fair amount of its magic (and problems). The hope is to eliminate the following problems in development mode: - NameErrors because the autoloader infers the wrong prefix - "object is not missing constant" errors occuring more rarely Let's see how that turns out to work...	10 years ago
Jan Sandbrink	c24ff68ab8	two fixes for the linked_property helper - also hide embedded objects when show_if is false - camelize links correctly	10 years ago
Jan Sandbrink	95352fdf2a	allow to hide all kinds of schema	10 years ago
Jan Sandbrink	2bbcaf3fd6	make _type in schema indicate the schemas type instead of indicating that the described resource has something called "_type"	10 years ago
Jan Sandbrink	46516f2699	style	10 years ago
Jan Sandbrink	24674b5092	allow passing of callables to writable + required	10 years ago
Jan Sandbrink	857bcf4636	some refactoring around the WP schema - schema does not decide anymore whether to include allowed values (solely decided by "form_embedded" of representer) - schema will answer as many "assignable_*" methods as possible - work package does not need those methods anymore (except few cases)	10 years ago
Jan Sandbrink	f0197b4323	style	10 years ago
Jan Sandbrink	3fc5770fc0	make embedding of linked properties more concise	10 years ago
Jan Sandbrink	9c4c6846a3	allow to hide schema properties	10 years ago
Jan Sandbrink	f42f8c4305	evaluate localization of schema names per call - allows real localization instead of one-time localization at startup - either request a callback for a name or a symbol passable to human_attribute_name	10 years ago

1 2

95 Commits (8eab60380e4dae3f220873bfb8b823235bb5f3f5)