openproject

Commit Graph

Author	SHA1	Message	Date
Markus Kahl	6126b4311a	added error handling in create too	7 years ago
Markus Kahl	f2919d3cb6	show dependent errors if work package update (PATCH) fails	7 years ago
ulferts	e1027189bb	eager load associated work packages of relations (#6315 ) [ci skip]	7 years ago
Oliver Günther	d591e8ae4c	[27600] Add link to query_form to represent allowing new queries to be saved (#6293 ) When an existing query (and its form) is loaded, members with permissions to create new queries, but NOT to update existing ones can not save existing queries as new ones. This is due to the `create`, `update` and `commit` (on form) links are dependent on the query resource itself, not on general permissions of the queries project. https://community.openproject.com/wp/27600 [ci skip]	7 years ago
ulferts	eefbb413e7	performant visible condition on relations query (#6290 ) [ci skip]	7 years ago
ulferts	c88b0b85c4	return proper WWW Authenticate header on missing credentials (#6150 ) An anonymous_fallback is introduced and registered to be the last strategy for warden. That strategy will always apply and it will always return the anonymous user. The better way would be to only apply the strategy if login is not required. That way we would still be able to return a 403 when credentials are missing but would no longer need to have 401 handlers outside of warden. That duplicity caused the missing header in the first place. It would however require us to handle the realm in the strategy and by that increase the coupling between the strategy and the application. [ci skip]	7 years ago
ulferts	58991c2b40	Fix/add missing types link to project representer (#6128 ) * add missing types link to project representer * fix rubocop violations [ci skip]	7 years ago
ulferts	83e605e63c	allow setting parent that has relation via new siblings (#6114 ) [ci skip]	7 years ago
Oliver Günther	e7de9169f1	Add internal error with message to Fog uploading failures [ci skip]	7 years ago
Oliver Günther	8fa78e4b5a	Fix more specs	7 years ago
Oliver Günther	7dc9df3aee	Adapt specs to factory pattern	7 years ago
Oliver Günther	941ed90b6a	Extract Custom Field mixin and subfilters Allows re-use of custom field filters in different contexts, with additional logic per custom field type (e.g., user with me values)	7 years ago
Oliver Günther	d6e949faf5	[26750] User perPageOptions in configuration representer (#6085 ) https://community.openproject.com/wp/26750 [ci skip]	7 years ago
Jens Ulferts	2db1a27ab9	use first nonempty error on relations api	7 years ago
ulferts	d90513b968	hack availability of wp id filter (#6036 ) The id filter is currently implemented as a stub. It is usable from the wp api but using it via the query api and by that via the front end fails intentionally as we currenlty have no solution to display the potentiall filter values efficiently. As there could be thousands of possible values, this problem is quite hard. This hack circumvents the problem by not showing the filter in the query representer. The filter is applied but the user will not be informed of the existence of the filter or its values. As this is more of an easter egg, this is probably ok for now. [ci skip]	7 years ago
Jens Ulferts	8842558aac	refactor for code quality	7 years ago
Oliver Günther	376fa46d4b	[26691] Avoid find(ids) in eager loader The `WorkPackageCollectionEagerLoading` uses eager loading for eager loading CF values that MAY not exist anymore. This results in a faulty query when hitting one of these entries. ``` E, [2017-11-29T17:25:21.847832 #14241] ERROR -- : Grape rescuing from error: API::Errors::NotFound Original error: #<ActiveRecord::RecordNotFound: Couldn't find Version with 'id'=35> Stacktrace: /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:353:in `raise_record_not_found_exception!' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:479:in `find_one' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:458:in `find_with_ids' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/finder_methods.rb:66:in `find' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/querying.rb:3:in `find' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/core.rb:151:in `find' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:228:in `eager_load_custom_values' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:216:in `eager_load_version_custom_values' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:197:in `full_work_packages' /opt/openproject/lib/api/v3/work_packages/work_package_collection_representer.rb:72:in `initialize' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:125:in `new' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:125:in `collection_representer' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:57:in `results_to_representer' /opt/openproject/app/services/api/v3/work_package_collection_from_query_service.rb:46:in `call' /opt/openproject/lib/api/v3/queries/helpers/query_representer_response.rb:37:in `query_representer_response' /opt/openproject/lib/api/v3/queries/queries_api.rb:91:in `block (3 levels) in <class:QueriesAPI>' ``` https://community.openproject.com/wp/26691	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Jens Ulferts	047e972653	speedup relation candidates api	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Oliver Günther	ac389b869d	Fix other request specs by adding json header	7 years ago
Oliver Günther	4d0bad7efc	Allow endpoints to override content types (attachments!)	7 years ago
Oliver Günther	8282c465cb	[26318] Enforce APIv3 content-type https://community.openproject.com/wp/26318	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	92060508a9	Remove unused test helper	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
Oliver Günther	cf55f61e73	Don't register textile formatters in initializer (#5903 ) When the autoloader reloads WikiFormatting, the values registered in the initializer are lost [ci skip]	7 years ago
Oliver Günther	75d2f010ba	[25108][26176] Assigned_to filter returns group values Since 7.0.0, the `assigned_to is <user>` filter also returns work packages assigned to a group that `<user>` belongs to. Since this is misleading and judged a bug by several customers, instead add a new filter that provides exactly this behavior, while using `assigned_to` only for the exact value specified there. https://community.openproject.com/wp/26176 https://community.openproject.com/wp/25108	7 years ago
Oliver Günther	ddcf35f3f7	Fix invalid value_objects being passed to representer There are queries that seem to pass values not available in APIv3 path helper to the instance representer. ``` Original error: #<NoMethodError: undefined method `anonymous_user' for API::V3::Utilities::PathHelper::ApiV3Path:Class Did you mean? anonymous?> Stacktrace: /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:82:in `block (2 levels) in <class:QueryFilterInstanceRepresenter>' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/vendor/bundle/ruby/2.4.0/gems/activerecord-5.0.4/lib/active_record/relation/delegation.rb:38:in `map' /opt/openproject/lib/api/v3/queries/filters/query_filter_instance_representer.rb:80:in `block in <class:QueryFilterInstanceRepresenter>' ```	7 years ago
Oliver Günther	ed1a0c87de	[25999] Make timeline labels configurable https://community.openproject.com/wp/25999	7 years ago
Oliver Günther	e02a65e372	[26141] Use valid subset of query to save it (#5859 ) https://community.openproject.com/wp/26141 [ci skip]	7 years ago
Oliver Günther	f07ee8c2b5	Don't use return in block	7 years ago
Oliver Günther	47c5475e44	Require hashie [ci skip]	7 years ago
Oliver Günther	ece6fa5d23	[26128] Fix local jump error (#5856 ) [ci skip]	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776 ) * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
ulferts	2f9d7f408a	Fix/wp table switch to milestone (#5825 ) * map date name in changeset * handle date switch in wp form * Don't stub_const for services that may exist before hand This will cause the const to be evaluated already, so that stub_const has no effect there. This is why this fails depending on the order on travis, but not locally/isolated. [ci skip]	7 years ago
ulferts	0c1c8d443a	don't use project as cache key if project is nil (#5806 ) [ci skip]	7 years ago
ulferts	61281b7f6a	explicitly set author to be nonwritable in wp schema (#5805 ) While the author is writable, one can set it to the current user. It should not be marked as writable as the backend makes that assignment already. But because of this behaviour we cannot rely on the default behaviour for determining whether a property is writable [ci skip]	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804 ) https://community.openproject.com/wp/26002 [ci skip]	7 years ago
Oliver Günther	9937307c7c	[25968] Use OpenStruct instead non-required hashie (#5794 ) https://community.openproject.com/wp/25968 [ci skip]	7 years ago
Oliver Günther	162401d962	[25768] Parse/Output estimated hours with seconds precision Was truncated to minutes before. https://community.openproject.com/wp/25768	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732 ) * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	4b7e3ff26d	Feature/limit attribute help text visibility (#5749 ) * code prettification * avoid help text for newly added cf requiring restart When using the class method statically, the values are determined upon reading the class. By that, a restart is required before newly added custom fields are added to the list and removed custom fields will still be listed * limit visibility of attribute help texts [ci skip]	7 years ago
Oliver Günther	ec6b856686	Add directive to show help text modal	7 years ago
Oliver Günther	57356059af	Create /help_texts endpoint	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
ulferts	39bbf082bf	fix author filter for projectless users (#5718 ) As the principals returned by the principals API where limited to those that are members in projects the user can see, users not having any project would not be returned. This is intended in so far as to prevent getting all users easily. But the user herself should be visible in any case. [ci skip]	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711 ) * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
ulferts	fc139e55df	limit visibility of relations index (#5703 ) [ci skip]	7 years ago
ulferts	835c18f91e	render empty href on invalid list cf (#5688 ) [ci skip]	7 years ago

1 2 3 4 5 ...

1360 Commits (905f81dd77ae774be95dc73f405559a012fd6c43)