openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	ab9acba818	Avoid checking for string output in git adapter To properly check for an empty repository, we now only check that at least one branch exists While you CAN create a situation where a repository is non-empty (has commits, but no branches) by, e.g., killing off all existing branches, I deem that case unrealistic.	8 years ago
Oliver Günther	1360639341	Fix URI escaping of svn checkout paths The paths weren't properly escaped for URLs. This fix allows any subdirectory of arbitrary chars to be displayed as a checkout URL. This also fixes an escaping issue in the adapter that prohibits checking folder with special characters which SVN doesn't care about.	9 years ago
Oliver Günther	38a12d96ba	Add option to accept ssl certificates This provides a configuration option to add `--trust-server-cert` to the SVN calls made by OpenProject. Either add the `trustedssl` key to the Subversion scm configuration or set the ENV `OPENPROJECT_SCM_SUBVERSION_TRUSTEDSSL=true`.	9 years ago
Oliver Günther	67e06ee2b2	Remove double escaping With OpenProject 5.0, we moved to Open3 pseudo-shell, which no longer requires escaping seperate arguments (unless the whole command is passed as a single string, which will result in an actual shell that would require escaping). The `shell_quote` functionality was still used though and causes issues with remote subversion passwords, which will be improperly escaped.	9 years ago
Oliver Günther	589ba8e7b1	Relocate repositories locally and remote This commit introduces relocating a repository as a followup after a project's identifier has been renamed.	9 years ago
Oliver Günther	b7465b08a6	Remote managed repositories This commit starts the work to provide functionality with remote service hooks for managing repositories. The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.	9 years ago
Oliver Günther	319c728b1a	Core notifications to alleviate third-party plugins This commit provides some helpers to alleviate SCM vendor plugins: * Provide code notifications when project, members and users are changed. * Allow Repository:* to determine base URL themselves (when no common URL is available) * Open Git adapter for subclassing (Gitolite)	9 years ago
Oliver Günther	cd7ec57ee6	Empty check for newer Git versions Git recently introduced a new format for outputting warnings on empty repositories in `ce11360467` This commit extends the empty test for this output	9 years ago
Oliver Günther	5b147e32d5	Storage performance and accuracy improvements This commit allows storage counting to shell out to `du` where available. The method uses du with `-bs` to count the apparent file size in bytes. Note that apparent size is NOT the same as the real required size on file system, but is used to be consistent with other sizes displayed in OpenProject (e.g., attachments size) When du is either unavailable or incompatible, in that it doesn't return the requested count, the ruby fallback counting method is used. This method has been slightly altered to use `File.stat` instead of `File.new(path).size` for reduced computational overhead compared to `du`.	9 years ago
Oliver Günther	9f26c74a38	Require find to avoid LoadError on qa-dev	9 years ago
Oliver Günther	ef322e89dd	Cleanup	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Oliver Günther	5e70588bea	Use --shared to create bare Git repositories Using Git --shared sets default permissions to group writable, otherwise when the user running OpenProject differs from the webserver serving Git (Apache in the supported setup), the permissions for changed files through Git Smart HTTP cause the repository to be no longer deletable by the OpenProject runuser.	9 years ago
Oliver Günther	38c138889e	Use consistent vendor/klass variables in scm/manager	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Oliver Günther	8a418381f1	Remove superfluous nil check	9 years ago
Oliver Günther	2769e16819	[21275] Show information on storage paths as admin/info section This commit adds a separate section in the admin/info section to show used and available storage for: * Attachment storage * Manageable repository vendors	9 years ago
Oliver Günther	3ccde73519	Allow automatic creation of manageable repositories through a setting This commit allows manageable repositories to be automatically created by default whenever a new project is created and the repository module is activated. Relevant work package: https://community.openproject.org/work_packages/21277	9 years ago
Oliver Günther	1b9ba9c4bf	Remove repository project hierarchy This commit removes the project hierarchy introduced with repository management. They are not required, incompatible with mod_dav_svn and provide little to none advantage to storing all repositories in a flat structure for the scale we require.	9 years ago
Oliver Günther	e8c7e73dff	Force setting of root_url for local git repositories When the root_url is not delivered explicitly, the scm adapter is missing it even though it may be able to count it, e.g., when adding existing, local repositories	9 years ago
Oliver Günther	612a1809f4	Confirmed that UTF-16 incorrectly returns nil This commit adds a spec for the UTF-16 invalid detection as binary, which is consistent with previous behavior, but the whole content encoding problem should be addressed.	9 years ago
Oliver Günther	2b0ac5f86e	Use heuristic check to determine binary files based on null bytes The git adapter currently has a bug that denies to annotate regular text files when the author name has an umlaut. This commit changes the binary file detection by simply counting null bytes. This may not detect all binary files correctly, but that isn't a requirement. The original check was arguably used to avoid rendering large binary files in the browser. Relevant bug report: https://community.openproject.org/work_packages/20883	9 years ago
Oliver Günther	c16c1e75d4	Extend SysController to allow WS to check / update storage	9 years ago
Oliver Günther	8b5a120052	Move storage information to database This commit effectively adds a storage information column to repositories. It tests the functionality of the counting on subversion and git repositories / adapters.	9 years ago
Oliver Günther	29ab3f74c0	Add quota display using .reposize file. This commits add the basic functionality for: - Retrieving the storage size of a repository in pure ruby. - Retrieving the latest mtime of a file in a repository - Asynchronously getting and writing this information in a separated file inside that repository (`.reposize`) with YAML for convenience.	9 years ago
Oliver Günther	86f847043b	Allow configuration to disable arbitrary SCM types This commit provides: - Configuration options for disabling any number of available types of that particular SCM vendor. - Changes to the underlying structure to allow determination of which types are available on a class level.	9 years ago
Oliver Günther	edf713fbd5	Rework managed repositories error handling This commit: - adds error messages for filesystem errors - Forces services and views to use repository.root_url instead of managed_path, which may not be available when config is missing	9 years ago
Oliver Günther	bb2a09490b	Remove delayed running of management workers. This commit (temporarily) removes the delayed creation and deletion of managed repositories for the sake of improvded error handling. After consultation with @ulferts, we suggest to improve the `Delayed::Job` pipeline to create means for identifying jobs (referenced ID) and to create a unified service to manage database AND filesystem access in a transactional manner. Also provides the following corrections: - Improve migration speed - Delete parent projects only by their identifier, not the managed root	9 years ago
Oliver Günther	319bd21daf	Moved managed repository lifetime entirely to the model.	9 years ago
Oliver Günther	e1bdb41bcd	More complete specs wrt. coverage, cleanup	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	abc597a6d2	First draft implementation of radio-based frontend.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the legacy specs for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago

40 Commits (90c6fdfed6e747f5105856f93ecdbce706044edd)