1264 Commits (90f2b5157af27c6ea365f456df5422ff2bceee02)

Author	SHA1	Message	Date
ulferts	a9dfb35150	avoid modifying frozen string from nil	4 years ago
ulferts	87471d9624	remove string_objects and replace deprecated URI.unescape	4 years ago
Oliver Günther	8d2da3f6d8	[33648] Add value macros for referencing label and values of project and work packages (#8578) ... * Add macros for attribute values and labels of HAL resources * Implement label macro with help text For that, we need to move help texts out of the work package module. The fields module appears to be best suited for it. * Load the current project for project attributes * Don't render things that only matter in writable situations Such as the project dropdown indicator or the spent time modal * Throw if ID was not correctly provided * Bootstrap the inserted html of a custom text * Expand errors if user cannot see/load expected macro resource * Add text formatting spec * Add feature spec to test both loadable and failing macros * Reference only subjects in the current project if not referenced by id * Extend documentation * Refactor loading switch * Add macro for work package quickinfo (previously ## and ###) * Extend spec to double and triple hash macros * Ensure we allow numeric strings as IDs Was testing for isNumber, which only checks for actual number types * Fix showing the placeholder when not empty * Add error span to the quickinfo macro * Better styling and title help for macros	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580) ... * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Oliver Günther	c369a71f4d	Allow project help texts on the rails form ... Renders help texts on a project core attributes and custom fields	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	8cb7ed632a	remove watchers embedded in wp representer ... A client should not rely on embedding and our front end does not appear to	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	655f021b92	add derived dates to the work package resource ... The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
ulferts	c5ead62e0a	adjust contract to allow setting dates on manually scheduled parent wps	4 years ago
ulferts	a2a559e553	remove almost duplicate, but faulty, readonly check ... The writability of the status is already checked at the attribute level	4 years ago
Oliver Günther	2feaec1101	[33678] Priority needs to be a require field ... Priority was marked non-required for it to turn up in the attribute form configuration. But priority _is actually required_. This results in the frontend adding an optional placeholder `-` value, which makes the resource unsavable. This commit adds priority to the form, but keeps it required as it should be. https://community.openproject.com/wp/33678	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images ... Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
Oliver Günther	95d1549858	Move legacy project copy spec to service spec	4 years ago
Oliver Günther	62d76b32c7	Fix specs	4 years ago
ulferts	75b308d154	fix permission checks for edit_own_work_package_notes	4 years ago
Oliver Günther	ff4d430eb0	Fix case of task list with link after text node	5 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Oliver Günther	6dabfa5628	Fix case of task list with link after text node	5 years ago
Markus Kahl	9c4d4ebc46	added :schedule_manually attribute to work package	5 years ago
ulferts	df115f44f2	handle deleted custom options	5 years ago
ulferts	4e5c5649e6	fix relation representer spec	5 years ago
ulferts	7d82fea80e	avoid fixtures in seeding spec	5 years ago
Oliver Günther	80e747e0c6	Fix test by calling service with system user ... Adds this to the factory to avoid using the system user all over the place	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	3f9126a9e8	remove/replace/reactivate specs disabled by former plugins	5 years ago
ulferts	b5a7c1fd9c	add necessary method to stub	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	cad1b69a5c	fix reference to i18n keys	5 years ago
ulferts	90d8cbaa15	have filter values ordered by semver	5 years ago
ulferts	9c78d48cea	allow args on scope method	5 years ago
Oliver Günther	4b5d3c3e41	[31628] Downcast todo lists in tables to markdown ... Tables are saved as HTML, thus avoids any frontend turndown within it. This means todo lists are kept as is, with the CKEDitor frontend style. Currently, they will be sanitized after turned to markdown in the backend. We can easily downcast the todo list part into text. This ensures that the todo list does not get sanitized, and will correctly be found by the todo list filter. https://community.openproject.com/wp/31628	5 years ago
ulferts	633a82dff8	display user name as link for non admins ... The showUser link of the user representer is now used to signal when the link can be followed. That link can only be followed when the user is not logged. The frontend now only checks the availability of the link to determine whether the user name in the work package activity is to be displayed as a link or not	5 years ago
ulferts	7fa2abf5fa	adapt factory usages	5 years ago
ulferts	112f8c1be3	hide bim permission group in role view if bim disabled	5 years ago
ulferts	5861da0d6d	have hal conforming link to bcf comment in activity	5 years ago
ulferts	25348c3ec2	stub in specs	5 years ago
ulferts	a6e87c9dcb	display retracted message on empty journals	5 years ago
ulferts	399e8c3ed9	rename according to zeitwerk	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
ulferts	a62c157f18	rename news created_on column to created_at	5 years ago
ulferts	9d2ebdf22a	wip - creating time entries	5 years ago
ulferts	51b1ef026c	add specific api end points for allowed work packages for time entries	5 years ago
ulferts	1a6e693651	add schema and update link to time entry	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	7167a85cb0	Fix specs by correcting the project settings paths and do some minor selector changes	5 years ago
ulferts	614373828f	add time entries create form and schema	5 years ago
ulferts	7d4a4a19e7	use join table for storing activites active in project	5 years ago
ulferts	6718428b69	hide op version for non admins in api	5 years ago