2320 Commits (92605548aa99f6365b2817d85e4ac8626c203a1d)

Author	SHA1	Message	Date
Oliver Günther	cb123c83be	Fix and specs for missing plus in login attribute ... Fixes the merge issue from 105934a5f9	10 years ago
Jan Sandbrink	4a69d2505a	replace ternaries returning booleans ... - foo ? true : false was replaced where foo already was bool - foo ? true : false was kept, when the ternary did a bool conversion - foo ? false : true was replaced by either negation or replacing == with != Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict	10 years ago
Jan Sandbrink	f1a93e1cf3	this is why I hate comments	10 years ago
Jan Sandbrink	c075a7b401	only allow simple space in login ... also add specs to verify that	10 years ago
TribesTom	2910137c03	Added user changement	10 years ago
Alexander Bach	55f5f33456	Changed code readability	10 years ago
Alexander Bach	942f39876f	Removed hard coded id column for pdf export	10 years ago
Alexander Bach	404a5b42e6	Remove hard coded id column for csv export	10 years ago
Jan Sandbrink	88107362b1	enhance PSQL compatibility of cast_value ... In PSQL a valid boolean can also be represented using other value than '0' and '1' This led to cast_value sometimes returning false, even though it was supposed to return true...	10 years ago
Jan Sandbrink	eb9ef1f2b1	replace occurences of cast_value with typed_value	10 years ago
Alex Coles	54ff7af6e7	Add/update Copyright headers in app code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	60ca779111	make transform to boolean more database resistant ... PostgreSQL has many representations for bool: http://www.postgresql.org/docs/9.1/static/datatype-boolean.html	10 years ago
Alex Coles	ef4285bc0c	Kill deprecated Setting.*_cache methods ... Deprecated in version 2.4.0 (2011). See: d76fd8e4. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	9f692f6bf1	Use the empty string for absent descriptions	10 years ago
Jan Sandbrink	f9b242884d	let custom values accept their native type ... - add specs for strategies to parse their typed representation as valid (instead of only their stringly typed counterpart) - add specs to int and float strategy regarding accepting eachother - fix int custom values accepting float inputs (which would work, but omit the fractional part) - fix date custom values not accepting on Date	10 years ago
Alexander Bach	ee31bc9762	Increased code readability	10 years ago
Alexander Bach	35f9ec6db8	Consider all of the time entries visible to the user	10 years ago
Jan Sandbrink	2bf38a622f	create journal when CF toggles between false + nil ... the changed? method of the JournalManager did handle false values not correctly and considered them blank. However, a boolean CF that is not required can have (technically) three states: - true - false - nil Thus we can't consider nil and false as the same case	10 years ago
Jan Sandbrink	5f19189e71	create CF journal for CF set to false ... This is only an issue when the CustomValue.value is actually false. Legacy code uses stringly typing and thus has values like "1" and "0"	10 years ago
Jan Sandbrink	f31dd80acb	add explicit author to more mails ... neccessary for correct self-mail detection	10 years ago
Jan Sandbrink	93d20011e5	fix more TestUnit tests ... - also adding author to news_added	10 years ago
Jan Sandbrink	1f3b47f461	test and fix mail delivery ... - add specs testing the observable behaviour - keep the interceptor mostly intact - use the same hack already known	10 years ago
Jan Sandbrink	05bdba6a29	fix preview of true custom field in form ... :typed_value would not return true if the internal value was set to true (it only ever expected it to be '1')	10 years ago
Jens Ulferts	13e0940171	only display scm options if they are configured	10 years ago
Jens Ulferts	fce72938e3	prevent path traversal via filesystem scm ... Setting up a filesystem scm now requires to specify a whitelist via the configuration	10 years ago
Jan Sandbrink	9fbf3864f8	use callable to define scope ... - Rails 4 compatible - MIGHT fix an issue on travis	10 years ago
Jan Sandbrink	52696b5c98	extract a scope for active priorities	10 years ago
Alexander Bach	15f52bcdc6	Added validation for estimated hours values	10 years ago
Alexander Bach	cac13a8f4d	Simplified validations to their core necessities	10 years ago
Alexander Bach	ed73ab271c	Basic implementation	10 years ago
Jan Sandbrink	857bcf4636	some refactoring around the WP schema ... - schema does not decide anymore whether to include allowed values (solely decided by "form_embedded" of representer) - schema will answer as many "assignable_*" methods as possible - work package does not need those methods anymore (except few cases)	10 years ago
Jan Sandbrink	348d3c746e	fix submission of "false" as CF value ... it was not possible to set a custom field to false via APIv3. Apparently the way the value is set in other places does not involve "real" boolean types	10 years ago
Jan Sandbrink	53909cbb61	indicate type as editable in schema	10 years ago
Jan Sandbrink	9986466e15	use direct CF accessors in CF injector	10 years ago
Jan Sandbrink	1a25e19c2f	remove 'true?' helper from custom_value	10 years ago
Jan Sandbrink	2e32e120f7	better naming	10 years ago
Jan Sandbrink	943e01c978	use fancy ruby shortcuts	10 years ago
Markus Kahl	21553ea918	avoid 500 upon mail failure when creating issues ... also log the errors with specific tag so they can be found	10 years ago
Jan Sandbrink	3161b9ca7b	remove unneccessary return statements ... this is how ruby style works... apparently	10 years ago
Jan Sandbrink	5ba53b49b9	various small fixes	10 years ago
Jan Sandbrink	2fb0e370ad	only perform validation if it is possible ... IMO the best way to deal with that ugly inter-validation dependency. You just can't meaningfully test whether a value is valid, when you don't know its format.	10 years ago
Jan Sandbrink	25dec31c5a	extract some case statements into fancy strategies ... - 17 new files - lots of new lines of code - specs! - same functionality as before	10 years ago
Jan Sandbrink	05884417f7	let custom values return typed values ... this allows to have type-correct JSON output, e.g.: 12 instead of "12" true instead of "1"	10 years ago
Jan Sandbrink	0be2c94e49	update method doc	10 years ago
Jan Sandbrink	9532c39c5e	add another case to repair list custom fields ... Genius idea to require the parameter of a method to carry totally different information, depending on internal state of the object	10 years ago
Jan Sandbrink	ac655ac789	validate user and version custom fields	10 years ago
Alexander Bach	f403d6aaaa	Increase category validation strictness	10 years ago
Alexander Bach	cf63634444	Appease hound	10 years ago
Alexander Bach	03494dae0a	Some style improvements	10 years ago
Alexander Bach	339a9836ee	Low-hanging fruits of style improvements for work_package.rb	10 years ago