3427 Commits (93c2d17dc0f8b4527812ee0bb6c893a60fd0a42a)

Author	SHA1	Message	Date
Jan Sandbrink	8897235fa4	rewrite find into where, order and limit	9 years ago
Jan Sandbrink	194f1814e1	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	9 years ago
Jan Sandbrink	e51a4005ff	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	9 years ago
Jan Sandbrink	280e333f18	explain why some code exists	9 years ago
Jan Sandbrink	2854584cb2	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	9 years ago
Jan Sandbrink	45815cb9f3	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	9 years ago
Alex Coles	851f23712f	Prune commented code in TimelinesController ... [ci skip] Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8798fe68ad	Teach Experimental API UsersController to pluck ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0942d7335b	Add explicit join references in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2d9cfd97f4	Remove deprecated Relation#all in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	ffd81c4886	Add some polish	10 years ago
Jens Ulferts	01b5839cd2	remove multiple responsibility in controller ... Using dedicated CostQuery::Cache for this	10 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	10 years ago
Markus Kahl	d854df5175	suppress browser prompt on authenticate failure	10 years ago
Jens Ulferts	9b92187bae	use interpolation in I18n ... Relying on the position of some variable by appending in the code is bad practice	10 years ago
kgalli	32655ef1dd	Refactoring: replacement of `and` with `&&`	10 years ago
kgalli	d1b82564af	Refactoring: increase readability	10 years ago
kgalli	62607c1779	Refactoring: reduce of unnecessary block chaining	10 years ago
Jonas Heinrich	9db7d41311	Makes the notification to an error	10 years ago
Jonas Heinrich	8f7907b6f7	Catches error while sending notifications	10 years ago
Alexander Bach	1a52cc1292	Suppress the hound	10 years ago
Alex Coles	0c729dae54	Replace deprecated calls to Model.scoped ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	c687c63c71	Fix some project url building with identifiers ... This commit was powered by @ulferts	10 years ago
Alex Coles	ecfa05fad9	Rename Project.public scope to public_projects ... Avoid collision with `public` class method. As of Rails 4.1, `public` is explicitly black-listed as a scope name: https://github.com/rails/rails/pull/14582	10 years ago
Alex Coles	51512f1522	Temp. comment includes in API v2 ProjectController ... `includes().find` appears to have issues with polymorphic associations in Rails 4.0.x. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e02eb0181d	Migrate AR finder/query methods in controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ec1bb39f9b	Fix syntax (w/Rubocop) in (Rails) controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	9eb7cfbe9b	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Alex Coles	5f09485357	Remove all usages of unloadable ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1b8f254262	Remove all usages of unloadable ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	d3ceffddfc	actually allow the status to be set while moving ... apparently the status_id param was set to expect an array of values while being moved in this commit: d7f399ab8d Probably because the spec started to expect that when it was moved to be an RSpec test. I am not sure if this was ever a valid thing outside the tests...	10 years ago
Jan Sandbrink	b44b0cd2f9	remove details on spent time from project overview	10 years ago
Jan Sandbrink	42ec887384	uglify order statement ... at least this one DOES work...	10 years ago
Jan Sandbrink	0f868f17e2	specify order in the Rails 3 way ... ascending is the default anyway	10 years ago
Jan Sandbrink	9ed5480298	also accept auto complete requests without query	10 years ago
Jan Sandbrink	799f3b9b52	eliminate instance variable	10 years ago
Jan Sandbrink	b265ad88db	increase readability of wp->hash conversion ... it might use more lines, but I hope there is a gain in readability	10 years ago
Jan Sandbrink	b524b0724d	rewrite find into where, order and limit	10 years ago
Jan Sandbrink	dd052d5114	always return a valid scope ... though WorkPackage works like a scope *most* of the time, it is not a scope e.g. you can't directly call :order on WorkPackage Note: I would have loved to already do it the Rails 4 way and call :all However in Rails 3 :all returns an Array and not a Relation, so we will have to wait for the Rails 4(.1) Upgrade to replace :scoped with :all :( Sorry @myabc	10 years ago
Jan Sandbrink	dc71f37587	try to increase readability ... - extract scopedeterminition into an extra method - always use "outer" if statements in index method	10 years ago
Jan Sandbrink	4556da741e	explain why some code exists	10 years ago
Jan Sandbrink	d59b54a63c	use more clear scopes for autocompletion ... lets see if that really makes stuff more understandable... I (personally) found the old definition of "all" to be too narrow. Now there is: scope == "all": I want to search over all WPs scope == "relatable": I want to search over all WPs that are relatable to WPs in the given project (via project_id) no scope: If I specified a project search over the WPs of that one, otherwise search everywhere (like "all")	10 years ago
Jan Sandbrink	75b542725a	rename query to scope ... sounds more understandable to me, but I am biased, I guess...	10 years ago
Oliver Günther	c5c6dc3daf	Move cost type administation menu from Module to Administration ... This moves the 'cost type' menu from within Modules to the administration main menu. Related to https://community.openproject.org/work_packages/20503	10 years ago
Alex Coles	a1e3b03a4a	Remove unloadable from controllers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e480aae38d	Split CostTypesController#toggle_delete method ... Split into separate #destroy, #restore methods. * Add skeleton CostTypesController spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	bc5abb34ab	Remove explicit require_dependency of Principal ... This should no longer be necessary (thanks also to 8edff983). This effectively reverts 423152fa06 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	cbe64452a8	Improve initialization readability	10 years ago
Alex Coles	077e42ba06	Make VersionsController#update use PATCH ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago