158 Commits (951409372c60c072a9dc91bb6f7f3de03d41a8d6)

Author	SHA1	Message	Date
ulferts	e37974dbed	actually provide all relevant custom fields for performance hack ... Before, the last iteration on a project determined the custom fields that where hacked to be loaded in a project. That way, when the last project had e.g. no custom fields on a specific type, the custom fields would be missing for all evaluations later on, even though it might actually have custom fields defined for other types. As the results of the first call would be cached, this would then also affect later requests	5 years ago
ulferts	ad847a3892	add type attribute group attributes to cache key ... This is an attempt to fix cases where some custom fields are not displayed. I suspect this will not fix the bug in itself. But it might help to narrow down the problem by preventing the bug to also affect users who are not affected by the bug originally but only because the buggy result was cached for them.	5 years ago
ulferts	d5ee1a7d20	ensure order of cache key	5 years ago
ulferts	a9213a39cc	remove duplicate permissions	5 years ago
ulferts	a880c85a1d	partial caching for wp schema attribute groups	5 years ago
ulferts	5ee801b549	cache roles for project	5 years ago
ulferts	0dcb1777d6	reduce db hits for wp schemas	5 years ago
ulferts	cc41884048	add schema to project api and complete project resource	5 years ago
ulferts	7971a29a8b	don't cache the attribute_groups	6 years ago
ulferts	4ffa71e68d	include a relevant setting in the wp schema cache key	6 years ago
ulferts	a199c94a6a	have permission specific schema caching	6 years ago
ulferts	e8f2ad5516	reenable caching using standard methods	6 years ago
ulferts	41bb309094	disable wp schema caching until it is turned save for it again ... [ci skip]	6 years ago
Oliver Günther	f492113c94	[30275] Allow global type select, restrict available projects ... This allows to select all available types globally, and restrict the projects to the ones that have the type available. The same functionality applies to embedded tables, where a filter on a type will ensure that only the projects with the type selected will be returned. https://community.openproject.com/wp/30275	6 years ago
ulferts	6e5b81dc3f	add schema specific wp contract	6 years ago
ulferts	a5defb73c5	add dedicated permission to regulate assigning a version	6 years ago
Oliver Günther	1b5fc32366	Avoid before blocks and raw params access for IDs ... Grape's validation runs after a `before` block so we should avoid using raw params there and instead using `declared(params)` which returns only the validated whitelisted params, much like a permitted params hash.	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299) ... Feature/versions api update [ci skip]	6 years ago
Wieland Lindenthal	fd88776ceb	Add relations tables to Types via form configuration (#6773) ... * WIP: PrecedesFilter and FollowsFilter for WorkPackages * Create Type Form Groups per Query Type * generalize filters on relations avoiding alias * fix flickering spec * Rename dependency represeners for Follower and Predecessor Filters * Allow configuring templated queries within query configuring modal * Use `{id}` as templated value, instead of a now deprecated `templated` string * Rewrite ParentFilter to follow same structure as other relation filters. * Set Follower and Predecessor filters as hidden in Frontend * Default query shall show closed WPs, too * Remove relation filter type selection from form configuration view as we extend query configuration modal instead. * Allow ExternalQueryConfiguration to be more specific and prepend relation filters in its modal. * Quick unrelated fix on the way: the instruction text should start below the columns input and not to the right of it * - Add all missing relation filters. - Use verbs for naming instead of nouns to stay consistent with UI. * fix typo * Add relation filters to hidden filters and fix a rebase bug * Typo in docs * Fix broken rebase conflict resolution * Add part of and includes filter * adding specs for relation filters * rename RelatesFilter to RelatesToFilter * Rename shared example as direction does not matter anymore. * Fix spec for IncludesFilter * Fix name conflict for `includes` by calling typed_dag's `direct` later. * Fix shared filter examples as the parent filter does not get added per default anymore. * Fix spec after renaming PredecessorFilter to PrecedesFilter * Fix integration spec for type configuration form * Add filter dependency specs * Differentiate between WorkPackageFormChildrenQueryGroup and WorkPackageRelationQueryGroup types * Create inline-create for relation tables * Rewrite filters to use actual relation_type as key * Reload relations on change, change symbols * Fix relation filter i18n strings * Test presence of all relation filters frontend. * Extend integration test for form configuration to not only cover hierarchy, but also undirectional and directional relation types. * Consistent naming of filter dependency representer files * Satisfy codeclimate * Add missing copyright notes * Fixing PartofFilter and its specs * Reverse relation direction when created inline * WIP integration test for Relation Query Component and Children Query Component. * Correctly reload children tables when refreshed * Fix FilterOnUndirectedMixin * Fix removing of relation from embedded table after reload * Adding intergration tests for removing and adding relation or children, initiated form either embedded table or relations tab. * Fix specs * Fix implementation of duplicates and duplicated They are reversed in typed_dag and causes confusion [ci skip]	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list ... Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
Jens Ulferts	ce21ee20f7	cached representers	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Jens Ulferts	77116b5cdb	ensure not to have user specific query cached in schema	7 years ago
Jens Ulferts	9e4f5053bc	hack having the children table provisioned from the backend	7 years ago
Jens Ulferts	3e86dafad2	extract children rendering into dedicated component	7 years ago
Jens Ulferts	a33b0bbbbd	WIP - return Query as an attribute group ... * only default query for now * only returned when no custom configuration is applied * start to turn attribute groups into ressources	7 years ago
Jens Ulferts	6d359cb02d	turn attribute groups into array of objects	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
ulferts	61281b7f6a	explicitly set author to be nonwritable in wp schema (#5805) ... While the author is writable, one can set it to the current user. It should not be marked as writable as the backend makes that assignment already. But because of this behaviour we cannot rely on the default behaviour for determining whether a property is writable [ci skip]	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804) ... https://community.openproject.com/wp/26002 [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
ulferts	65c7db3120	avoid side effects on calls to attribute_groups (#5677) ... Without the deep_dup, the call to attribute_groups used to alter the type's attribute_groups deeply nested attribute_groups property. As a result, the second call to attribute_groups would be different from the first one. This became most apparent when rending the schema for a couple of work packages all sharing the same type. As the type was reused to render the schema, but the project might have changed, only the first schema for the type was accurate, while subsequent schemas for that type lacked attributes [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	5d50acc50e	[25288] Re-add translations to default attribute groups (#5515) ... * [25288] Re-add translations to default attribute groups Uses symbols to mark internal attribute groups and translates them in the schema representer to the user's locale. * Extend form configuration front end for translated default groups * fixing specs * fix feature spec for attribute groups * Add symbol test to attribute groups [ci skip]	8 years ago
Jens Ulferts	8a08856748	replace string object by custom option for list custom fields	8 years ago
Oliver Günther	1cfa120192	[19714] Make priority part of form configuration ... This allows users to completely disable the priority, if they wish. As it will always receive a default value, it is internally still a required field.	8 years ago
Oliver Günther	93dcd386f4	Remove usage of CF translations	8 years ago
Jens Ulferts	3851a85173	include the current op version into the cache key	8 years ago
Jens Ulferts	6391867267	minor code quality improvements	8 years ago
Oliver Günther	ba9c0ce58f	Allow custom fields to be added through type	8 years ago
Oliver Günther	e4f0cb6634	Fix AR method name duplication	8 years ago
Oliver Günther	8220d43bbf	Add custom sub-models for attribute constraints and groups ... This allows plugins such as backlogs and costs to integrate into the grouping while restricting while they are visible. The problem here is that on a global admin page, the plugin's attributes should be available, however in a project context, they should only be added when the respective module is active.	8 years ago
Oliver Günther	59220397d8	Implement frontend for group configuration	8 years ago
Wieland Lindenthal	8000c27bec	Fixing spec	8 years ago
Wieland Lindenthal	da9afaa9a2	Not necessarry stuff killed	8 years ago
Wieland Lindenthal	69eb0779cb	fixing specs for new format of saving attribute_groups as an array of arrays	8 years ago
Markus Kahl	3cf5cda7ce	fixed _attributeGroups format	8 years ago
Markus Kahl	0ff5eb8d3f	attribute groups backend draft 1	8 years ago