201 Commits (9515b58f495d4b97734a9a874ed43df230437935)

Author	SHA1	Message	Date
Oliver Günther	591c665639	Store only the changeset in a state, not the form itself ... With the changeset being the authoritive source of the changes to a work package, we can pass it around. Also, a temporary resource for viewing the changes made to the work packages is available through the editing service. This is required since we need to show the WP resource as it were if the changes were applied.	7 years ago
Oliver Günther	8e07376912	Create separate changeset object to provide resource and schema	7 years ago
Oliver Günther	681ce4684d	Avoid normalization of date fields outside table	7 years ago
Oliver Günther	9b6e9a1371	Extract click position mapper for input fields for re-use	7 years ago
Oliver Günther	56b67e9f9e	Consolidate existing WorkPackageField and TableWorkPackageField	7 years ago
Oliver Günther	f49e9c93ef	Replace wpEditModeState and wpEditForm with one directive	7 years ago
Oliver Günther	c00d53de90	Implement single view context for previous edit fields	7 years ago
Oliver Günther	d73547bd05	[25676] Do not override parent collapsed state (#5762) ... When expanding/collapsing hierarchies, we iterate the collapsed groups index to collapse groups quickly through CSS selectors. When a parent group is collapsed, but a child group is expanded, members of that group were incorrectly marked visible even though they were hidden by the parent. [ci skip]	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
Oliver Günther	355dc08fc5	Extract base cache state from relations and work packages services ... This handles the implicit expiry of items after a given time interval.	7 years ago
ulferts	d1ddd2d5d2	Feature/toggle between hierarchy and group by (#5720) ... * allow toggling between hierarchy and groupBy * fix icon alignment in query settings dropdown * buffer query updates to prevent duplicate backend requests * simplify focus-within delay [ci skip]	7 years ago
Oliver Günther	07a5cd2acc	[25666] Reload relations in table ... Since relations are only loaded when required, we should clear those states so that upon table reloading, the relations are actually refreshed. https://community.openproject.com/projects/openproject/work_packages/25666/activity?query_id=931	7 years ago
Oliver Günther	9a97bb1449	[25298] Only use visible work packages for the timeline row order (#5702) ... Fixes https://community.openproject.com/projects/openproject/work_packages/25298/activity?query_id=933 Additionally, only conditionally loads relation that are not loaded into states, this will make subsequent requests with TL open much faster. [ci skip]	7 years ago
ulferts	0c2b544635	Fix/update wp to be in details pane (#5701) ... * observe changes to wp table to update detail view candidate * select row of wp shown in details view [ci skip]	7 years ago
Oliver Günther	ccca8641e8	Refactor selection state to handle additional elements	7 years ago
Oliver Günther	ed8baccc3b	[25615] Render content of additional hierarchy rows ... Renders additional hierarchy elements as regular citizens of the table. To this end, we need to load all ancestors when the hierarchy mode is enabled. This PR combines the WP loading of the relation columns service with the required WPs of additional hierarchies into a separate service. Additionally, whenever the hierarchy mode is turned on, we now need to visibly refresh the results.	7 years ago
Oliver Günther	8113ed9d19	Show relation rows as regular members of the table ... Still WIP: - Relation column is rendered as all other rows (indicator for dropdown), which is confusing	7 years ago
Roman Roelofsen	616ccb05a8	Timeline relations bug relations folding (#5687) ... * Fixed some tslint warnings * Correctly display relations when parent rows are folded * Removed console.error statements [ci skip] * without comment.... [ci skip]	8 years ago
Oliver Günther	37635b37a6	Extract wpRelations into DM and logic service (#5673) ... [ci skip]	8 years ago
Oliver Günther	1d0b09fa5f	Merge release/7.1 into dev (#5667) ... * [25580] Remove Settings callbacks from avatar_helper `register_callbacks` will not work if its used to update a class-level variable. We might want to think about removing this entirely, however impermanent-memberships is still using it to update the database after a change. https://community.openproject.com/projects/openproject/work_packages/details/25580 * change toolbar button height (#5664) https://community.openproject.com/projects/openproject/work_packages/255 11/activity [ci skip] * Fix/relations drawing (#5663) * improved drawing of timeline relation lines * Improved relations data flow * Timeline relations: Load relations once the timeline becomes visible * - Fixed SwitchState failing test - Version bump ReactiveStates - cleanup [ci skip] * Set indention of breadcrumb for correct alignment * remove wiki icon for wiki submenu in main menu (#5665) [ci skip] * Add missing class * Fix table hierarchies previous values [ci skip]	8 years ago
Oliver Günther	7758812768	[25387] Refactor query availabe states into separate input states (#5659) ... * Refactor query availabe states into separate input states * Fix tests [ci skip]	8 years ago
Oliver Günther	fea5113975	Work on copy of renderedRows since we're modifying them ... [ci skip]	8 years ago
Oliver Günther	507c2d26ea	Remove fromType, toType	8 years ago
Oliver Günther	e7f5825684	Use separate dataLoaded state to mark table requirements loaded ... This allows us to no longer clear the state of open/closed relation columns when refreshing the table.	8 years ago
Oliver Günther	bbdb4bf54f	Print work package type for 'ofType' relation columns	8 years ago
Oliver Günther	569369092d	Avoid setting the workPackageId to ignore clicks	8 years ago
Oliver Günther	8d14236fa9	Add better labels	8 years ago
Oliver Günther	6a5a7af466	Add some happy debug outputs	8 years ago
ulferts	f4b36edccb	Feature/save zoom in query 7 1 (#5637) ... * Implement timeline zoom level as query enum * Implement query zoom handling in frontend Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query. * Extend feature spec for zoom saving * Refactor URLParamsHelper into TS service * Fix comparison in table query services * Remove reference to allowedValues [ci skip]	8 years ago
ulferts	6a1302a5c3	reset hierarchy mode compare value on query change (#5641) ... [ci skip]	8 years ago
ulferts	df99cf15c3	fix wp subject display in ff (#5640) ... * fix wp subject display in ff The subject used to be hidden because the width calculation was off. Instead of tempering with the width calculcation, I decided to use float instead so that we end up with fewer objects having their width calculated in js * fix being able to double click on hierarchy area * add comments on pointer-events [ci skip]	8 years ago
Oliver Günther	04822ba680	Render rows in timeline pass regardless of WP association	8 years ago
Oliver Günther	568518d6a3	Move QueryColumn interface into its own class	8 years ago
Oliver Günther	7d62d846a2	Implement relation columns as secondary render pass	8 years ago
Oliver Günther	b7f8a74937	Introduce derived state for when table query states are ready	8 years ago
ulferts	20dd8a6e0a	Feature/work package id filter (#5614) ... * add filter for work packages by id to query * hide the id filter in front end As we do not yet have satisfying means to display the filter values for selection, we hide the filter and use it internally only [ci skip]	8 years ago
Oliver Günther	ac46271c59	[25430] Set the width of the remaining space next to hierarchy indicator (#5613) ... This allows inline edit fields to retain the whole remaining size next to the hierarchy indicator. https://community.openproject.com/projects/openproject/work_packages/25430/activity?query_id=916 [ci skip]	8 years ago
Oliver Günther	bbda2c572d	Set the current hierarchy mode correctly in HierarchyTransformer (#5612) ... [ci skip]	8 years ago
Oliver Günther	c2d050e5ba	Fix comparison in table query services	8 years ago
Oliver Günther	d6b8b92037	Implement query zoom handling in frontend ... Had to refactor: 1. The zoom level enum in the frontend cannot properly be matched to strings so I chose a separate type instead to map to the string retrieved from /sent to the query 2. The way query updates are done through the states. The previous implementation only worked for one single attribute state. For the timeline state, it does not make sense to split that into two, so I delegate to the state to handle checking and updating the query.	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	3c283ea512	Render table sums row in separate directive (#5595) ... * Render table sums row in separate directive * Fix JS error on setSelection It is not supported for [type=number] input fields. [ci skip]	8 years ago
Oliver Günther	ebdad784cd	[25415] Add ancestor groups always when inserting extra rows (#5587) ... The hierarchy render pass uses ancestor groups to identify which rows belong to a certain hierarchy group for simple selector-based hiding/expanding of nested groups. For extra added rows, these groups were only added when the ancestor was not yet added to the list, causing them to not respond to collapsing the ancestor group. [ci skip]	8 years ago
Oliver Günther	e20ef8fc71	[25411] Never render extra parents in timeline (#5584) ... Currently, hierarchy mode does NOT load extra parents that are not part of the results table (marked grey). As they are not loaded, the timeline doesn't have any information to draw them with. However, IF the workPackages state _had_ the value of the work package (e.g., because it's open in split view or it is part of a relation), it would still be rendered. This PR avoids rendering these rows at all times. [ci skip]	8 years ago
Oliver Günther	1163875917	[25383] Refactor wp-timeline cell to be rendered top-down (#5573) ... * [25383] Refactor wp-timeline cell to be rendered top-down Avoids creating timeline cells as part of the table rendering process, but rather lets the container maintain the reference to them to instrument drawing and updating single rows. This removes the necessity for the `unsubscribeTimelineCells` hook and with that fixes https://community.openproject.com/projects/openproject/work_packages/25383/activity?query_id=896 * Extract cells rendering in separate class * Add missing takeUntil [ci skip]	8 years ago
Oliver Günther	160d8876c7	Add switch state in query state handling to clarify access to states (#5571) ... [ci skip]	8 years ago
Oliver Günther	a9b206687e	Don't handle the state link when modifier present (#5567) ... [ci skip]	8 years ago
Oliver Günther	f324aaff63	[25369] Avoid console errors when quickly moving between queries (#5566) ... [ci skip]	8 years ago
Oliver Günther	6ebd1185ea	[25342] Display editing blocked notification in table (#5542) ... https://community.openproject.com/projects/openproject/work_packages/25342	8 years ago
Oliver Günther	3e16b86009	[25312] Refresh the complete table side on column changes (#5527) ... * [25312] Refresh the complete table side on column changes After the integration of the timeline into the table, it was too costly to refresh the table (and re-initialize the timeline) for everytime the column were changed, so only each row was refreshed. Since the timeline is now separate, we can refresh them invidividually when being careful that this results in now row changes (such as changes to the columns) * Don't fire the timeline unsubscribe subject when refreshing table only [ci skip]	8 years ago