4604 Commits (9515b58f495d4b97734a9a874ed43df230437935)

Author	SHA1	Message	Date
Oliver Günther	8d6b51f6e1	Add spec for edge case that was missed	7 years ago
Oliver Günther	4a8a16f82c	Don't gulp errors in PromiseLike	7 years ago
ulferts	f4763d4311	be robust if no custom style icon exist (#5811) ... Despite a custom style being present, individual image properties (logo, touch_icon, favicon) might not be set. We therefore have to check for those separately. This also refactors the controller to avoid duplication [ci skip]	7 years ago
Markus Kahl	52d87ff81b	Feature/remote repos (#5796) ... * support working locally on remote repositories * refactoring * specs for remote git repos * do not use %x because it's unsafe * fixed spec (create new temp dir for repo) * allow both escaped and unescaped strings * code climate [ci skip]	7 years ago
ulferts	b8355caf51	treats non set cf values same as "No" for boolean cf filtering (#5803) ... Work packages who cannot have the value (not added to project or type) are exempt from this. [ci skip]	7 years ago
ulferts	0c1c8d443a	don't use project as cache key if project is nil (#5806) ... [ci skip]	7 years ago
ulferts	daa1a4d4b7	fixes filtering members by group (#5800) ... additionally fixes: * with "all" selected, all members are shown, not only those being active, invited or registered * with "locked" selected, locked users are now displayed. * the Project#members_principals associations lacked the `references` method which lead to the users table being undefined in the resulting query. In order to achive the bug fixes, the member filtering is now based on the query engine also used for users, queries, work_packages, ... As a lot of the members filters are very similar to user filters (in fact, a lot of the members filter work on the users model), those filters are shared via modules. [ci skip]	7 years ago
Oliver Günther	ab9a9baee7	[26002] Add date as writable when type is milestone (#5804) ... https://community.openproject.com/wp/26002 [ci skip]	7 years ago
Oliver Günther	2b85190d88	[25960] Hide non-writable fields in edit mode (#5791) ... The new edit mode activates all fields it finds - which makes sense. However, non-editable fields should never be created in the first place. https://community.openproject.com/wp/25960 [ci skip]	7 years ago
Oliver Günther	162401d962	[25768] Parse/Output estimated hours with seconds precision ... Was truncated to minutes before. https://community.openproject.com/wp/25768	7 years ago
Wieland Lindenthal	e627081675	Resolve design variables to allow clearer placeholders for input fields	7 years ago
ulferts	b3efc877cd	adapt help text modal style (#5788) ... In order to allow using the keyboard to trigger the close button, the ngDialog close functionality is disabled and a custom close button (the X) is added which is tabbable. The rest is as specified in https://community.openproject.com/projects/openproject/work_packages/25912 Remove close button Change label to "Edit" (EN), "Bearbeiten" (DE) Decrease space between button and bottom. Remove blue border/highlight-effect around text Restore help/info icon left to header text [ci skip]	7 years ago
ulferts	4b76af2521	guard attribute help texts by ee token (#5786) ... The tokens are always queryable via the api but the administration requires an enterprise token to be set [ci skip]	7 years ago
ulferts	4d95cc815f	Feature/guarded relation columns (#5784) ... * refactor case statement * guard relation columns by enterprise token [ci skip]	7 years ago
Jens Ulferts	1d66745a5d	fix additional workflows for assignee and roles	7 years ago
Oliver Günther	d4182ef24e	[25877] Validate the correctness of a CF regexp ... https://community.openproject.com/work_packages/25877	7 years ago
ulferts	e60bd97f35	Fix/bump gems (#5770) ... * bump capybara * downgrade selenium-webdriver to get rid of a multitued of log messages Setting the logging preferences had no effect: https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities#loggingpreferences-json-object * bump sass * bump openproject-token * bump autoprefixer-rails * bump database_cleaner * bump capybara-screenshot * bump aws-sdk * bump timecop * bump timecop * bump parallel_tests * bump faker * bump retriable * fix specs discovered to be broken by now working within Capybara introduced a proxy for `all` and `within` in v2.14 (6356719043 (diff-3944edd1c2651f608ed8a8bec061a734)). This revaled a couple of tests not working as desired. * skip `npm install` for unit specs [ci skip]	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533) ... * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
ulferts	75f501e897	Fix/custom field lacking options (#5768) ... * enforce having at least one custom option for a list cf Removes the hand written nested attributes handling by accept_nested_attributes_for. Removes the arbitrary boundary of having 500 custom options. * i18n for custom option mgmt [ci skip]	7 years ago
Oliver Günther	825a76f0e6	Add separate names to bulk actions	7 years ago
Oliver Günther	d01595d578	Test more explicitly in query_history spec	7 years ago
Oliver Günther	9b6e9a1371	Extract click position mapper for input fields for re-use	7 years ago
Oliver Günther	280c00d50f	Fix more tests	7 years ago
Oliver Günther	db4410dd1f	Remove single-wp edit in context menu	7 years ago
Oliver Günther	3cb9408faf	Fix tests	7 years ago
Oliver Günther	56b67e9f9e	Consolidate existing WorkPackageField and TableWorkPackageField	7 years ago
Oliver Günther	c71d473ce1	Fix form builder failing spec ... Caused by https://github.com/opf/openproject/pull/5765	7 years ago
Oliver Günther	6ff79e0fd8	Fix flickering spec by not requiring explicit ID values ... If certain relation ids already existed, this spec will fail due to ordering of relations. Instead, check for the inserted relation id.	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732) ... * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
Oliver Günther	4a686f16d9	[25490] Add publicity settings for query saving modal (#5737) ... When copying queries, the publicity for other members is copied, but not the query `star` setting (whether it is shown in the project menu or not). This is confusing to the user in two ways: 1. The user does not know whether a query is public or not when copying it 2. It is weird to copy one setting, but not the other This PR suggests to extend the `save as` modal with the visibility settings. To this end, I extracted the visibility form into a separate directive to be re-used from the publish/sharing modal and the save as modal. As://community.openproject.com/projects/openproject/work_packages/25490 [ci skip]	7 years ago
ulferts	4b7e3ff26d	Feature/limit attribute help text visibility (#5749) ... * code prettification * avoid help text for newly added cf requiring restart When using the class method statically, the values are determined upon reading the class. By that, a restart is required before newly added custom fields are added to the list and removed custom fields will still be listed * limit visibility of attribute help texts [ci skip]	7 years ago
Edward Betts	437bbd51bf	correct spelling mistakes (#5748) ... [ci skip]	7 years ago
Oliver Günther	03250f74f2	Fix avatar spec ... [ci skip]	7 years ago
Oliver Günther	9fabaaaf13	Show only attributes from the type attributes and status, project	7 years ago
Oliver Günther	ec6b856686	Add directive to show help text modal	7 years ago
Oliver Günther	57356059af	Create /help_texts endpoint	7 years ago
Oliver Günther	39e11c72dc	Create backend for help text CRUD	7 years ago
Oliver Günther	9e576c9832	Alter specs after removed panel-toggler	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
Oliver Günther	b1f18bd6e9	Extend waiting time for query selector name ... [ci skip]	7 years ago
Oliver Günther	04d48ecec9	Wait longer for filter values to be loaded	7 years ago
Oliver Günther	bcdedaff15	Avoid ordering issues in pg for relations filter	7 years ago
Oliver Günther	aaf9781698	Try to strengthen filter spec	7 years ago
Oliver Günther	eabadccab1	[25704] Allow activities to be filtered for comments-only ... This adds a simply toggler to the activity tab that allows filtering all activities for only those with a comment set. This was on the wish list for a customer but is so trivial that I did this in a quiet minute since I very much appreciate the idea. https://community.openproject.com/work_packages/25704 [ci skip]	7 years ago
ulferts	d1ddd2d5d2	Feature/toggle between hierarchy and group by (#5720) ... * allow toggling between hierarchy and groupBy * fix icon alignment in query settings dropdown * buffer query updates to prevent duplicate backend requests * simplify focus-within delay [ci skip]	7 years ago
ulferts	39bbf082bf	fix author filter for projectless users (#5718) ... As the principals returned by the principals API where limited to those that are members in projects the user can see, users not having any project would not be returned. This is intended in so far as to prevent getting all users easily. But the user herself should be visible in any case. [ci skip]	7 years ago
Oliver Günther	a684dbfa29	Extend spec	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711) ... * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
Oliver Günther	b2b499a7fd	[25686] Use collection_check_box in membership page ... This adds a hidden field for when no checkbox is selected, however it adds the caveat that non-selected values are transmitted as empty values, thus we have to filter them again in the backend.	7 years ago
Oliver Günther	5d84add246	Expire sessions in warden auth scope	7 years ago