openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	766618f623	[24681] Allow users to remove comment by setting it to empty	8 years ago
Oliver Günther	cf7e05a23a	Enforce noImplicitThis	8 years ago
Oliver Günther	e8595ac0a3	TypeScript: Enforce noImplictAny	8 years ago
Henriette Dinger	d0e6e58829	Include review feedback	8 years ago
Henriette Dinger	a8ce127bc5	Set focus	8 years ago
Alex Dik	cfdad8b4ab	Implement WorkPackageResource#updateActivities()	8 years ago
Oliver Günther	117dde0315	Use link reload of wpCacheService for activities	8 years ago
Oliver Günther	96ac99b1f0	Fix missing links to user due to missing resource link The `user` link of an activity was not created as a UserResource, but as a generic HalResource.	8 years ago
Oliver Günther	dc98df84c1	Force reloading of activities on WP update	8 years ago
Oliver Günther	74d2041ed6	Add comment edit spec Functionality was broken and no test failed	8 years ago
Oliver Günther	e8f668fc52	Remove traces of workPackageRefreshRequired	8 years ago
Oliver Günther	f51364fd0a	Codeclimate	8 years ago
Oliver Günther	8021d7fb1a	Move revision, user Activities	8 years ago
Oliver Günther	7c9e032a5f	Remove props usage	8 years ago
Oliver Günther	9cf55f4b20	Add separate UserResource	8 years ago
Oliver Günther	e4f479c1b4	Use WorkPackageResource in panels	8 years ago
Oliver Günther	f35120da65	Add separate preview link for comments without form	8 years ago
Oliver Günther	ed9dfc3be1	Fix preview in description and comment for all modes	9 years ago
Oliver Günther	3ac7490c01	Fix static paths of Frontend PathHelper	9 years ago
Oliver Günther	2ee7465138	Fix tab order on activity tab This restores a hierarchical tab order in the activity tab. Elements are browsed as follows: 1. The activity wrapper, with an `aria-label` set to 'Activity number {number}' 2. The author of that activity 3. (When comment given): The quote and edit button, whose labels were improved	9 years ago
Alex Dik	a3c4bcfbce	Remove save callback	9 years ago
Oliver Günther	d3d6cd60ee	Temporarily store promises until they are resolved The original commit simply stored promises into the cache, which seemed to work in browsers but failed with karma/PhantomJS. I'm not yet certain why that is, but I wanted to get rid of complex objects in sessionStorage anyway, so this commit does: * temporarily store running promises for a given key * cache the resolved data directly	9 years ago
Oliver Günther	64d5b399c5	Experiment with angular-cache One prominent example where we can employ frontend-side caching is the fetching of associated users in activities. For a large number of comments of the same user, that user is retrieved once per activity, which causes a drastic overhead. This commit introduces a simple wrapper around angular-cache to store values in the sessionStorage.	9 years ago
Jens Ulferts	760edcd414	extract activity-link to directive and reuse it for all activities	9 years ago
Jens Ulferts	233ce258f9	fix activity anchors * provide an ID to have a valid anchor target * remove sref work araund as we are always targeting the full screen view	9 years ago
Oliver Günther	e88deb8556	Fix errors when editing comments This addressed an invalid event handler that causes a TypeError within jQuery and corrects a scoping error that leads to comments being updated with their original/unchanged texts. Relevant work package: https://community.openproject.org/work_packages/21578	9 years ago
Oliver Günther	de96916dac	Minor corrections This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	d1a1020097	Workaround for focus event on user activity It seems that the user activity doesn't correctly handle blur events. I do not know why, but to provide a workaround, I've forced setting the focus for the quote and edit buttons.	9 years ago
Oliver Günther	7cd7697fab	Replace autogrow with angular-elastic angular-elastic provides us with an option to always insert an additional newline to provide smoother animations. This also changes animations to CSS rather than `jQuery.animate`.	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Henriette Dinger	01d47ea851	Editable comment field This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago
Oliver Günther	d9d784e5cf	Move activities out of tabs This moves activity templates and directives in their own namespaces / module. Also adds a single activity entry for overview and activity, which itself selects the correct directive for the given activity object.	9 years ago
Jan Sandbrink	a76faaf1a2	show initial journal in activity tab	9 years ago
Jan Sandbrink	2c19f97345	centralize knowledge of WP autocomplete url - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	9 years ago
Jan Sandbrink	cc844c1068	centralize knowledge of WP autocomplete url - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	10 years ago
Jens Ulferts	afeb118130	fix quoting of comments on wp pane	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Hagen Schink	4a46b7a5e1	Trust html received from the back-end	10 years ago
Alex Coles	6ec5ca58ed	Move Angular app under frontend/app This mass rename has been brought forward to work-around an apparent naming collision when running Karma tests. ERROR [karma]: [Error: Path is a file /_js/app/assets/javascripts/angular] Error: Path is a file /_js/app/assets/javascripts/angular Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	7506b738a5	Add autocompletion to user activity	10 years ago
Alex Coles	3abdbac4c9	Fix semicolons in Angular app to placate JSHint Most final semicolons missing after conversion to CommonJS modules (see `5f6696d5`). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	47d2d62f71	Remove various implicit globals in Angular app This patch does not remove globals used by timelines model: removing these accidental globals would require addressing a number of circular dependencies, e.g. between `Timeline` and `Project` objects. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5f6696d5db	Restructure Angular app into CommonJS modules Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Hagen Schink	ea3b2b008c	Always show comment actions in accessiblity mode	10 years ago
Richard	d39718b767	Manually scroll to activity comment if there is an anchor in the URL	10 years ago
Richard	2c31522705	Remove cancel button from new comment in wp details.	10 years ago

11 Commits (95cae347ed87e87b339414982f37a585cd3df3ab)