54 Commits (970e7ec6ee1a5063274344b32aa6df4b485d0b43)

Author	SHA1	Message	Date
Markus Kahl	63957c55f7	more flexible prefix	10 years ago
Markus Kahl	ea52b14756	don't hardcode ENV as source for config override	10 years ago
Markus Kahl	661d89f5fe	allow nested config env override and addition of new values	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Martin Linkhorst	a2754921dd	make Hound happy (and Markus)	10 years ago
Martin Linkhorst	c43f84ad1b	#after_login can now receive a context variable (usually the controller)	10 years ago
kgalli	3e2cdf1ca7	Add quick fix for load_config_from_file ... The whole test should be refactored. I suggest using a real life example of the configuration.yml instead of stubbing its content.	10 years ago
Alex Coles	879fcd49f6	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.6 with the following command: transpec -f * 66 conversions from: it { should ... } to: it { is_expected.to ... } * 53 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 20 conversions from: == expected to: eq(expected) * 19 conversions from: obj.should to: expect(obj).to * 7 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 7 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 7 conversions from: its(:attr) { } to: describe '#attr' do subject { super().attr }; it { } end * 5 conversions from: obj.should_not to: expect(obj).not_to * 4 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 3 conversions from: be_true to: be_truthy * 2 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 2 conversions from: its([:key]) { } to: describe '[:key]' do subject { super()[:key] }; it { } end * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: be_false to: be_falsey * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 1 conversion from: it { should_not ... } to: it { is_expected.not_to ... } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Hagen Schink	5aa71b8a6b	Fix API representer extension	10 years ago
Alex Coles	1633e0f419	[wip] Add .extend_api_response to ActsAsOpEngine ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1ea5637b8f	Add skeleton spec for OP::Plugins::ActsAsOpEngine ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Michael Frister	ee31c8de7d	Omniauth: Add after_login, remove on_success ... After a successfull login seems to be a much clearer description of when the callback will be executed than "on successful authorization". E.g. it's not clear whether ending up on the registration page also indicates successful authorization (which it does in the OmniAuth sense, but not in the OpenProject sense). The after login callback is called each time a user is logged in, no matter whether that happens via regular Omniauth login or after completing the registration process and being automatically logged in (when automated account activation is enabled).	10 years ago
Markus Kahl	c798ebe878	pass auth_hash to #on_success. Call it upon bumpy registration too.	10 years ago
Markus Kahl	41603b0f43	on_success callback for Authorization	10 years ago
Hagen Schink	f81c59d194	Add specs	10 years ago
Alex Coles	f99450b181	Rename TextFormatting#textilizable to #format_text ... * deprecate_alias textilizable, textilize In the future, other markup types will be supported. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	d0f4cbfb8a	Make UrlHelpers soft-dependencies of TextFormatting ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e037a18298	Fix constant name in (empty) ObjectLinking spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	0ca679ed60	Prune unnecessary includes in TextFormatting spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	d13eba74b9	[wip] Extract text formatting helpers into Modules ... Extract a number of ApplicationHelper methods (namely `textilizable` and its dependencies) into OpenProject::TextFormatting/ObjectLinking modules. This should enable this functionality to be more easily used outside of the Rails controller/view context – for instance, from Grape-based API code. Also updates WorkPackageModel to include TextFormatting, rather than ApplicationHelper. Note: Only RSpecs have been updated thus far. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	efe24e1049	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 100 conversions from: it { should ... } to: it { is_expected.to ... } * 17 conversions from: expect(collection).to have(n).items to: expect(collection.size).to eq(n) * 10 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 9 conversions from: be_true to: be_truthy * 9 conversions from: expect(obj).to have(n).errors_on(...) to: expect(obj.errors_on(...).size).to eq(n) * 8 conversions from: obj.should to: expect(obj).to * 4 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 2 conversions from: be_false to: be_falsey * 2 conversions from: expect(obj).to have(n).error_on(...) to: expect(obj.error_on(...).size).to eq(n) * 2 conversions from: pending 'is an example' { } to: skip 'is an example' { } * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: expect(collection).to have_at_least(n).items to: expect(collection.size).to be >= n * 1 conversion from: obj.unstub(:message) to: allow(obj).to receive(:message).and_call_original * 1 conversion from: pending to: skip	11 years ago
Martin Linkhorst	fb096b0c86	infer content type from contents of file instead of its file extension ... * defaults to application/binary as its more secure than octet-stream * set nosniff header to instruct browsers not to guess content type	11 years ago
Alex Coles	5cdc438c52	Convert specs to RSpec 2.99.0.beta2 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 402 conversions from: it { should ... } to: it { is_expected.to ... } * 67 conversions from: be_true to: be_truthy * 55 conversions from: be_false to: be_falsey * 35 conversions from: it { should_not ... } to: it { is_expected.not_to ... } * 20 conversions from: == expected to: eq(expected) * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: =~ /pattern/ to: match(/pattern/) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 1 conversion from: after { example } to: after { |example| example } * 1 conversion from: pending to: skip	11 years ago
Martin Linkhorst	10d694f6e9	push down callback block check into OpenProject::Notifications	11 years ago
Alex Coles	ed1f4fbebb	Fix args passed to image_tag in ViewHelpers spec ... Deprecated negative raise_error expectations were removed by Transpec in previous commit 26ade602: this example was previously masking an ArgumentError. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Alex Coles	4bf96157d5	Tidy up ThemeFinder asset precompilation specs ... Handle code dependent on Rails config more elegantly. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	01cd4bd924	Fix ThemeFinder asset precompilation specs ... Broken with fixes/changes introduced in 265c30a4. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Michael Frister	6c284e05bd	Add OpenProject::Notifications as publish/subscribe mechanism ... This allows code to register for certain events, we might later use this later e.g. for sending mails on specific events like WorkPackage updates.	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Philipp Tessenow	4231cfe43d	fix toggling tests	11 years ago
Philipp Tessenow	0231836891	add specs for user themes	11 years ago
Philipp Tessenow	a9dbaf862c	users may specify a theme in their preferences	11 years ago
Philipp Tessenow	ddf24afacb	documented Theme.new_theme and changed it to take a configuration block	11 years ago
Michael Frister	a8d0fb73ab	Fix compatibility with old mail configuration ... Previously, the compatibility code wrongly assumed that delivery_method was always set when using the old mail configuration format, although it has the default value :smtp.	11 years ago
Michael Frister	c24a2803bf	Make Configuration spec independent of YAML files, test env vars	11 years ago
Michael Frister	0f1a96fbe3	Add configuration spec	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Sebastian Schuster	ee6c9f792e	Added missing copyright notice for various files	11 years ago
Martin Linkhorst	d7903ef928	this makes it easier to create an initial working theme. quick fix to be in sync with the blog post.	11 years ago
Martin Linkhorst	0f6e32cfd7	let's call the default theme 'OpenProject'. alternatively one could have changed the class DefaultTheme to OpenProjectTheme and let that be the default theme.	11 years ago
Martin Linkhorst	d65add5df0	refactor themes backend ... * extract theme finding code from the Theme class into a ThemeFinder module * omit a trailing 'Theme' in the class name for default identifier and name attributes of themes * remove the default? method * do not rely on AS::DescendantsTracker anymore, although it was nice	12 years ago
Martin Linkhorst	d7fe5cc8f2	move themes code into OpenProject's library	12 years ago
Michael Frister	f884fbf4c2	Add option to prevent former passwords from being reused ... Squashed from single commits: * Add checks to prevent former passwords from being reused * Make number of banned former passwords configurable Also group settings into fieldsets on the authentication settings page. * Update TestUnit fixtures with UserPasswords * Add migration for creating user passwords * Fix new user password not being immediately used * Add cuke for ban of former passwords * Fix admin info showing whether admin password was changed * Fix password check for user without password and fix tests * Fix password complexity feature after translation changes * Adapt my_controller_spec to UserPasswords * Order UserPasswords by id created_at is not unique within one second, this breaks MySQL tests. id is guaranteed to be unique and monotonically increasing on MySQL and on Postgres(at least as long cache is not set for the sequence). * Rename secure_compare to secure_equals? * Immediately use reduced number of banned former passwords Only check number of former passwords as defined in settings. The number of stored passwords per user is only reduced when a user updates the password. * Add missing copyright notices * Update changelog	12 years ago
Christian Ratz	a2e69908e1	Changeable footer ... - adds OpenProject::Footer object - added small padding right for footer	12 years ago
Michael Frister	089db98541	Improve password complexity requirements ... Add a new Passwords module, which evaluates and generates passwords. Adapt User to use this module. In addition to checking the length, the module verifies that a password contains a certain number of character classes like uppercase/lowercase. These classes can be configured in the authentication settings. Also increase the default minimum password length from 4 to 10.	12 years ago