2633 Commits (982439e52bf4c3b8bf7b43049d8878242493aa1d)

Author	SHA1	Message	Date
Alex Coles	67c84961a0	Migrate model has_many conditions to lambda ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ecfa05fad9	Rename Project.public scope to public_projects ... Avoid collision with `public` class method. As of Rails 4.1, `public` is explicitly black-listed as a scope name: https://github.com/rails/rails/pull/14582	9 years ago
Alex Coles	2c741c4b7f	Prune dead scope from Project ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5557f58e80	Migrate model scopes to use lambda/block ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0f9240037a	Fix TimeEntry cleanup on work package bulk delete ... Fix `WorkPackage.cleanup_associated_before_destructing_if_required` semantics so that the first argument can either be an individual `WorkPackage` (as the spec originally expected) or a collection (as in actual usages). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	16720d2d7c	Rework DeletedUser.first to avoid stack overflow ... `.find_or_create_by` will call `.first`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	9f4ebc04a5	fix moving of WPs without specifying a status ... attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	9 years ago
Jan Sandbrink	96d0cf9462	fix moving of WPs without specifying a status ... attributes without a value are actually represented by empty strings. Thus only take the status_id if it is :present? (the inverse of :blank?)	10 years ago
Alex Coles	8edff9831c	Pull up constants, associations into Principal ... Constants were previously misplaced in `User` subclass (as noted in TODO). Associations were previously moved into subclass to work- around an apparent STI bug. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	7ae6499d79	Remove unloadable from ReportedProjectStatus ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c80a792496	Use 1.9+ Hash syntax in Principal ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	507bfc12bc	Prune unnecessary option on CustomField translates ... `fallbacks_for_empty_translations: false` is default. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	dbb751f96a	Remove commented Type.all override ... Commented in 53ecf98b. This was not only broken, but also redundant, given that there is a default scope defined for `Type`. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Oliver Günther	cb123c83be	Fix and specs for missing plus in login attribute ... Fixes the merge issue from 105934a5f9	10 years ago
Alex Coles	40ae6c6524	[wip] Disable ProjectType has_many validation ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	9a9d6aca2c	ensure correct file size errors are displayed	10 years ago
Jan Sandbrink	4a69d2505a	replace ternaries returning booleans ... - foo ? true : false was replaced where foo already was bool - foo ? true : false was kept, when the ternary did a bool conversion - foo ? false : true was replaced by either negation or replacing == with != Note: I intentionally left one occurence that is fixed in another running PR and would cause a conflict	10 years ago
Alex Coles	0c56b72d2a	Work-around Project nested set errors on PG ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Toshi MARUYAMA	1b3628b60c	remove unneeded to_a	10 years ago
Alex Coles	55a2207631	Replace GroupUser join model w/ habtm association ... Active Record 4.x does not generate correct DELETE SQL statements when deleting groups for a given `User` (the `GroupUser` join model does not have a primary key). Callbacks (e.g. `after_remove`) *are* invoked on `has_and_belongs_to_many` associations. This effectively reverts 6c5239c4e2 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e7e4914d22	Simplify Array find in Project::Copy ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	abf4a011f0	Fix copying of versions on Project copy ... Adds a more robust solution for copying closed versions and associating with copied work packages (see original patch 10ec20a8). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	8f7d8ef573	avoid unnecessary work	10 years ago
Markus Kahl	2b8848dc8b	don't use deprecated finder	10 years ago
Markus Kahl	6cb6953a07	basic auth for api v3 (WIP)	10 years ago
Azure7111	f493fbb036	Workaround for the new ``.all`` ... ``.all`` used to return an array, which this code expects.	10 years ago
Alex Coles	d060e654a5	Use vanilla Rails validations for CustomField#name ... Globalize should support regular Rails validations. Additionally `validate_name` was no longer working as expected, possibly due to changes in `CustomField::Translation` lifecycle. * Do not test translation implementation details in CustomFieldController spec. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	f1a93e1cf3	this is why I hate comments	10 years ago
Jan Sandbrink	c075a7b401	only allow simple space in login ... also add specs to verify that	10 years ago
TribesTom	2910137c03	Added user changement	10 years ago
Alexander Bach	55f5f33456	Changed code readability	10 years ago
Alexander Bach	942f39876f	Removed hard coded id column for pdf export	10 years ago
Alexander Bach	404a5b42e6	Remove hard coded id column for csv export	10 years ago
Jan Sandbrink	88107362b1	enhance PSQL compatibility of cast_value ... In PSQL a valid boolean can also be represented using other value than '0' and '1' This led to cast_value sometimes returning false, even though it was supposed to return true...	10 years ago
Jan Sandbrink	eb9ef1f2b1	replace occurences of cast_value with typed_value	10 years ago
Alex Coles	54ff7af6e7	Add/update Copyright headers in app code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	60ca779111	make transform to boolean more database resistant ... PostgreSQL has many representations for bool: http://www.postgresql.org/docs/9.1/static/datatype-boolean.html	10 years ago
Alex Coles	ef4285bc0c	Kill deprecated Setting.*_cache methods ... Deprecated in version 2.4.0 (2011). See: d76fd8e4. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	9f692f6bf1	Use the empty string for absent descriptions	10 years ago
Jan Sandbrink	f9b242884d	let custom values accept their native type ... - add specs for strategies to parse their typed representation as valid (instead of only their stringly typed counterpart) - add specs to int and float strategy regarding accepting eachother - fix int custom values accepting float inputs (which would work, but omit the fractional part) - fix date custom values not accepting on Date	10 years ago
Alexander Bach	2d2f18b2c5	Remove unused code	10 years ago
Alexander Bach	ee31bc9762	Increased code readability	10 years ago
Alexander Bach	35f9ec6db8	Consider all of the time entries visible to the user	10 years ago
Jan Sandbrink	2bf38a622f	create journal when CF toggles between false + nil ... the changed? method of the JournalManager did handle false values not correctly and considered them blank. However, a boolean CF that is not required can have (technically) three states: - true - false - nil Thus we can't consider nil and false as the same case	10 years ago
Jan Sandbrink	5f19189e71	create CF journal for CF set to false ... This is only an issue when the CustomValue.value is actually false. Legacy code uses stringly typing and thus has values like "1" and "0"	10 years ago
Jan Sandbrink	f31dd80acb	add explicit author to more mails ... neccessary for correct self-mail detection	10 years ago
Jan Sandbrink	93d20011e5	fix more TestUnit tests ... - also adding author to news_added	10 years ago