openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	8408f86fef	Improve usage of I18n in model specs This will avoid loading I18n translations in single-use cases where it would not be loaded anyway	6 years ago
Jens Ulferts	994c2d469c	avoid adding non writeable filters multiple times When the create_class method is called on WorkPackagePayloadRepresenter, a subclass of the class is created that includes the relevant custom fields. That class gets the PayloadRepresenter module included. The payload representer adds a render_filter to the attributes to avoid rendering unwriteable attributes. But when adding the filter, it is not added to an instance of the attribute in the subclass (WorkPackagePayloadRepresenter + CustomFields)but rather to the one in the superclass (WorkPackagePayloadRepresenter). The filter list instance is shared by all subclasses. That sideeffect is not dangerous per se as we want all WorkPackagePayloadRepresenters to have the filter. But as we have one instance of an array, adding to that array will lead to having the filter multiple times which will then all have to be evaluated on every rendering pass. By checking if the filter is already included before adding it, we can avoid this behaviour. The better fix would be to rework the way custom fields are handled in the representers. This could be done by having one representer for the static attributes and one for the dynamic custom fields. Those two representers could be rendered/parsed independently and the results could then be merged. This approach however takes considerably more time.	6 years ago
Jens Ulferts	c1853a5cdd	fix expected namespace for groups on assignee and responsible property	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
Oliver Günther	fdfb41b327	[26069] Allow passing of me-value link for principal filters again The 'me' value is currently automatically normalized to the current user, making it impossible to store queries that reference the current user whenever accessing the query as before.	7 years ago
ulferts	9c8f7f3ca1	read operations for time_entries via api v3 (#5776 ) * read operations for time_entries via api v3 Introduces the endpoints: * GET /api/v3/time_entries * GET /api/v3/time_entries/:id * GET /api/v3/time_entries/activities/:id The index action for time entries can be queried by the following filters: * project_id * user_id * work_package_id The implementation is exposing the database structure mostly one to one with the exception of some renaming and the hiding of the activities' complexity, where only the activity used systemwide is referenced regardless of whether a project specific override exists or not. * allow custom values for time entries [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732 ) * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	7ad39ec35f	Fix/cache query representers (#5711 ) * cache various query representers json representation * sort by * columns * group by * filter instance schemas * fix custom option path [ci skip]	7 years ago
ulferts	36ab671d27	log stacktrace on api error (#5450 ) [ci skip]	8 years ago
Markus Kahl	9e79d02d8f	queries create and create form api endpoints	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Jens Ulferts	c4bef2247d	adding filter instance schemas	8 years ago
Oliver Günther	65e24558a3	Log grape errors when rescuing from them	8 years ago
Jens Ulferts	80c242dd53	embed query results in query representer This is only done when the representer is not embedded itself, e.g. when it is part of a collection.	8 years ago
Jens Ulferts	97bff16dcc	fix filtering by subprojectId	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	1bb3631bd6	fix estimated time filters Because estimatedTime is turned to estimatated_hours by the PropertyNameConverter, checking whether work package responds to estimated_hours.pluralize only to return estimated_hours_id does not make sense. That behaviour was introduced to cope with the watcher attribute which should have been turned into watcher_ids as watchers is a has_many relations. But when that behaviour was fixed to work correctly with estimated_hours again, so that the name converter returns estimated_hours (no foreign key) and watcher_ids (foreign key) the watcher bug had to be fixed all over again. For turning work package filter parameters from the external to the internal representation, the v3 now makes use of the same method, as employed by the experimental api	8 years ago
Markus Kahl	dad0e5313f	support both e.g. `watcher` and `watcher_id` the previous fix only made `watcher` work, not the latter	8 years ago
Markus Kahl	6459d04706	map watcher to watcher_id to fix filter	8 years ago
Oliver Günther	9dc8d09516	Add CreateUser API endpoint and spec	8 years ago
Markus Kahl	7f6d74a88e	basic crud	8 years ago
Jens Ulferts	1a63857565	use consistent naming for columns/filters across apiv3 and experimental	9 years ago
Jan Sandbrink	88ed4d2df9	Promote ::create to a common interface method This one is already used by the representers that require a custom field injector. However, by having a separate method this also means collections (or the new DecoratorFactory) need to take care and call the ::create method instead of ::new. I therefore made create the default interface to create representers, which is now used by Factories and Collections. Note: I did not yet change all representer instantiations to ::create. I hope this will happen gradually.	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	0a73e6bac4	convert attribute names in queries API This should make the API more consistent again, accepting and producing the same attribute names on all endpoints	9 years ago
Jan Sandbrink	986be45dde	allow to calculate property sums	9 years ago
Jan Sandbrink	bc30b28558	extract attribute name conversion into extra class - consider special renaming rules for well known attribute names -> currently covering wp attributes and createdAt, updatedAt	9 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alexander Bach	e14256addf	Add condition to else	10 years ago
Alexander Bach	542422c0ca	Accept projects as render context	10 years ago
Alexander Bach	379e131c5b	Add condition to else	10 years ago
Alexander Bach	98f873a3b8	Accept projects as render context	10 years ago
Jan Sandbrink	725fb586a0	style resource link parser	10 years ago
Jan Sandbrink	1e136a15e0	return ResourceTypeMismatch for wrong resources - this is according to new specification changes - I have no clue why the initial author did this "wrap into a validation error" business	10 years ago
Markus Kahl	c1e597c186	fixed response headers (content type, realm)	10 years ago
Markus Kahl	45b4045255	fixed error_response helper	10 years ago
Markus Kahl	5b05bfec90	DRYing	10 years ago
Jan Sandbrink	900b2a4c45	Backporting APIv3 categories to OP 4.0 Backport was neccessary to implement missing categories filter without adding more technical debt. These changes will be merged into 4.1 and following branches and vanish in that merge (merge-strategy "ours") YOU SHOULD NOT SEE ANY CONTENTS FROM THIS COMMIT ANYWHERE AFTER 4.0.x! This commit was built from the commits of the GitHub-PR mentioned below, as well as some code dependencies for that. The GitHub-PR was https://github.com/opf/openproject/pull/2505	10 years ago
Jan Sandbrink	b2ca1d6faa	improve style - fewer lines is always better - fewer locals is also always better -> now judge this commit! [ci skip]	10 years ago
Jan Sandbrink	70e7999375	fix parsing of string objects - accept them since format has changed - actually revert the URL escaping that has to be performed	10 years ago
Jan Sandbrink	937fa2fba7	use class side instance variable	10 years ago
Jan Sandbrink	5c3eae32f6	style	10 years ago
Jan Sandbrink	e1948206fa	extract method into ResourceLinkParser - similar code was already used in two different places - now the error message makes sense for both occurences	10 years ago
Jan Sandbrink	03c6fcdf6f	rewrite ResourceLinkParser - use own RegExp instead of borrowing the ones from Grape routes - add specs	10 years ago
Jan Sandbrink	8998f60635	fix patching of empty string objects	10 years ago
Jan Sandbrink	53b9f7738f	enable patching of linked properties	10 years ago
Jan Sandbrink	0f1a7f94e2	generalize the render endpoints	10 years ago

1 2

72 Commits (98a412e2b2b5a46571ec28af3aa1ecc6dd95605d)