openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	5956ede030	[37107] render tabs in component (#9236 ) * Render work package tabs in one component * Move standard tabs into tab service * Move tab-count styles mostly into its own component style * Fix frontend specs * Remove unused texts * Fix routing to split view from button * Fix context menu not opening the tabbed view * Fix watcher tab counter not receiving an rxjs subscription * Fix selector * Fix clicking on relation link to fullscreen * Make WP tabs an instance of scrollable-tabs * Convert the tabs from .tabrow to its own BEM block * Refactor other usages of tabrow into op-tab-row * Fix frontend specs * Make wp modal tabs use scrollable-tabs * Fix disabled tab selectors * Restore scrollability of tabs * Fix import and change detection of graph modal * Fix selector in wp relations spec * Rename tab-count to match component style * Remove narrow style * Fix bem modifier style * Fix styles of scrollable tabs * Fix tab for time entry autocompleter	4 years ago
Philipp Tessenow	2f9d252456	Show github pull requests in the GitHub tab (#9148 ) * WIP: prototype wiring up the API with the angular frontend * little refactorings in namespace and loading logic * frontend styling and polishing * pairing with aleix * Avoid empty pullRequest.githubUser to be displayed * added feature specs, a workaround for a pr-reload-bug in angular, and some readme improvements * Title for partial PRs added * GitActionsMenuComponent tests * Test improvements * GitHubTabComponent tests * TabHeaderComponent tests * TabPrsComponent tests * revert change to karma runner * start styling * i18n in component * avoid container element * git actions menu tests * Github interfaces * PullRequestComponent tests * Comment removed * Typings improvements * Merge fixes * Tests fixes * fix: wp list id links working with tabs * remove partial github pr state A PR might still be incomplete but enough data can be pulled from a github issuee notification to fill in most of the information * avoid duplicate spec * Fix import paths of op-icon Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Philipp Tessenow	a46de71009	[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 ) * Let GitHub integration show changes in a separate tab * added new github integration icons to icon font * add tab content: working tab-header and copy-menu * modernise github_integrations ruby code * refactored some code to be more modern ruby (if wrote most of it 7 years ago and couldn't look at some parts without squinting too much) * make some intended-to-be-private module methods actually private * fixed all rubocop errors in the /modules/github_integration * re-organized tests a little * gave our rubocop.yml some RSpec-related defaults -- happy to discuss these, but I think we can live with these as a good starting point 👆 all without actually (intentionally) changing the behaviour * removed dead angular template code * codeclimate found more things than rubocop :) * removed create-pr-button since we decided against implementing that feature * added missing translations * properly cache the github related part of the wp api * lower case pull requests in translations * fix specs	4 years ago

Author

SHA1

Message

Date

Oliver Günther

5956ede030

[37107] render tabs in component (#9236 )

* Render work package tabs in one component

* Move standard tabs into tab service

* Move tab-count styles mostly into its own component style

* Fix frontend specs

* Remove unused texts

* Fix routing to split view from button

* Fix context menu not opening the tabbed view

* Fix watcher tab counter not receiving an rxjs subscription

* Fix selector

* Fix clicking on relation link to fullscreen

* Make WP tabs an instance of scrollable-tabs

* Convert the tabs from .tabrow to its own BEM block

* Refactor other usages of tabrow into op-tab-row

* Fix frontend specs

* Make wp modal tabs use scrollable-tabs

* Fix disabled tab selectors

* Restore scrollability of tabs

* Fix import and change detection of graph modal

* Fix selector in wp relations spec

* Rename tab-count to match component style

* Remove narrow style

* Fix bem modifier style

* Fix styles of scrollable tabs

* Fix tab for time entry autocompleter

4 years ago

Philipp Tessenow

2f9d252456

Show github pull requests in the GitHub tab (#9148 )

* WIP: prototype wiring up the API with the angular frontend

* little refactorings in namespace and loading logic

* frontend styling and polishing

* pairing with aleix

* Avoid empty pullRequest.githubUser to be displayed

* added feature specs, a workaround for a pr-reload-bug in angular, and some readme improvements

* Title for partial PRs added

* GitActionsMenuComponent tests

* Test improvements

* GitHubTabComponent tests

* TabHeaderComponent tests

* TabPrsComponent tests

* revert change to karma runner

* start styling

* i18n in component

* avoid container element

* git actions menu tests

* Github interfaces

* PullRequestComponent tests

* Comment removed

* Typings improvements

* Merge fixes

* Tests fixes

* fix: wp list id links working with tabs

* remove partial github pr state

A PR might still be incomplete but enough data can be pulled from a github issuee notification to fill in most of the information

* avoid duplicate spec

* Fix import paths of op-icon

Co-authored-by: Aleix Suau <info@macrofonoestudio.es>
Co-authored-by: ulferts <jens.ulferts@googlemail.com>
Co-authored-by: Oliver Günther <mail@oliverguenther.de>

4 years ago

Philipp Tessenow

a46de71009

[#36204 ] Add new GitHub plugin tab enabling users to copy git actions (#9027 )

* Let GitHub integration show changes in a separate tab

* added new github integration icons to icon font
* add tab content:  working tab-header and copy-menu

* modernise github_integrations ruby code

* refactored some code to be more modern ruby (if wrote most of it 7
  years ago and couldn't look at some parts without squinting too much)
* make some intended-to-be-private module methods actually private
* fixed all rubocop errors in the /modules/github_integration
* re-organized tests a little
* gave our rubocop.yml some RSpec-related defaults -- happy to discuss
  these, but I think we can live with these as a good starting point

👆 all without actually (intentionally) changing the behaviour

* removed dead angular template code

* codeclimate found more things than rubocop :)

* removed create-pr-button since we decided against implementing that feature

* added missing translations

* properly cache the github related part of the wp api

* lower case pull requests in translations

* fix specs

4 years ago

3 Commits (98aa7e5a283114c37c8b71ff96d0d365c11d6e39)