openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	51c7b38d07	Merge branch 'release/11.2' into dev	4 years ago
Oliver Günther	e9f1781d2b	Use contracted member services and show only manageable projects in user administration (#9076 ) * Reuse contracted services in memberships controller * Show only manageable projects * Show only manageable projects in select box * Reject empty values in role_ids * Add spec for when user has no manage_members permission * Also handle delete through service * Extend spec for when user has no manage_members permission * Extend Members SetAttributesSpec * Make manageable_Members an instance method and add spec * hide buttons if user is not allowed to use them * Rename manageable_projects to assignable_projects * Build a membership for the contract * Fix url for global_roles to work with update and create methods Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ML-OpenP	4a54e9b41a	Documentation for features introduced with 11.2 (and a few other additions) (#9073 ) * for #33163 * for #36358 and two link changes * for #36257 * explanation of WP export limit settings * for #35815 * docs: cost types can only be locked not deleted * for #35157 * for #32928 * for #36353 * create placeholder user page * for #36228 and #36302 * for #35536 * typo correction * for #36226 (placeholder user profile page) * expand info about group profile page * grammar, content and typo corrections * for #36136 (placeholder users in members module) * for #35571 (PH users in user type dropdowns) * grammar corrected * for #35507 and #35508 (additional gobal roles for managing PH users and user) may need to be revisited after receiving new information * typo and small additions * adding info on who can manage placeholder users * changes to work in review comments	4 years ago
Benjamin Bädorf	bb0cd1b068	Add ctags file to gitignore	4 years ago
ulferts	542239a552	include autogenerated release notes	4 years ago
ulferts	a64c77c1be	avoid test flickering by having more complex password	4 years ago
ulferts	ef2c68516f	Fix/bump gems (#9074 ) * bump grape * bump i18n-js * bump mime-types-data * bump aws-sdk-core * bump aws-sdk-s3 * bump fastimage * bump ffi * bump fog-aws * bump nio4r * bump parallel_tests * bump puma * bump rspec-rails * bump rubocop * bump spreadsheet * bump test-prof * bump webdrivers * bump webmock	4 years ago
ulferts	a9a6eb3ea7	Merge branch 'release/11.2' into dev	4 years ago
Oliver Günther	a023ccf372	[36517] Fix placeholder filter returning query object, not AR collection (#9071 ) We depend on the query for correct sorting by name. https://community.openproject.com/work_packages/36517	4 years ago
Oliver Günther	bbabd8d74f	Merge remote-tracking branch 'origin/release/11.2' into dev	4 years ago
Oliver Günther	3b78be087b	Migrate tslint to eslint (#9064 ) * tslint to eslint migration * Autofix issues * Fix codeclimate path to eslintrc * Extend linter config for use with ng lint * Change prefix to op in angular lints	4 years ago
Oliver Günther	aba54d4a00	Use autoscale approach in 11.2 as well	4 years ago
Oliver Günther	d329db23ff	Finish user invite modal (#9061 ) * Fix some ium stylings * Extend create service to also test with empty names * Add PrincipalLike type to pass around non-created placeholder refs * Add icon-context * Move principal rendering to its own module * Fix emit create new placeholder to principals * Revert op-principal for now * Add memberships form API to properly post * Fix types for returned principals * Move untilDestroyed in role * Filter input if not string in role-search * Pass correct inputs to success component * Return principal after saving membership * Fix small stuff around the ium * Fix the way HalResources are selected and passed * Move principal module to be exported by common * Disable quotemark in tslint until eslint is enabled * Fix image path in success * Adapt modal to run all steps in one within the modal helper component * Several fixes to modals * Fix ium success component styles, * Registration modal y-overflow * Add SMTP parameters to .env.example * Add disabled option to op-option-list, disabled placeholder users for non-ee instances * Add correct ee link to placeholder user option * Fix build * Removed unused sass files * Fix principal search not found indicator, added placeholder add image * Fix enterprise edition url, use dirty instead of touched check * Use backend class names for frontend principal types * Fix duplicate import and principal type usage * Also disable banners if with_ee is present in test * Extend specs for placeholders * Fix disabled attribute * Extend spec WIP * Improved inline-validation styles, fixed more PrincipalType usages * Add group happy path test, fix more PrincipalType usage * Fix a translation * Revert line deletion * Rewrite same spec examples into shared examples * Fix name of shared example * Dont run assets:clean to remove angular assets * Output whether assets are there at all * Fix placeholder path * Revert "Output whether assets are there at all" This reverts commit `42219c2755`. Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
Oliver Günther	95327c7be0	[36304] Load and fall back to english locale due to crowdin bug (#9066 ) https://community.openproject.com/wp/36304	4 years ago
ulferts	f0cf90d7e1	Fix the rails cell not using the content_tag helper of ActionView with escaping (#9067 ) * fixes show links for project members * Properly escapes the name. The cells gem does not escape strings unlike rails * Fixes the case statement for links and includes the link for placeholder users * Fix escaping of content_tag in rails cell and add spec for that Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Wieland Lindenthal	355e9db913	Fix: #36302 I18n strings for placholder user EE banner	4 years ago
Wieland Lindenthal	905017f478	Fix: #36302 I18n strings for placholder user EE banner	4 years ago
ML-OpenP	5c60c8372e	added link to bug reporting docs [ci skip]	4 years ago
ulferts	f0f5c17da7	Merge branch 'release/11.2' into dev	4 years ago
ulferts	ab6d98383b	fix member filter on principals (#9063 ) In case of the `!` operator, other memberships interferred. This was because of the left join leading to result sets that where not of interest. The now used not.in does not have that problem	4 years ago
Markus Kahl	a818687204	print both response headers (including HTTP status) and body using -i	4 years ago
Markus Kahl	aa5acbe085	output API response	4 years ago
Markus Kahl	a157fb0ee1	use workflow filename as ID to make sure we get it right	4 years ago
Markus Kahl	41c7bb9dcf	fixed links	4 years ago
Markus Kahl	4f0ad2a7be	Pointer on how to use the plugin in production	4 years ago
Oliver Günther	c4c4cc9042	Bump Angular to 11.2 (#9054 ) * Bump Angular to 11.2 * Restructure package.json dependencies * Fix absolute templateURLs that are no longer supported * Fix promise types after removed promises-a-plus pkg * Revert karma bump as its breaking tests	4 years ago
Oliver Günther	b9b249aa2f	Merge branch 'release/11.2' into dev	4 years ago
Oliver Günther	1fc3834eca	Merge remote-tracking branch 'origin/release/11.1' into release/11.2	4 years ago
Edoardo Operti	b2a4965f68	Typo correction in version verification (#9051 ) * Typo correction in version verification Just changed the npm --version command to the one I suppose is more correct (check node version). * Bump node version to 14.16.0 in README	4 years ago
ulferts	247c8e913e	fix row rerendering with limited permissions If the user has limited permission, e.g. no right to reorder, the first row, used for sorting, has had a different class set. When rerendering that row, the class set is expected but not found. The patch * Adds the expected classes * Increases the robustness whenever the expectation is not met in case other places make the same mistake of not adding the necessary classes	4 years ago
Aleix Suau	0358f89abf	Download pdf on a new tab (#9004 )	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	1dabcbc566	fix templated check on boolean filters The check for templated failed for boolean filters as true was returned where a string was expected	4 years ago
Wieland Lindenthal	c4c2149d98	Fix: 36299 -- Allow to modify login when global permission :manage_users present (#9026 ) * Refactoring: Create shared examples for user contracts * Users::UpdateContract spec added * Add spec for updating the login of a user * Add spec for permitted params when global permission to :manage_user * Remove spec for :login updates for user UpdateContractSpec The writability of the login attribute is not part of the contract (yet). * Use user contract for checking writability of user attributes * Fixing user contract specs. * use persisted user in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	45b83c36d9	Merge branch 'release/11.2' into dev	4 years ago
Oliver Günther	935cd02d33	[36294] Show authentication header only when any partial matches (#9044 ) * [36294] Show authentication header only when any partial matches * use collection_select for collection Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	0fa8b4a77b	Forward CSP extensions to login controller (#9047 ) * Forward CSP extensions to login controller * Extend spec for double auth code * stabilize spec On my machine, since I have an s3 bucket configured, the spec failed Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	65575d44f1	[36415] Add public filter to projects list (#9057 ) https://community.openproject.com/wp/36415	4 years ago
Cyril Rohr	9fe8f7b28a	Fix instructions to setup Let's Encrypt with newer certbot client (#9056 )	4 years ago
Cyril Rohr	6245eb39ba	Fix instructions to setup Let's Encrypt with newer certbot client (#9056 )	4 years ago
Oliver Günther	ea29493ce7	[36353] Restrict possible select options in cost entries to users (#9053 ) https://community.openproject.com/wp/36353	4 years ago
RobinWagner	2f0666e068	Specify MS Edge version (Chromium-based) [ci skip]	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977 ) * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
Markus Kahl	47a752d889	make sure to use latest patch level of ruby base image (#9052 ) * make sure to use latest patch level of ruby base image * how to handle outdated images	4 years ago
Markus Kahl	487811aa86	fix custom field validation on unpersisted record (#9050 ) * fix custom field validation on unpersisted record For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail * adapt spec to have the members created in setup Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Markus Kahl	eebf873eb1	disable direct uploads when use_iam_profile is true (#9049 )	4 years ago
ulferts	bc238d62be	fix custom field validation on unpersisted record (#9048 ) For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail	4 years ago
ML-OpenP	d94241862b	words corrected to lowercase [ci skip]	4 years ago
ML-OpenP	08ff4ccace	removed section "attribute help texts" as it has been moved before [ci skip]	4 years ago
ML-OpenP	af89682516	Many words corrected to lower case [ci skip]	4 years ago

... 7 8 9 10 11 ...

59066 Commits (98aa7e5a283114c37c8b71ff96d0d365c11d6e39) All Branches Search

59066 Commits (98aa7e5a283114c37c8b71ff96d0d365c11d6e39)

All Branches