openproject

Commit Graph

Author	SHA1	Message	Date
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	2 years ago
Christophe Bliard	a33524ef6d	remove ruby magic comment for utf-8 ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless	3 years ago
Christophe Bliard	bc8d423ec2	update copyright information for 2022	3 years ago
Oliver Günther	8984b989c6	Add include_gon to base template This will avoid needing to identify in templates whether gon is already present, and will ensure it can be used.	3 years ago
Henriette Darge	46f439613d	Add I18n strings for sidebar and fix last usages of new angular layout	3 years ago
Benjamin Bädorf	76c2eb35fa	Add page title, add correct table cell titles	3 years ago
ulferts	1cca351d31	add separate menu for reminder mails	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	0b71e27de8	Don't set flash to nil, delete instead Otherwise, this shows an empty message	3 years ago
Henriette Darge	2282f0ef2b	Show a custom sidebar on the notifications page. (Currently this is just the WP query sidebar as a placeholder. This will be replaced later.)	3 years ago
Oliver Günther	9636a08988	[26688] In-app notifications (#9399 ) * Add bell icon to icon font * Add in app notification in top menu * Add fullscreen modal * Add notification modal and items * Style items * Toggle details of item * Mark all read * Add no results box * wip specification for event api * Add events table, query and index * Send out events from WP notification mailer job There we have the recipients present * Add cleanup job for older events with a setting * Hide bell notification when not logged * Add specs for events API index/show * Fix setting yml key * remove pry in event creation * Fix before hook in events API to after_validation * Fix polymorphic association raising exception for aggregated journals * Fix typo in read_ian * Fix yml entry for mentioned * Add read/unread post actions to event API and add specs * Wire up API to frontend * Fix order on events * Switch to unread in notification * Add event query * rename WPEventService * route wp mail sending over events * rename spec methods * author becomes watcher * correct message call signature * rename events to notifications * renname parameter to reflect notification nature * create author watcher for existing work packages * Merge unreadCount from store * Take a stab at polymorphic representers * Fix link generation in polymorphic resources For journals, no title is being generated however * Fix frontend model for context * Use timer for polling * add notification_setting data layer * Fix show resource spec * Fix duplicate class in notification bell item * Add minimal feature spec for notification * API for notification settings * Persist notifications * adapt work package notification creation to notification settings * extract notified_on_all * consolidate wp#recipients * concentrate wp notification in journal service * simplify methods * Remove unused patch endpoint * Add specs for rendering and parsing notification settings * Contract spec * Update service spec * adapt specs * Angular notifications frontend commit `e29dced646` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 17:34:50 2021 +0200 Create Akita store and query for notification settings commit `1a45c26c1a` Author: Wieland Lindenthal <w.lindenthal@forkmerge.com> Date: Mon Jun 21 11:09:25 2021 +0200 Remove tabs from notificaition settings page commit `0ea21e90c1` Author: Oliver Günther <mail@oliverguenther.de> Date: Sun Jun 20 21:55:48 2021 +0200 WIP in app settings * migrate notification data * add project visible filter to project query * Add inline-create and table display grouped by project * Add notifications under admin/users * Remove notifications partial * Rename notififcations store to user preferences store * Add setting for self_notified and hook that up to the backend * Add aria-label to table checkboxes * Restyle table and toolbar * replace remains of mail_notifications attribute * initialize notification settings for new user * adapt my_preferences references * reenable no self notified for documents * adapt specs * Avoid has_many :notifcation_settings Rails magically autosaves the user's preferences when the user gets saved, which somehow also tries to save the notfifications even when unchanged. This breaks some specs such as the avatar upload spec. As we can't update the assocation through rails anyway, just delegate to the user for reading instead. * Restore update method of notification settings * Restore update spec * fix spec syntax * lint scss * linting * Fix content_tag for bell icon * Add feature specs for notification settings * Disable ContentTag cop * use visible filter to get projects for notification The visible filter will reduce the project list down to the set of projects visible to the user provided as a parameter. This includes public projects. * test for actual mail sending * adapt me resource path this.apiV3Service.users.me changed its type in `0d6c0b6bc7` * Implement changed migration * Linting * Add actor to notification representer * Fix factory creating a duplicate WP journal * Add work packages loading and journal details to notification entry component * IAN basic facets, keep and expanded states. * Fix notification bell spec * Render body separately and add auto updating relative time * Add fixedTime title * Add actor to notification entry * Fix clicking links on work package and project * Tiny styling changes on entry row * Disable count in notification if larger than 99 (wont fit) * Introduce virtual scrolling to entry table * allow delaying & prevent mail sending if ain read Introduces a setting to delay mail sending after a journal aggregation time has expired. That way, users can confirm a notification in app. If they do before the delay expires, no mail is sent out additionally for that user. * consolidate notifications (in&out) into shared admin menu Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>	3 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	5968c0b18a	Fix/replace custom i18n function (#8681 ) * replace custom i18n function calls * remove custom i18n method	4 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	d02b0db93c	include module required for content_tag rendering	5 years ago
Oliver Günther	7bacd8b814	Fix tag_helper in my controller [ci skip]	5 years ago
Oliver Günther	fdfbbabda0	Fix non-html value for rss tokens	5 years ago
Oliver Günther	4f95568e44	Show error message when account cannot be updated	5 years ago
Jens Ulferts	6e315c45fe	have dedicated controller in my_page engine	6 years ago
Oliver Günther	451331a910	Invalidate session,s extract passwords flow into services	6 years ago
Jens Ulferts	74493eb5d3	introduce grid_blocks	6 years ago
Oliver Günther	8a783d2b1c	Use flash info	6 years ago
Inga Mai	2d0d2feccf	[27828] Feature: Query menu in sidenav (#6429 ) * in main menu add gantt as extra work package child item * Satisfy spec and code climate * Add gantt chart icon behin default gantt query name. * WIP Query menu in left sidebar * Shift query dropdown in left sidenav * Reload menu or load query on click from every project location * WIP set correct label for default queries * Query menu listens on all changes of queries (delete, create, rename, toggle starred) and updates immediatly * WIP: Inline edit, field validation * Inline Edit validation and comfirm * Inline edit: validation of duplicate name * Set default columns and sorting for static queries * Codeclimate issues fixed * WIP Inline edit validation not working perfectly in all error states * Inline edit working * Autocompleter hover disabled and hovering over categories fixed * Category hover and toggle fixed; tested in Chrome, Firefox and Opera * Placeholder cut off fixed and text wrap added * English and german wording adjusted * Styles of inline edit and menu adjusted; matching wiki page styles * prevent menus to be displayed to often * application menu only displayed on work package * specify using no_menu layout more often * adapt tests to altered production implementation * Hamburger icon only in project; on global wp page: default queries shown correctly and summary removed * searching for undefined leads to error * Accessible click fixed (listen on escape) * Gantt in top menu deleted (gantt chart is part of default queries on wp page) * load menu on wp summary page * reduce times queries are loaded * lowercase on second word * remove menu from search and home * Styles fixed (category toggle and correct highlighting) * reflect static query in url * fix autocomplete handling in specs * Open all global menus on default and hide hamburger icon on global pages; Rebuild changes that have been ovrwritten after merge" * Correct highlighting of default queries after reload * Replace summary cuke with spec * WIP * Clear up selectors * Avoid actively setting promises and instead use $state.go to load links [ci skip] * Make editable title component a little simpler We can reuse the component I built for the wiki, that wasn't present in the frontend beforehand. * Fix moving through the menu and selecting items [ci skip] * Add save button to query title when query changed * Improve static names lookup by comparing query_props * Adapt and fix specs * Allow inner scrolling of wp query results Also, style the webkit scrollbar to make it pretty where supported * Allow renaming the query through setting menu, but simply focus on field [ci skip]	6 years ago
Oliver Günther	f6c6db9c7e	[28146] Fix rendering invalid block on incorrect value [ci skip] https://community.openproject.com/wp/28146	6 years ago
Oliver Günther	d3aa6d555b	[28103] Fix reorder my page blocks Got lost in the CSP fixes and the URL is no longer passed to the frontend. Instead, use gon while we still have my/page blocks. https://community.openproject.com/wp/28103	6 years ago
Henriette Dinger	41805c3df1	Handle correct redirecting and minor styling issues	6 years ago
Henriette Dinger	933a2c9491	Show language selection on first login	6 years ago
Oliver Günther	ca4de761de	Fix adding and removing blocks on my page with CSP	6 years ago
Inga Mai	9659285be3	AngularJS in 'mail-notifications.html.erb' replaced by Angular component (#6338 ) * AngularJS in 'mail-notifications.html.erb' replaced by new Angular component 'show-section-dropdown.component.ts'	7 years ago
Jens Ulferts	57e6d67fe2	simplify my controller code	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Henriette Dinger	71542e5c74	Hide breadcrumb on myPage (#6055 ) [ci skip]	7 years ago
Oliver Günther	1f2492bb8b	Implement HashedToken (ExtendedToken from MOTP) in Core	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Oliver Günther	63dae8516f	[25110] My Page: Fix default blocks being enabled	8 years ago
Henriette Dinger	7e1c46a6f7	Hide breadcrub per default and show in admin, my, wikHide breadcrub per default and show in admin, my, wiki	8 years ago
Henriette Dinger	7c11383a82	Move 'my page' to menu on the right	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	fe0e8dd919	Rename before_filter to before_action	8 years ago
Oliver Günther	fff21a1229	UserPasswords: Replace salted SHA-1 with bcrypt This adds a typed userpassword class for Bcrypt password hashes that replace the previous default of salted SHA1. It still provides a class for SHA1 passwords, however new passwords of that type may no longer be created directly, and passwords are checked whether to upgrade them on every login.	8 years ago
Oliver Günther	7ecad5e0ca	Make global setting for password confirmation Implements a check to request password confirmation only when: 1. `Setting.internal_password_confirmation` is set 2. The user is internally authenticated (`user.uses_external_authentication?` is false) [ci skip]	8 years ago
Oliver Günther	4773ce1f9a	Implement confirmation confern for my/account	8 years ago
Henriette Dinger	e337822715	Refactor menu splitting and project drop down This allows us to use the helper to decide when a drop-down node is selected based on its content. Since we do not always pass MenuItems to the render_drop_down_node helper, we unfortunately must pass the selected state of its contents in that case. Also moves project and help helpers into separate modules	9 years ago
Markus Kahl	5324b2cc07	drop my first_login; redirect to work packages if possible	9 years ago
Jens Ulferts	d364d7d418	indentation	9 years ago
Jens Ulferts	8868b3d741	reremove line accidentally readded by merge `dc3337a`	9 years ago
Mohamed Wael Khobalatte	35693f2940	Re-implement my/page block drag and drop in dragula and jQuery We part ways with Protoype's Sortable module, link_to_remote, and some javascript in favor of a tigher implementation using dragula, jQuery, and some js.erb responses. Sorting logic was also simplified; we now merely send the state of the source and the target of the drag&drop to the server where it persists. We no longer make a special case for each of the containers.	9 years ago
Mohamed Wael Khobalatte	a1bf92212d	Fix legacy and cucumber specs failing because of strong params	9 years ago

1 2 3

147 Commits (9a6dfcca301350f150a52e5148d6a2b4b1072588)