169 Commits (9a938042fe1820983983fd29b2c5cf208e872e89)

Author	SHA1	Message	Date
Jens Ulferts	b33244ea67	only check for existence in db ... Avoids loading the whole object	9 years ago
Jens Ulferts	e544eb0653	eager load associations required for validation	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Jan Sandbrink	17940bf02c	change validation of WP children ... - do not add error on a symbol called :#123 (123 is the childrens ID) - this is against the semantics of ActiveRecord::Errors - creating symbols in a loop used to be a bad idea (might be better today) - it breaks error messages in the APIv3 (which is due to APIv3 working beyond the borders of AR errors, not the best of ideas...) - use :base instead, the place for unlocatable errors - include the fact that #123 refers to a child element in the error message Basically I feel that this makes the children validation cleaner and better. But somehow I fear, that there is some code out there that depends on the fact that error keys like :#123 existed...	9 years ago
Alex Coles	29d9814347	Prefer Project.allowed_to to .allowed_to_condition ... Use `ActiveRecord::Relation#merge` to merge scopes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	787a35c9db	Add explicit join references in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	0f9240037a	Fix TimeEntry cleanup on work package bulk delete ... Fix `WorkPackage.cleanup_associated_before_destructing_if_required` semantics so that the first argument can either be an individual `WorkPackage` (as the spec originally expected) or a collection (as in actual usages). Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	abf4a011f0	Fix copying of versions on Project copy ... Adds a more robust solution for copying closed versions and associating with copied work packages (see original patch 10ec20a8). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alexander Bach	55f5f33456	Changed code readability	10 years ago
Alexander Bach	942f39876f	Removed hard coded id column for pdf export	10 years ago
Alexander Bach	404a5b42e6	Remove hard coded id column for csv export	10 years ago
Alexander Bach	9f692f6bf1	Use the empty string for absent descriptions	10 years ago
Alexander Bach	15f52bcdc6	Added validation for estimated hours values	10 years ago
Alexander Bach	f403d6aaaa	Increase category validation strictness	10 years ago
Alexander Bach	03494dae0a	Some style improvements	10 years ago
Alexander Bach	41f8f34de5	Set error on category instead of category_id	10 years ago
Alexander Bach	1c84be3dca	Completed basic implementation to write categories via API	10 years ago
Jens Ulferts	0f6357eec6	fixes wp validation for inexistent versions	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Jens Ulferts	fdae20f2c8	refactor to reduce complexity	10 years ago
Jens Ulferts	18279b9b5f	set export title to query or default	10 years ago
Jens Ulferts	aec124e459	remove unused variable	10 years ago
Jens Ulferts	dda5c4e866	whitespace/styling fixes	10 years ago
Openproject	3cadf8fdd1	Bug fix CVS is fixed	10 years ago
Hagen Schink	63cb3ea293	Check if status exists before validating the transition	10 years ago
Hagen Schink	60eb70b30e	Validate WP children ... Originially, this method was defined in a WP patch in OpenProject Backlogs.	10 years ago
Alex Coles	1d1ec0ef37	Prefer #map over #collect in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c12410a736	Fix whitespace in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	a7ad3fff42	Style fixes: Remove unnecessary semicolons ... Because rb != js	11 years ago
Ion Biziiac	59adc2b45d	Fixes 'due date' validation when 'start date' is not present in a custom form	11 years ago
Johannes Wollert	d851757ec3	work packages can no longer be assigned to inactive priorities	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Markus Kahl	2af7effcfc	export string	11 years ago
Markus Kahl	914c50c746	use cell instead of undefined content...	11 years ago
Markus Kahl	b5d3765828	use CodesetUtil to encode csv	11 years ago
Markus Kahl	569dc6a361	don't hardcode encoding	11 years ago
Markus Kahl	b1ccd322c9	encode csv export in UTF-8	11 years ago
Hagen Schink	d2c0293215	Implements API's workflows controller	11 years ago
Hagen Schink	89a3f285f5	Assigns all roles if current user is admin	11 years ago
Hagen Schink	4af2df5f44	Prevents status validation on type change	11 years ago
Hagen Schink	9f40a7184b	Adds status transition validation	11 years ago
Sebastian Schuster	f36cbf319d	Fixed missing parent_id error	11 years ago
Hagen Schink	a3d56e8dac	Removes deleted validation	11 years ago
Philipp Tessenow	444546e2e8	use \A and \z instead of ^ and $ in ruby regexes	11 years ago