251 Commits (9c06fd91c351718069abf86f991c04047d8e1986)

Author	SHA1	Message	Date
ulferts	a76a7cec9b	Fix/parent filter (#9032) ... * use the backend`s url for fetching available values The backend in it`s schema already provides the valid values. The front end uses this to created a collection resource and fetchh the values from there. * remove configuration options For now, the filters are only used in the context of work packages. This might change but having configuration for static values only results in unnecessary complexity. Those options can easily be readded when needed * correctly blacklist subjectOrId filter * allow id filter in the front end Because the autocompleter for work packages is in place now for work package filters, it is trivial to enable the id filter as well	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	97f8677cc7	allow filtering for groups and placeholders on user cfs ... Extends the ability of filtering work packages based on user typed work package custom fields by values of the classes: * Group * PlaceholderUser	4 years ago
ulferts	30711e740f	add filtering for assignee with placeholder users	4 years ago
ulferts	e9692f85a5	add filtering for assignee with placeholder users	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943)	4 years ago
Behrokh Satarnejad	f0669247a5	[33163] Add work package filter for child work packages(implementing the component in another way) (#8826) ... * implementing the component in another way * refactoring the code * resolving codeclimate errors * indentation fix * resolving quotation marks errors * resolving the travis errors * resolving codeclimate errors * implementing the component in another way * refactoring the code * resolving codeclimate errors * indentation fix * resolving quotation marks errors * resolving the travis errors * resolving codeclimate errors * implementing the component in another way * refactoring the code * resolving codeclimate errors * indentation fix * resolving quotation marks errors * resolving the travis errors * resolving codeclimate errors * focus the component after inintialization and use array functions instead of lodash * adding a test for parent filter Co-authored-by: Aleix Suau <info@macrofonoestudio.es>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Inga Mai	5a79243953	[32928] Move cost reports to a submenu (#8627) ... * Move cost reports entries to submenu and adapt html structure to other submenus * Adapt styling to wp query menu and make styles generic * Highlight menu entry and sub entries on select, let submenu stay opened and make catergories toggleable * Adapt styling of project and global cost reports to other submenus * Only show category if it is not emtpy * Fix failing spec * WIP: Don't show empty submenu * Add placeholder for empty queries and show categories again * Fix menu entry highlighting Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798) ... * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653) ... * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651) ... * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
ulferts	2562bd6475	Fix/bump gems (#8613) ... * bump em-http-request * bump warden * hopefully stabilize flickering spec	4 years ago
Oliver Günther	e80fcfbeac	[33901] Disable the button and disallow editing for scheduled parents ... https://community.openproject.com/wp/33901	4 years ago
Oliver Günther	3b78c25588	Fix spec expecting for start date to be moved back	4 years ago
Oliver Günther	558bfc5e74	[31617] Re-enable group sums rendering ... The grouped rows builder excluded rendering of per-groups sums, however the API returned these results anyway. It's easy to just render a sums row as we did before. To that end, I have removed that functionality from the sums row directive and into a generic renderer that can be used with and without angular. https://community.openproject.com/wp/31671	4 years ago
Behrokh Satarnejad	bf8c775f31	[33109]Arrow next to parent task still shown after removing subtask (#8472) ... * change removeChild function to reload the parent wp * add a ruby test to check the functionality	4 years ago
Henriette Darge	b3dd61946e	[32880] Display scheduling mode in work package view (full, split & table) (#8410) ... * Show icon next to start date depending on the scheduling mode * Show modal when opening date edit fields which shall be able to change the dates and the scheduling mode * Introduce flatpickr as a datepicker for the modal of the dateEditField * Use new datepicker within opDatePickerComponent * Reuse existing Datepicker class for better code abstraction * Set dates only when Instance is ready * Let augmentedDatePicker use generic DatePicker class, too. * Remove jQuery UI datepicker specific styles as they do not apply any more. * Use localized strings in new datepicker * Close datepicker only on click outside * Allow single and multi selection of dates and save changes * Update schedulingMode button correctly && remove unused method * Show combined field for start and end date within the WP single view * Show normal datepicker for most date fields and the modal with the extended datepicker only for startDate * Add datepicker edit field and component helper * Correctly save start and end date * Show correct default value for dateEditFields && Adapt some tests to new datepicker and combined date field * Fix date editor spec * Fix expecting datepicker for start/due date as milestone * Prevent overflow on body by using modal-portal class && make edit input for combinedDates visible again to show something in a create form * Only output one debounced change event for op datepicker * Show combined datepickerModal for dueDate in table, too && save correct scheduling value * Hide modal if the showing component gets destroyed * Correctly check for closed datepicker * Add spec for toggling scheduling mode * Fix setting dates to modal * Avoid too many (unnecessary) close events and use keydown instead * Fix date setting and add custom field date spec * Change layout of combined date picker modal * Switch from a range date picker to a multiple selection in order to be able to set only start or due date && Highlight date field that is changed next * Highlight range manually * Highlight dueDate initially when the user clicked on the due date field && handle special case that one of the values is not set yet. In this case we don't want to keep both values but only the newly clicked. * Move helper functions to own class && Improve the range selection to be able highlight ranges over multiple months && Prevent that a start date > due date can be chosen by setting minDate and maxDate * Adapt test to new way of changing the scheduling mode * Handle case that the user clicks on a already selected date and thus deselects it Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	740d1e966f	Prevent double 409 conflict form errors after saving the work package ... Due to the way the changesets are used and cleared, we were causing double posting to the form with an old work package lockVersion: 1. Lock version in changeset correct, editing work package, saving it 2. The EditForm destroys the changeset on submit prior to the work package being updated in state 3. The WPStatusButtonComponent got a call after the changeset was destroyed, resulting in an immediate new changeset being created. 4. The new changeset resulted in the changeset set being fired, which triggered the select edit fields 5. They requested the form post with an older lock version	5 years ago
Henriette Darge	ebc3f6fe18	Prevent that the backend changes the order of filter attributes (sorted by id). Otherwise there is a visible change in the filter attributes in the frontend.	5 years ago
Oliver Günther	f0380bb570	[33329] Set parent in changeset to ensure it gets saved ... https://community.openproject.com/wp/33329	5 years ago
Oliver Günther	ed5e2c186d	Change spec expectation that now calls the service	5 years ago
Henriette Darge	828688ab4b	Show timelogging modal when logging time via the context menu of a WP view (#8320) ... [ci skip]	5 years ago
ulferts	cf735714d3	order independent contains operator (#8315) ... * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago
ulferts	e5749d9817	order independent contains operator (#8315) ... * order independent contains operator This for example affects the search which relies on the subject filter with the contains operator being active. * remove legacy query spec The query is generally covered rather well in the new specs. [ci skip]	5 years ago
Henriette Dinger	7ee2ee731a	Update toolbar title after query changes	5 years ago
Oliver Günther	672ca6a93f	Fix invalid rspec syntax	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
Oliver Günther	94d696acb2	Fix drag & drop spec by using firefox ... Chrome does not report drag events through selenium	5 years ago
Oliver Günther	4a68ae7433	Replace columns autocompleter select2 with ng-select	5 years ago
Oliver Günther	c7306c751c	[32785] Ensure we load first page on filter change ... https://community.openproject.com/wp/32785	5 years ago
Henriette Dinger	057535fa95	Add parent_id parameter to create route again, to allow setting the parent directly	5 years ago
Oliver Günther	5c3e801418	[31969] Single BCF view / work packages in BIM (#8074) ... * Use single route to load models instead of defaults+show * Re-add model to show && enabled shadow information to viewer * Remove obsolete frontend routes * Show component * Allow other event handlers to be injected into card view This allows to have other actions on click, dblclick or basically any events that the registry handles * Remove padding in viewer * Rebase onto partitioned query space component [ci skip] * Make generic router class for split screen * Make generic bcf single view routes to reuse * Correct check for partition style class * Allow details-view on the list as well * Extend test for single view navigation * Fix tests * Remove bim specific padding * Add click handler to bcf card view registry Co-authored-by: Henriette Dinger <h.dinger@openproject.com>	5 years ago
Oliver Günther	7b56b1c886	[32354] Correctly escape filters in frontend to avoid unescape ... The filters were not correctly escaped in the frontend, causing special query characters such as & to break to search. https://community.openproject.com/wp/32354	5 years ago
ulferts	46da78f8c1	round trip for creating a work package on ifc page	5 years ago
Oliver Günther	afeb1a42af	[31859] Save date with confirm button when empty ... https://community.openproject.com/wp/31859	5 years ago
Henriette Dinger	f1f81f919e	Add spec for extensible tabs with Lambdas as paths	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	0867195438	attempt to fix flickering spec	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
Henriette Dinger	6f92035ccc	Rename EditField classes used for tests and remove WorkPackage reference	5 years ago
Henriette Dinger	f47a75d153	[31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726) ... * Check edit fields for Work package dependencies * Make EditForm, NotificationService, EditContext indepenedent of Work Packages * Make EventsService independent of WorkPackages * Start renaming WpNotificationService (WiP) * Fix more references * Fix typescript errors * Add basic halEditingService * Rename to global halResourceEditingService (WiP) * Move typing from class to methods (WiP) * Fix typescript errors * Remove space in type * Add test project widget && generalize the editFieldGroup * Rename editing portal service [ci skip] * Rename WpEditFieldComponent * Rename WpDisplayFields * Rename display-XX-field to XX-display-field [ci skip] * Add WP specific ID field to distinguish between resources * Re-add state in work package resource * Generalize display field renderer * Rename spent-time to wp-spent-time and fix highlight specifics [ci skip] * Actually load the project schema and make field editable * Make edit-field-group.component an edit-form.component and subclass EditForm * Remove edit context in favor of specialized EditForm * Add special cases for work package editing * Fix edit actions bar * Fix codeclimate issues * Use WorkPackageNotificationService if necessary * Override NotificationService for WPs to allow WP specififc notifications (WiP) * Correctly provide wpNotification service Because the ui-router doesn't seem to correctly use the parent element's injector, we need to provide the wpNotification service not in the wp-base, but rather the wp-list component as well as in the isolated query space. * Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage) * Remove superfluous cell class constant * Start renaming selectors for wp-edit-field into generics * Remove wp-table--cell-span in favor of display field selector * Consolidate other display and edit field styles * Provide specialized service for transitions in active edit forms * Remove superfluous overflowSelector * Accept that date field contains some work package specifics * Ignore unreadable files * Provide the changeset for work packages as a hook Since hal resource editing service is provided per query space, we cannot register them once (would only work globally) * Fix dangerfile * Remove another todo in halResourceNotification service * Fix npm TestBed for changed dependencies * Show inplace edit field in project details widget * Fix highlighting in single view * Provide HalResourceEditingService outside of project context * Used typedState for single-view * Also provide wpNotification service in split view * Correct check for resource type in eventsService * Fix getSchemaName in display field renderer * Fix passing ids into `halEditing.stopEditing` * Do not globally inject the halResourceEditingService There's a bug(?) in ui-router that gives you the global service before the parent injected service for a ui-view * Fix wpCreate service on copying and parallel creation * Remove test project widget * Revert changes for project details widget	5 years ago
ulferts	57131fa32b	continue adapting to altered project properties	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
Oliver Günther	02f9e5cf92	[31095] Fix double saving query title due to blur ... The blur event causes another save that is only caught for new queries https://community.openproject.com/wp/31095	5 years ago
Oliver Günther	5a9c08036d	[30994] Update empty changesets to match the latest resource ... If a work package changeset is openend, and then some other action happens that does not run through a changeset (updating a parent id e.g.,), the old changeset will still be present and returned by the editing service. This results in getting an older lockVersion for the edit, even though the work package is up to date. https://community.openproject.com/wp/30994	5 years ago
Oliver Günther	0450b192ae	Don't show indentation option for cards	5 years ago
Oliver Günther	580e9a27ad	[30786] Indent and outdent work package hierarchies in context menu ... https://community.openproject.com/wp/30786	5 years ago
Oliver Günther	0ddc079cf7	[30777] Replace most usages of refresh service with global eventing service ... We are increasingly having one problem: Notifying a parent querySpace of changes within another embedded query space (e.g., a nested embedded children table adding new relations, which should re-render the table). As the `WorkPackageTableRefreshService` is rightfully part of the query space, it cannot be used for these notifications. This PR suggests to add a global `WorkPackageEventService` which is called for specific events that can be registered to and events can be received in buffered mode with a debounce. From these events, the table is then refreshed if a visible work package is present in the table. https://community.openproject.com/wp/30777	5 years ago
Henriette Dinger	f850aca7b8	Merge release/9.1 into dev	5 years ago