openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	15a2716d95	[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	57529d73c4	Adapt tests to new tab row structure	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	741c9012c8	Fix specs	5 years ago
Inga Mai	7344eb0af3	Codeclimate and tests fixed	6 years ago
Jens Ulferts	a6630da0bc	replace more user status cukes	6 years ago
Oliver Günther	301f38b0aa	Allow user order to differ, as long as results are identical	6 years ago
Jens Ulferts	88f8617e5a	fix spec user pages modules	6 years ago
Jens Ulferts	a262191b5e	replace user index cuke	6 years ago
Oliver Günther	4686486bb6	[28147] Show results on focus in select decoration https://community.openproject.com/wp/28147	6 years ago
Jens Ulferts	2141d606eb	move hide section functionality to ng-js	6 years ago
ulferts	e71df7013a	replace user manual registration cukes (#6267 ) [ci skip]	7 years ago
Jens Ulferts	9b30d04556	implement autocompleter for custom actions * Based on jquery ui autocompleter * wrapps standard select box * different style for multi/singleselect * simplifies styles for selected values (attachments, watchers)	7 years ago
Jens Ulferts	95a4c352d7	allow sorting custom actions	7 years ago
Jens Ulferts	9bf5d05fdb	add description on custom action * turn custom action into fully fledged resource * add description to custom action model * load custom action resource on mouse over and display in title	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	ffcfd6ddc1	allow multi select for conditions	7 years ago
Jens Ulferts	709afa4f89	don't apply actions leading to errors	7 years ago
Jens Ulferts	414212c49f	handle multi select custom fields	7 years ago
Jens Ulferts	886273ee86	initial implementation of conditions - status	7 years ago
Jens Ulferts	bc85973221	allow multi select on custom fields	7 years ago
Jens Ulferts	e248322d43	implement destroying custom actions	7 years ago
Jens Ulferts	8d14f4b420	implement editing custom actions	7 years ago
Jens Ulferts	73d55f9e43	wip	7 years ago
Oliver Günther	f5b5596180	Send keys to correct element	7 years ago
Oliver Günther	b15f07ea32	Scroll to element when blocked by overflow The details view blocks certain elements of the table, causing clicks to no longer work in newer Firefoxen This is mainly caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1295538	7 years ago
Oliver Günther	a684dbfa29	Extend spec	7 years ago
Oliver Günther	b2b499a7fd	[25686] Use collection_check_box in membership page This adds a hidden field for when no checkbox is selected, however it adds the caveat that non-selected values are transmitted as empty values, thus we have to filter them again in the backend.	7 years ago

32 Commits (9c06fd91c351718069abf86f991c04047d8e1986)