6940 Commits (9c06fd91c351718069abf86f991c04047d8e1986)

Author	SHA1	Message	Date
ulferts	451d390e6a	adapt specs	4 years ago
Oliver Günther	d8cdfa8196	[34535] Override project limiting filter if subproject filter present ... When the query has an explicit SubProject or OnlySubproject filter, the project limiting filter based on the global settting does not really make any sense. It will prevent seeing any results when trying to view work packages from a subproject unless it is enabled globally. This change suggests to skip this limiting filter whenever an explicit subproject filter is added to the query. This fixes subproject boards when the global setting is enabled, since that sets only the `onlySubprojectFilter`. https://community.openproject.com/wp/34535	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized ... * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
Oliver Günther	4657892553	Don't raise eventemitter warnings after specs using puffing-billy	4 years ago
Oliver Günther	4eabc0ceba	Longer wait times for ckeditor to be initialized	4 years ago
ulferts	3b0f7367fd	move to proper module	4 years ago
ulferts	c54e895ad4	lookup existing user for mapping case insensitive	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values ... Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
ulferts	05de0a6b3c	employ view_budgets permission check for budgets resource	4 years ago
ulferts	b179f89534	use view time_entries permission on spentTime schema	4 years ago
ulferts	f28013f332	allow adding members to invalid groups ... If a group is invalid (e.g. because it has a required custom field) it should still be possible to add members to that group. Therefore, the contract no longer checks the model itself but only the user performing the operation.	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values ... Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
Oliver Günther	76823ca581	[34446] Fix direct upload with backend-generated resources ... https://community.openproject.com/wp/34446	4 years ago
Oliver Günther	d29266f5bd	[34291] Use placeholder for new resource dates ... https://community.openproject.com/wp/34291	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653) ... * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
ulferts	fee230122b	allow me id in principal filter ... The magic me value has been allowed the whole time but the equivalent id of the current user was not.	4 years ago
Oliver Günther	6881f3d347	[33696] Retain autologin cookied request in session ... https://community.openproject.com/wp/33696	4 years ago
Oliver Günther	4856cf8522	Review feedback	4 years ago
Oliver Günther	2e2f520130	Avoid updating the just created user to retain id information ... We need to track whether the user was just created to show a different message. For this, avoid any calls that save the user _after_ RegisterUserService.	4 years ago
Oliver Günther	894ba4ae6d	Ensure LDAP users can get activated with any registration setting ... LDAP users get an auth_source_id attached to them during registration, since they are effectively not self-registrating in the system, the register service should allow them with any self_registration setting. At the same time, the refactoring ensure that even an LDAP user that logs in for the first time is being redirected to home to get the welcome tour.	4 years ago
Oliver Günther	f1e25499cd	Need to pass controller to sevice for OIDC callback ... OIDC sets a cookie in the login hook so we need some access to the controller	4 years ago
Oliver Günther	5969d8239b	Correctly continue activation after registration error	4 years ago
Oliver Günther	841e1149c2	Don't show an error when the user just registered ... In case the user still needs to activate e.g., via mail, it should not be shown an error message, but instead the success message from the registration service	4 years ago
Oliver Günther	8d4d425d58	Add spec for flash retaining in session override of LoginService	4 years ago
Oliver Günther	2b2c0f7986	Add omniauth contract spec	4 years ago
Oliver Günther	da754e0f43	Add spec for RegisterUserService	4 years ago
Oliver Günther	d52f7e2ba1	Add spec for omniauth service	4 years ago
Oliver Günther	689d6c8964	We no longer render a 400, but an error message for invalid auth_hash	4 years ago
Oliver Günther	cd9312120c	Correctly stub self-registration in spec	4 years ago
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651) ... * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
Oliver Günther	506ad2e4eb	Use slide toggle on the project boolean filter (#8643) ... * Allow the slide toggle to be used on project as well * Add slide toggle to styleguide * Change spec to test slide toggle filter * Rename filterValue to active	4 years ago
Oliver Günther	af4010b003	[33496] Don't try to lookup custom value by value ... Only for list types, the value will be an integer to look up by id, but instead use `CustomValue.new(...).typed_value` to use the formatter classes to correctly look up the value. https://community.openproject.com/wp/33496 [ci skip]	4 years ago
Oliver Günther	a33521a1a8	[32131] Only show active projects in custom action condition ... https://community.openproject.com/wp/32131	4 years ago
Oliver Günther	4bb47cd935	[33750] Ensure default statuses can not be set read only ... https://community.openproject.com/wp/33750	4 years ago
Oliver Günther	a91ab2e686	[33766] Show errors when CF is invalid in project form ... https://community.openproject.com/wp/33766	4 years ago
Markus Kahl	939f1d1df7	s3 hosts differ for pre-signed form uploads and downloads ... the latter include the region in the URL. This can possibly be changed so that we only need one host. Perhaps the region is optional in the carrierwave-generated remote download URLs.	4 years ago
Oliver Günther	46741d8579	[33869] Use `auth_source` link for parsing ... https://community.openproject.com/wp/33869	4 years ago
Oliver Günther	72696429e8	Fix controller spec requiring admin	4 years ago
ulferts	50daff5062	Fix/archived projects via api (#8625) ... * minor code cleanup * allow access to archived projects via api for admins The visibility check will not work in this case as no permission is active on archived projects. We therefore need to return all projects for admins at least	4 years ago
Oliver Günther	41f8dbaff2	Refactor custom fields into services	4 years ago
Oliver Günther	24005a9e6d	[34000] Ensure user custom fields can be copied ... User CFs were not copiable because they depend on project members being copied. They need to be overridable in the copy form however, so we need to be able to set this before and after members are copied. The only option is to allow visible members to be selected there. https://community.openproject.com/wp/34000	4 years ago
Oliver Günther	6526ca2814	Map filters from api and queries in one filter mapper object ... This allows mapping the parent filter and other foreign key references that should be updated during copy.	4 years ago
Oliver Günther	1774f3fc45	Only filter for active projects	4 years ago
ulferts	a9dfb35150	avoid modifying frozen string from nil	4 years ago
Oliver Günther	3a0020f17a	Add title to explain what the button does and disable if no results	4 years ago
Oliver Günther	2e62fb8b22	Remove matrix in favor of multiselect	4 years ago
Oliver Günther	213153721e	Ensure cache is cleared for settings	4 years ago
ulferts	2562bd6475	Fix/bump gems (#8613) ... * bump em-http-request * bump warden * hopefully stabilize flickering spec	4 years ago
Oliver Günther	4aad0c8b72	Generate URL params for gantt view and insert projects	4 years ago
ulferts	05c9e3fca6	Feature/default dates for children (#8605) ... * fix start_date expectation based on setting * extract methods * set dates of parent work package * pass parent on form request * have initial dates displayed correctly in wp create form	4 years ago