openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Oliver Günther	174427fc05	Remove duplicate not_locked scope (#9166 ) * Remove duplicate not_locked scope The enum itself creates scopes but they do not include not_builtion. So instead, let's create these scopes ourselves * Change enterprise spec to no longer test for builtin users	4 years ago
ulferts	ab6d98383b	fix member filter on principals (#9063 ) In case of the `!` operator, other memberships interferred. This was because of the left join leading to result sets that where not of interest. The now used not.in does not have that problem	4 years ago
Oliver Günther	37bef43cea	Introduce visible scope to principals When a user has the manage_users permission in any project, they are eligible to view all users for inviting them to the project. This however is not reflected in the principals API, where only users in all visible projects are found.	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935 ) * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit `d93ff52a27`. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	c638b0d8dc	fix order_by_name	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Markus Kahl	9922cc1fe4	made deleted user locked; exclude builtin users from active_or_registered Because active_or_registered are users which are meant to be worked with in the system. We may want to rename this to something else.	5 years ago
Oliver Günther	51e8387e78	Remove builtin status [ci skip]	5 years ago
ulferts	83c3b281b9	ensure scope used for user list in admin does not return system user	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	9c3206220b	remove mysql specific code throughout the application	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
Jens Ulferts	ac59ad6a89	introduce group resource stub	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	ad8f11d7b2	heed group setting for assigned_to action	7 years ago
Jens Ulferts	3717f6e0d3	less complicated custom_field#possible_values_options	7 years ago
Jens Ulferts	6fdd122534	merge wp tree and relations into typed_dag Instead of having the tree/hierarchy information for work packages and the relations between the work packages separated into two tables all the information is now stored in the relations table. To support this, the typed_dag plugin is used. Notable changes: * relations_to and relations_from are swapped. relations_to has all relations that point to another work package (from_id = work_package.id) and relations_from contains all relations that lead to the work package from another one (to_id = work_package.id). This change is merely in the code. The db information is left untouched. * For follows/precedes to_id and from_id are swapped in the db. Because of that, "follows" is now the canonical name instead of "precedes". This is done so that hierarchy relations and follows relations point into the same direction which allows to easily detect cyclic relationships that would lead to infinit scheduling. * the columns `root_id`, `lft`, `rgt` do no longer exist in the wp table. * the column `relation_type` does no longer exist in the relations table. * For every type of relation a column (integer) does now exist in the relations table (e.g. hierarchy, block, follow) * Separate associations exist for every type of relation into two directions. E.g. Work packages following the current one can be accessed via `work_package.precedes`	7 years ago
Oliver Günther	89ac5789c7	Replace scopes with already defined names The activerecord scope helpers output a warning when a scope's name already exists in the module's method chain. E.g., `Kernel#open` is overridden by some of the scopes, but that always results in a warning. A better way is to explicitly override the method in the model using a class method.	7 years ago
ulferts	39bbf082bf	fix author filter for projectless users (#5718 ) As the principals returned by the principals API where limited to those that are members in projects the user can see, users not having any project would not be returned. This is intended in so far as to prevent getting all users easily. But the user herself should be visible in any case. [ci skip]	7 years ago
ulferts	ce19a34a48	allow invited users to be watchers (#5520 ) [ci skip]	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	c3013d6272	lazy load query filters and extract them into classes This allows us to only load the values we actually need instead of loading all the values regardless of whether we need them. This is especially usefull in the api where we currently never need those values. Note, that this is a glitch in my opinion as we do not check whether the filter value is valid.	8 years ago
Oliver Günther	b58f5fc354	Allow UsersController to search for groups Since work packages can be assigned to groups, allow the UserSearchService to work on principal, not only users.	9 years ago
Jens Ulferts	c3ab585e80	remove dead code	9 years ago
Jens Ulferts	0b2f482797	move :preference to principal This allows for eager loading preference. As the UserPreferences are pretty specific to users we don't want groups to actually receive a UserPreference, though. The methods added by has_one are therefore undefined on the Group model.	9 years ago
Jens Ulferts	0579f4906b	provides scope to order by name The order is determined by the currently active setting	9 years ago
Markus Kahl	fecb1b91b7	invited uses should be usable too We may need to think of a name that includes active, registered as well as invited users. For now we can think of invited users as registered ones. Just a bit differently.	9 years ago
Markus Kahl	98ba7ce333	basic user invitation prototype	9 years ago
Alex Coles	67c84961a0	Migrate model has_many conditions to lambda Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	5557f58e80	Migrate model scopes to use lambda/block Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	8edff9831c	Pull up constants, associations into Principal Constants were previously misplaced in `User` subclass (as noted in TODO). Associations were previously moved into subclass to work- around an apparent STI bug. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c80a792496	Use 1.9+ Hash syntax in Principal Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	45b75558bb	Change {Chili => Open}Project::Database usages Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Oliver Günther	9e6da91798	Updated API for user (un-)locking - Adds an lockable?, activatable? to the Principal model, which is overridden by User as aliases to active? and locked?. - UserRepresenter refers to the above methods - Refactored /lock routes into a single method Specs: - Adds delete /users/:id/lock spec - Refactored FactoryGirl calls to avoid create where feasible	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Jens Ulferts	8b3a1cf47d	rewrite scopes to avoid 'conditions' 'conditions don't seem to merge any more	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago

1 2

98 Commits (9e77b6ad6e2a9db8ebdc985e0508629ffa54bb40)