144 Commits (9f4b26a6333003b086fd00c99e69d8f63997a07b)

Author	SHA1	Message	Date
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	4b1494a4d9	respec WorkPackage#recipients	8 years ago
Jens Ulferts	defe6e75a8	allow responsible to receive notifications	8 years ago
ulferts	af5731a843	remove precedence of default types for a new work_package's type (#4571) ... The 'default' flag is meant to signal the type to be a selected by default when a new project is created	9 years ago
Oliver Günther	5693f6946c	Fix summing done_ratio when estimated_hours is zero (#4528) ... When `estimated_hours` is `0.0`, it is still taken into consideration when weighting average done ratios for a parent. That results in the parent becoming `0%` done. As 0.0 is being set in the frontend as the default value, this is now happening all over the board. A separate PR should refactor the frontend for 5.1. to allow null as a value for estimated_hours.	9 years ago
Henriette Dinger	867b273c8a	Set default wp type	9 years ago
Jens Ulferts	5cbc31392f	move some specs into appropriate file	9 years ago
Jens Ulferts	d1c2578eee	extract new status description into separate spec	9 years ago
Jens Ulferts	ff3d42fa33	add a project independent endpoint to create work packages ... Includes the auxillary end points: * form * schema * available_projects	9 years ago
Jens Ulferts	dd05cf297c	add capability to move work package accross projects to service	9 years ago
Jens Ulferts	0267938c36	introduce spent_time model	9 years ago
Jens Ulferts	11d7e428ad	reuse version calculation on eager loaded projects ... Eager loading projects assigns the same object instance to each work package having the same project_id. When the first project evaluates the assignable versions, the result can be memoized to be used by other work package having the same project	9 years ago
Stefan Botzenhart	ba3c727dcc	Remove pending specs	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Stefan Botzenhart	1c01b5801e	Use login_as helper method throughout all specs	9 years ago
Jens Ulferts	d279e2a3ce	use delegation for available assignees/responsibles ... And only spec that delegation. The specs on project test the actual behaviour.	9 years ago
Alexander Bach	a8e1aadec7	replace changed_data by details ... working towards making the alias obsolete...	9 years ago
Jens Ulferts	f5437ff077	consolidate specs for move work package service	9 years ago
Jens Ulferts	1b82ddcd57	merge specs for copy and move	9 years ago
Jens Ulferts	a8a0eee2d8	prevent moving to not allowed project in work package model	9 years ago
Jens Ulferts	309254bf20	explicitly hand over the current user	9 years ago
Jens Ulferts	00a441e289	use existing method for permission check	9 years ago
Jens Ulferts	c56665455d	prevent admins from moving a wp into unfitting project ... Unfitting means, that the work package module is not enabled in the project. There would have been an alternative implementation but it is probable, that the implementation choosen can be generalized	9 years ago
Alexander Bach	4392ffb225	Fix more tests	9 years ago
Jan Sandbrink	218c75e765	fix update_by! user when not providing notes ... - previously the created Journal Entry would have been made by the specified user or the User.current, dependent whether :notes were provided or not - now the journal entry is always made by the specified user	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	88b99db223	only respond to valid custom_field_n accessors ... it is not enough that the CF exists, it actually has to be a CF that can be used on that work package	10 years ago
Alex Coles	ebbc9e3d7d	Prefer #not_to over #to_not in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	6cd0cad516	Remove #errors_on usages in specs ... This behaviour would now require `rspec-collection_matchers`. See https://github.com/yujinakayama/transpec#note-about-expectmodelto-havenerrors_onattr Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	857bcf4636	some refactoring around the WP schema ... - schema does not decide anymore whether to include allowed values (solely decided by "form_embedded" of representer) - schema will answer as many "assignable_*" methods as possible - work package does not need those methods anymore (except few cases)	10 years ago
Alex Coles	3785fdc9ed	Use #describe, #context with String arg not symbol ... The semantics of `describe` have changed in RSpec 3: passing a symbol rather than a string will change the value of the described object. See discussion here: https://github.com/rspec/rspec-core/issues/1114 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec ... This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { |c| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Jan Sandbrink	3168182499	"fix" a previously "good" spec	10 years ago
Jan Sandbrink	1aa234ae58	fix another broken spec	10 years ago
Alexander Bach	03494dae0a	Some style improvements	10 years ago
Alexander Bach	92618be3ed	Added tests for category writing	10 years ago
Markus Kahl	96b4f1e99c	fixed broken wp spec ... the current user within the shared example is a different one to the one (anonymous from the outmost spec scope) than the one defined in the 'user with permission to view time entries' context, which, I believe, is unintended and also happens to break the spec with the changes to the journal observer.	10 years ago
Jan Sandbrink	9b54862b53	allow patching of WP priorities ... - allow PATCH - add schema to form - add specs	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	ca3b33b5be	Test that it is allowed to assign a group as responsible ... There isn't a validation for this yet. But also assignee misses such a validation. I left a TODO, so others are reminded to fix this globally someday.	10 years ago
Hagen Schink	d735ec90ce	Test that it is possible to assign groups as responsibles	10 years ago
Hagen Schink	ce8c1fd1c7	Test that assignable responsibles can contain groups	10 years ago
Hagen Schink	c6ab37e25e	Test WP's spent hours property with read permission	10 years ago
Alex Coles	f95c9d15f3	Prefer #map over #collect in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	b77334119c	Fix incorrectly converted collection assertions ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	efe24e1049	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 1.12.0 with the following command: transpec * 100 conversions from: it { should ... } to: it { is_expected.to ... } * 17 conversions from: expect(collection).to have(n).items to: expect(collection.size).to eq(n) * 10 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 9 conversions from: be_true to: be_truthy * 9 conversions from: expect(obj).to have(n).errors_on(...) to: expect(obj.errors_on(...).size).to eq(n) * 8 conversions from: obj.should to: expect(obj).to * 4 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 2 conversions from: be_false to: be_falsey * 2 conversions from: expect(obj).to have(n).error_on(...) to: expect(obj.error_on(...).size).to eq(n) * 2 conversions from: pending 'is an example' { } to: skip 'is an example' { } * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: expect(collection).to have_at_least(n).items to: expect(collection.size).to be >= n * 1 conversion from: obj.unstub(:message) to: allow(obj).to receive(:message).and_call_original * 1 conversion from: pending to: skip	11 years ago