286 Commits (a07eb5317df74621daa00fb118213c0d9c27e563)

Author	SHA1	Message	Date
Alex Coles	53524637ec	Migrate acts_as_journalized has_many to lambda ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	bbe8ec184a	Migrate acts_as_customizable has_many to lambda ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a6c54cb25f	Migrate AR finder/query methods in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e02599c121	Make acts_as_journalized retry journal saves ... Since 2c735943, validation errors are raised and propagate. Uniqueness validations in the application code are generally prone to race conditions. Previous commit e8c2ce06 should help mitigate against this scenario. Nevertheless there are still problems setting a unique, initial version for a given scope: this patch attempts to work-around this situation. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	02b5c722ef	[wip] Disable acts_as_watchable has_many validate ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	a58650e7c6	Add/update Copyright headers in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	abc2b25ab3	style	10 years ago
Jan Sandbrink	9b9785ca0c	invert conditions for better readability	10 years ago
Jan Sandbrink	88b99db223	only respond to valid custom_field_n accessors ... it is not enough that the CF exists, it actually has to be a CF that can be used on that work package	10 years ago
Jan Sandbrink	fb44594d1f	style	10 years ago
Jan Sandbrink	d8bc15a6bd	remove NO-OP code	10 years ago
Jan Sandbrink	f0197b4323	style	10 years ago
Jan Sandbrink	fb486c1921	fix validation in type changing cases	10 years ago
Jan Sandbrink	d1e3e2d543	simplify loop	10 years ago
Jan Sandbrink	a59df82ca1	only create CF accessor methods on demand	10 years ago
Jan Sandbrink	9986466e15	use direct CF accessors in CF injector	10 years ago
Jan Sandbrink	e3537be022	add methods to directly access custom fields	10 years ago
Jan Sandbrink	1bf1cf2c1b	ignore custom values that are to be deleted ... - fixing the last failing test	10 years ago
Jan Sandbrink	7219eebee5	fix failing test unit tests ... requires to run validations for custom values every time, so we do it there was no clear indication on why they should not run always, it was not apparent either	10 years ago
Jan Sandbrink	e4ee92aa3e	forbid validation of associated custom values ... this SHOULD already be the default, however specs failed here because of additional validation that took place. Those validations stopped by adding the validate-parameter. Better don't ask why I guess... Development and Production mode behaved as documented though (validate false by default)	10 years ago
Jan Sandbrink	36bb955f7c	add custom value errors to customizable ... - allows to relate error messages to their custom field - allows to use errors.full_message correctly for custom values - might break specs... we will see that soon	10 years ago
Jens Ulferts	a70bbd7045	improve performance of watcher determination	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Hagen Schink	18af561064	Return only users who can see the watchable	10 years ago
Alex Coles	69d354ccd3	Replace AR conditions w/where in acts_as_watchable ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ca2a1a5afc	Prefer #map over #collect in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2f75bf4aff	Fix an indent in acts_as_customizable.rb ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	dabd7ba88a	Fix bad rubocop auto-correct affecting procs ... Switch to stabby lambdas, where consistent. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	45297523c2	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e7400af52a	Use 1.9+ Hash syntax in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Mihail Maxacov	080f2cb44f	fix personal activity broken	10 years ago
Philipp Tessenow	1aab90ccb8	restore wrong (but performant) possible_watcher impl	10 years ago
Philipp Tessenow	43fa84c875	restore wrong (but performant) possible_watcher impl	10 years ago
Hagen Schink	a9b9f2c46a	Make long WP change information accessible	10 years ago
Jens Ulferts	f758aabfb1	uses gravatar_image_tag gem as standard avatar lib	10 years ago
Till Breuer	2c4483544c	Merge branch 'dev' into feature/adding-and-removing-watchers ... Conflicts: app/assets/javascripts/angular/work_packages/controllers/work-package-details-controller.js karma/tests/controllers/work-package-details-controller-test.js lib/api/v3/work_packages/work_package_representer.rb	10 years ago
Richard	b68524e97b	Order work packages attachments by filename by default.	10 years ago
Hagen Schink	e02cde8d3a	Fix event name translation	11 years ago
Alex Coles	23d14e94a9	Fix whitespace in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	29e89917fc	Fix whitespace in RFPDF plugin ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	129ad4d584	Remove invalid Ruby/PHP from RFPDF plugin ... Remove Barcode support entirely. The porting of this code from PHP appears to have never been completed. Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Michael Frister	2c7359436a	acts_as_journalized: Use save! instead of save ... This should prevent journals silently not being saved on validations errors.	11 years ago
Michael Frister	f079e4bcdd	Clean up acts_as_journalized SaveHooks	11 years ago
Alex Coles	a2679b5d35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec . * 5 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 3 conversions from: obj.should to: expect(obj).to * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 1 conversion from: obj.should_not to: expect(obj).not_to * 1 conversion from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message)	11 years ago
Alexey Fedorov	f4775c6a40	[fix #4928] Made journal notes shown in search. ... - Added tests and specs for bug #4928 - Examined bug - Added debug output to examine event contents - Examined journals - Added highlight_first helper - Used last_journal instead of #journals.last - Fixed Journalized#last_journal to work when eager loading messed up search - Fixed how journals are sorted when they are loaded (by version instead of created_at) - Added notes anchor when required - Added notes anchor when required - Note anchor uses version of journal note itself, not version of work package - Fixed failed test in functional/wiki_controlller_test.rb:WikiControllerTest #test_update_stale_page_should_not_raise_an_error - Fixed spec failures. - Converted search helper test -> spec, removed test file. - Moved helper methods from string to controller - Fixed search controller spec. - Temporary added isolated suite run to travis for work_package_activity_provider_spec - Removed temporary job for travis.	11 years ago
Markus Kahl	930ae39df3	Revert "use static routing in journal formatters" ... This reverts commit b0215db3d8.	11 years ago
Markus Kahl	b0215db3d8	use static routing in journal formatters	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago