2825 Commits (a0c7658c1884139559f267b60fb21c598a1afcd4)

Author	SHA1	Message	Date
Jens Ulferts	d6c32b212a	use wp for localization string ... The l10n files already refer to it as wp, so the code should also do that.	9 years ago
Jens Ulferts	ee16a5730d	improve performance of projects table ... The purpose of the subqueries is for them to be factored into a sum. Therefore rows that are null and filtered out rows count the same - 0. But performance wise it makes a lot of difference if the row needs to be kept in the query or if it is removed early on. This commit changes the query to no longer keep rows for which no attachment exists by turing the LEFT JOIN into a JOIN. By that, all containers without an attachment are ruled out very fast. If a LEFT JOIN is used, all rows for work packages and wiki/wiki_pages are returned even if they have no attachment.	9 years ago
Jens Ulferts	061a71bb32	fix setting custom values on version	9 years ago
Jens Ulferts	567c844c98	limit joined members ... Prevents to have all the user's members joined on a query for a project's available_assignees and available_responsibles. Not only the memberships the query is interested in (the one of the project) was joined but all the memberships the user had. So the more memberships the users have, the slower the query did become.	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Jens Ulferts	2516e9c0e7	allow to disambiguously group by responsible association ... Before the commit, the result for a count on a query grouped by responsible would be of the schema { id: count, id2: count2 }. For other attributes, e.g. assignee it is { user: count, user2: count2}. The difference is caused by using :responsible_id for grouping which is necessary as the association causes an ambiguous reference in the issued db query. That problem has been fixed in rails/master (c2d33c4abf). But as long as the fix is not backported, we will have to overwrite a method of ActiveRecord::Calculations	9 years ago
Jens Ulferts	b8c7d77683	unpersisted WPs are considered leaves	9 years ago
Markus Kahl	7f88ba5b22	removed attachments#show; only #download remains	9 years ago
Markus Kahl	c7c6bc2e6a	prevent unnecessary s3 access to see if file is readable	9 years ago
Jens Ulferts	4600b48b38	avoid extra loop	9 years ago
Jens Ulferts	b33244ea67	only check for existence in db ... Avoids loading the whole object	9 years ago
Jens Ulferts	9ba1633fe3	optimize soonest_start calculation	9 years ago
Jens Ulferts	11d7e428ad	reuse version calculation on eager loaded projects ... Eager loading projects assigns the same object instance to each work package having the same project_id. When the first project evaluates the assignable versions, the result can be memoized to be used by other work package having the same project	9 years ago
Jens Ulferts	e544eb0653	eager load associations required for validation	9 years ago
Jens Ulferts	9f6138b05e	fix outdated comment	9 years ago
Stefan Botzenhart	5ccdbaa3ef	Permit parent_id only if user is allowed to create subprojects	9 years ago
Stefan Botzenhart	a42e89f987	Permit parent_id for project	9 years ago
Stefan Botzenhart	1f53f5472e	Code style enhancements to fight against bad scoring	9 years ago
Stefan Botzenhart	e13641bdd2	Improve according to rubocop	9 years ago
Jens Ulferts	c2a0a2b0f5	speed up and correct spent_time computation	9 years ago
Jens Ulferts	8065c66256	eager loading associated objects, the dirty way	9 years ago
Markus Kahl	3c17be3261	retain old behaviour per default to be safe	9 years ago
Markus Kahl	e482eee87e	don't require custom field container per default	9 years ago
Markus Kahl	aa58b7deca	allow arbitrary custom field IDs	9 years ago
Markus Kahl	d4293532d9	do not block time entry custom fields	9 years ago
Oliver Günther	a339373d0f	Allow responsible_id in projects settings ... This fixes two issues: 1. `responsible_id` was missing in allowed params for projects controller / settings. 2. When the value is not set from Rails, undefined is showing. There may be a workaround solely in the frontend, but for now I return (none) to the autocompletion as a responsible name instead of an empty string.	9 years ago
Oliver Günther	353039fcfe	Allow PermittedParams to receive new keys from plugins ... Previously, PermittedParams allowed only the extension of existing keys with new attributes from plugins. Since we now need to extend strong_params from global roles in impermanent memberships, we can prevent load-order dependencies by injecting a new key in the permitted params hash into the core.	9 years ago
Mohamed Wael Khobalatte	80192f6986	Do away with eval ... Eval is unnecessary here. Sure the code has slighly more duplication, but no where near enough to warrant an eval.	9 years ago
Mohamed Wael Khobalatte	e10cc2d6ad	Pass project_id instead of project instance to version_attributes	9 years ago
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Jens Ulferts	d56ee98ceb	use db bool values for filtering	9 years ago
Mohamed Wael Khobalatte	18ac022927	Add specs for new strong_params methods	9 years ago
Mohamed Wael Khobalatte	6f1d668c39	Fix issue with versions/new being not accessible	9 years ago
Mohamed Wael Khobalatte	602dd749e3	Ensure versions params play well with plugins	9 years ago
Jens Ulferts	3684b77423	replace if condition then true else false	9 years ago
Mohamed Wael Khobalatte	a1bf92212d	Fix legacy and cucumber specs failing because of strong params	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation ... It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Jan Sandbrink	0c2415460a	Render the identifier as unchangeable in edit mode	9 years ago
Oliver Günther	04ff74ac24	Refactor PermittedParams to class	9 years ago
Jens Ulferts	3734b3a232	limit aggregation to one journable ... With only .where("#{table_name}.id = ?", notes_id) appended, the DB would aggregated all (from all journables of all types) and then select the one that is necessary. This takes a considerable amount of time. The commit will limit the aggregation to one journalizable.	9 years ago
Jens Ulferts	b0a86a69c2	refactor types action on projects controller ... * Introduced a service to reduce complexity in the controller * Used permitted params to ensure params syntax * Introduced a scope for querying for types used by a work package of the project	9 years ago
Mohamed Wael Khobalatte	7e7868b5a9	Send `watcher set` emails only when said watcher allows email notifications.	9 years ago
Jens Ulferts	c3ab585e80	remove dead code	9 years ago
Jens Ulferts	7eb8bdad53	invert setting for self notification ... Using the positive version to make it easier to understand. In order to avoid having to write a migration, the model layer encapsulates the transformation. Direct assignments to :no_self_notified is still possible.	9 years ago
Oliver Günther	b7465b08a6	Remote managed repositories ... This commit starts the work to provide functionality with remote service hooks for managing repositories. The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.	9 years ago
Oliver Günther	acb4431d8a	Implement UserPreferences endpoint ... Provides the implementation to the user preferences endpoint.	9 years ago
Oliver Günther	319c728b1a	Core notifications to alleviate third-party plugins ... This commit provides some helpers to alleviate SCM vendor plugins: * Provide code notifications when project, members and users are changed. * Allow Repository:* to determine base URL themselves (when no common URL is available) * Open Git adapter for subclassing (Gitolite)	9 years ago
Peter Lehwess	ab7ee018fc	Remove summary attribute and all traces of it from Project	9 years ago
Henriette Dinger	49fb85a487	Give icon a margin for vertical alignment and change header in repo danger zone	9 years ago