openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	46b85e5a47	Bumped version to 11.3.1 [ci skip]	3 years ago
Oliver Günther	a021379a98	Fix version to 11.3.0	3 years ago
Benjamin Bädorf	29a708f825	App header fixes (#9343 ) This fixes several issues the app header was experiencing on mobile and tablet screen sizes; * The project name was overlapping with the search icon, especially for long names. It will now get dotted out * The logo was being shown on screens that were really too small for it, causing the header to overflow and more important elements to lack space * The main menu toggle was being shown on pages that did do not have a main menu * Some refactoring around the global search input css by making it more bemmy, reducing class specificity * Improved the design of the search button on mobile, making it more in line with the other buttons	3 years ago
ulferts	4cd75489ff	Fix/nil parent rendering (#9339 ) * next apiv_3 undisclosed i18n key * fix parent rendering condition Not having a parent should be visible	3 years ago
ulferts	2f00810e92	Bug/35510 editing project settings removes link to parent project for certain permission constellations (#9336 ) * breakup spec file into individual files * spec changing project without changing parent * have spec specific to project representer rendering * prevent parent from being embedded if user is not allowed to see it * extract urn into constant * handle parsing of a hidden uri * commit hidden uri * extract methods * improve understandability of undisclosed parent property * extract method to increase understandability * centralize information on default/none option * Remove unnecessary cast and cleaner structure * adapt expected fieldset in spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
ulferts	2b74e8c92b	fix `required` value for properties on project resource (#9337 )	3 years ago
Oliver Günther	8ace160470	[37510] Fix accesing nil fragment in custom field injector (#9335 ) https://community.openproject.org/wp/37510 This got broken in `065dfbddc4` when changing the nil parsing of representable	3 years ago
Oliver Günther	0f040daf39	[37453] Fix user custom fields on new projects not being selectable (#9318 ) * Filter for any members when the project is not persisted * Fix trying to load invite user permission for empty projects * Add spec for setting a user cf for projects	3 years ago
Wieland Lindenthal	e642f7c745	Fix #37155 : Simplify quick add menu icon and circle positioning (#9304 ) * Fix #37155: Simplify quick add menu icon and circle positioning * Improve for BEM * Refactor: remove duplicate CSS class name	3 years ago
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311 ) Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	3 years ago
Oliver Günther	de65503329	[37305] Fix accesskey to project search (#9308 ) https://community.openproject.org/wp/37305	3 years ago
ulferts	98b04a4d4f	show "new project" option on add_subprojects permission (#9298 ) The "new project" option will only be displayed when the user is in a context, a project, where the add_subprojects permission is granted	3 years ago
Oliver Günther	93faf5b5dd	[37278] Treat system_user as user type as well (#9287 ) https://community.openproject.org/wp/37278	4 years ago
Benjamin Bädorf	0b7a9954be	Fix form styles again (#9284 ) * Invite User button in dynamic SelectInputComponent (#9267) * change order in integrations Nextcloud is above FAQs [ci skip] * update locales from crowdin [ci skip] * Invite User button in dynamic SelectInputComponent * Update README.md Nextcloud priority higher [ci skip] * showAddNewUserButton in MultiSelectEditFieldComponent * showAddNewUserButton naming consistency * update locales from crowdin [ci skip] * prevent avatar getting squashed * Embed openproject-edition addon to use latest gltf2xkt version * Embed openproject-related packager addons * fix displaying `multi` toggle in cf form (#9269) * Install xeokit-gltf-to-xkt@1.1.1 for BIM * Fix/add subproject only flow (#9268) * allow users only having add_subproject to create subprojects * remove reference to no longer existing projects controller action * Fixed roles and permissions documentation link (#9271) * update locales from crowdin [ci skip] * Fix/project in user invite validation (#9272) * validate project in invite modal The user might have the manage_member permission in a project but not necessarily in the one the modal is opened in. * resurface invite_user_modal spec deleted in `b50298eb30` * allows users without manage_placeholder to add placeholder to project * replace legacy spec * Fix board creation modal layout (#9274) This got broken when refactoring all the modals to `op-modal` styling. All this commit does is increase the width * always create a wiki if clicking on "wiki" menu item (#9273) Previously, this only happend if a template is defined. Ideally, the page would not be created but only displayed for the user to save then. But this solution is easier to implement. * Update README.md * [30226] Derive user id from link in create autocompleter (#9275) The CreateAutocompleter doesn't get an ID for the user, so we have to derive it from its href. https://community.openproject.org/wp/30226 * [37257] Bust cache on settings name format change (#9276) * [37257] Bust cache on settings name format change https://community.openproject.org/wp/37257 * add specs for user representer cache busting & avoid patch Co-authored-by: ulferts <jens.ulferts@googlemail.com> * Always run the synchronization service as the system user (#9278) * Feature/36382 improvements (#9266) * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Show backend validation errors in toast instead of a generic message * Include disabled field values on submit * Documentation improvements * Dumber OpFormFieldComponent: control, error and help settings as @Input * Create fieldGroups programmatical from @Input * fix: new project from themplate. Prioritize backend model * Setting template payload through DynamicForm @Input model * Tests fixes * Seet public-read ACL on capybara screenshots * New Project: reset form when template changed + keep name * fix: avoid OpCkeditorComponent >>> FormattableEditFieldComponent >>> OpCkeditorComponent rawValue loop * PR Review changes * Unit tests fixes Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com> * Invite User button in dynamic SelectInputComponent * showAddNewUserButton in MultiSelectEditFieldComponent * showAddNewUserButton naming consistency Co-authored-by: RBernsen <61973994+RBernsen@users.noreply.github.com> Co-authored-by: OpenProject Actions CI <operations+ci@openproject.com> Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu> Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Bump version to 11.4.0 * Fix form styles again https://github.com/opf/openproject/pull/9266 probably broke these styles again. This PR reintroduces them. Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: RBernsen <61973994+RBernsen@users.noreply.github.com> Co-authored-by: OpenProject Actions CI <operations+ci@openproject.com> Co-authored-by: ulferts <jens.ulferts@googlemail.com> Co-authored-by: Cyril Rohr <cyril.rohr@gmail.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	bd3eaf539e	update webinar link	4 years ago
Oliver Günther	2957236a07	Bump version to 11.4.0	4 years ago
Oliver Günther	bb27cf9903	[37257] Bust cache on settings name format change (#9276 ) * [37257] Bust cache on settings name format change https://community.openproject.org/wp/37257 * add specs for user representer cache busting & avoid patch Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	51bcf7f6d6	Fix/add subproject only flow (#9268 ) * allow users only having add_subproject to create subprojects * remove reference to no longer existing projects controller action	4 years ago
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250 ) * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
Oliver Günther	af4922ebf6	[37124] Add formatter classes for estimated hours and generalize (#9252 ) Only xls exporter had formatter classes which are generic enough to replace all other exporter formating methods. https://community.openproject.org/wp/37124	4 years ago
Oliver Günther	9547d28e95	Ensure the payload sent to notifications is a hash (#9253 ) This does not change our interface to notifications, but ensures that the payload is always a hash, as some integrations (e.g., Sentry!) depends on it.	4 years ago
Oliver Günther	b0e7205276	Bumped version to 11.2.5 [ci skip]	4 years ago
ulferts	d9af10f84d	bump rails to 6.1.3.2 (#9228 ) Fixes CVEs: * CVE-2021-22904 * CVE-2021-22885 * CVE-2021-22903 * CVE-2021-22902	4 years ago
ulferts	5cb227796c	Fix/hook service to openproject (#9214 ) * move specs from legacy * move Hook into OpenProject namespace * replace class variables	4 years ago
Oliver Günther	9256c9b46c	Allow to disable ldap groups sync with env flag (#9211 )	4 years ago
ulferts	f309cb9b09	access errors fit for rails 6.2 (#9205 )	4 years ago
ulferts	ce5e06dde2	Fix/non matching pagination (#9202 ) * fix duplicates returned for wp list on multiple matching attachments/comments LEFT JOIN leads to potentially having multiple records returned if a search string is present in more than one attachment/comment. This is not a problem if we fetch work packages directly out of the query results but becomes problematic if only the id is fetched and then used to get the work packages by a subquery. * attachment filters no longer differentiate on tsv_where concatenation As EXISTS and NOT EXISTS is now used, the full string is always to be searched for so `and` concatenation is now always employed. * adapt spec Work packages that have no attachment at all are now also considered to match the filter if a "doesn`t contain" operator is used * less strict rspec rubocops for feature specs * cleanup code	4 years ago
ulferts	071180737b	hide quick add menu when login is required and user is anonymous (#9203 ) * hide quick add menu when login is required and user is anonymous The quick add menu ("+" icon in top bar) should not be displayed if login is required and the current user is anonymous if though anonymous might be allowed to create work packages * spec anonymous role with add_work_package permission	4 years ago
Oliver Günther	2896afe6c4	Assign project identifier in backend (#9196 ) * Introduce localizable slug url Stringex currently works only with english strings for wiki. But that default is actually confusing. Instead, add an explicit localizable helper that receives the locale and sets the stringex backend locale temporarily * Generate a default identifier in the backend * Remove JS based identifier updating * Remove identifier attribute * Add button to change identifier * Adapt tests to changed identifier * Linting * Fix invalid selector	4 years ago
Markus Kahl	8c8b8bbfa7	create backups via UI (#9136 ) * create backups via UI * Fix import of modal service * introduced backup token and addressed remaining comments * allow disabling permissions * improvements - only make user wait to use backup token in if really necessary - notify admins of new backup token - disable 'include attachments' option in UI if unavailable - documentation - misc * spec fixes * fixed feature spec * allow setting capybara host in every case * removed unused style file * addressed review feedback, added further feature specs * polish (code climate) * Avoid empty attachments * Don't raise filesize validation for internal exports Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	5920ace376	[37024] Make system user permanent admin (#9192 ) * [37024] Make system user permanent admin https://community.openproject.org/wp/37024 * Yield self from run_given * Fix count for admin in bim seeder	4 years ago
ulferts	1f32407ff9	Feature/project status resource (#9190 ) * model project status as separate resource Also fixes the structure of the projects api documentation * introduce project status resource * link to project status in project resource * adapt to status resource in frontend * describe project status in project schema * adapt project form specs * adapt copy project to project status	4 years ago
ulferts	d1f419385f	Feature/member custom notifications (#9173 ) * include custom message in membership forms * keep pristine params to be able to pass it to the state * fix indentation on projects api docs * pass grape instance around in default endpoints The grape instance has readily available access to all the objects (params, current_user) so less individual parameters need to be passed. This also avoids having to store the grape endpoint in a potentials not thread safe variable * send custom message out on membership creation * send custom message on membership update * send custom message even if setting disabled * restore params interface * add custom message description to schema * describe notificationMessage in the api documentation * extract meta payload functionality into mixin * ensure password in spec meets requirements * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> * Update docs/api/apiv3/endpoints/members.apib Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	788a7086eb	[36981] Make active_record_store the default (#9179 ) Currently, we're using the cache store for almost all environments by default For the majority of installations, the performance hit to use SQL sessions is negligible while the advantages are known: SQL store enables session features such as the builtin termination of old sessions during logout (on by default) and login (off by default). SQL store do not expire until desired, preventing the cache exhaustion logout problem on e.g., community https://community.openproject.org/wp/36981	4 years ago
ulferts	bf9639243d	Make PathHelper routing independent (#9186 ) Any route can be declared on its own and should not rely on :index route to be declared. Co-authored-by: Cedric Pimenta <cedricpim@users.noreply.github.com>	4 years ago
Oliver Günther	8c632139e8	Allow plugins to define global_styles.sass (#9176 ) * Allow plugins to define global_styles.sass * Add generated sass to gitignore	4 years ago
ulferts	ff09b3b4cc	Bumped version to 11.2.4 [ci skip]	4 years ago
Oliver Günther	6dc662b1e4	[36243][30226] Different avatars for placeholders and groups (#9169 ) * Fix members autocompleter to allow hrefs * Add rendering of different avatar types * Remove unused code in backend avatar rendering * Add very basic test that the avatar gets customized per type * Allow avatar rendering in the CreateAutocompleter * Restructure avatars into BEM css * Remove avatar-classes in favor of passing size from backend * Remove to avoid confusion We use tracking with both href and , and was introduced to avoid a property called href to be overridden, but that was never a problem before. So from now we can safely use .href * Fix broken principal avatar in user activity * Ensure filters get updated even if the form is not reloaded There was a bug in conditionallyLoadForm that checked the property of link (always undefined) and would thus always reload a form. What we actually need is a form that gets reloaded only when the query link changes, but still update services from the updated query, such as filters * Adapt specs to changes classes * Rename op-principal-avatar to op-avatar	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Benjamin Bädorf	64143001fc	Set moment locale globally (#9040 ) * Set moment locale globally This sets the moment locale to the application locale globally, ensuring that moment uses the right translation strings wherever applicable. However, since we only work with languages (en), and not real locales (en-US), the first day of year calculation has to default to some option. This commit defaults to ISO 8601 for every language and locale. * Add setting to mark dayOfYear * Fix NaN check * Add spec for switching settings * Output uniq github specs Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f50297227b	[34444] Projects copy APIv3 (#9149 ) * Create copy project endpoint * Add representers * Add _meta representer for copy module information * Add Meta payload representer * Extract parsing of copy attributes into service * Extract enqueue job for projects copy * Keep request object available in the bodied endpoint this allows us to access grape (e.g., for redirecting) * Add DelayedModify endpoint that redirects to job status * Use DelayedModify endpoint for copying projects * Add api paths for form/copy * Disable cache on ProjectCopyPayload * Add spec * Add resource spec * Extend schema for meta * Extend docs * Don't pass service result, but state as meta to forms * Use copy dependencies for naming copy options in API * Add description property for counting * Remove unused action attribute * Skip writable checks on meta property for payloads * Use prepend to allow create(...) usage with meta * Extend copy spec with custom fields usage * Add spec for copy flags * Add todos * Pass errors correctly to copy settings * Remove invalid parameters to copy that are now caught through project service * Remove duplicated validation * Linting * Make count a human readable, formattable description string * Make source count string readable * Provide the source project for generating the counts * Extract copying of attachments into sepearate dependent services This will allow the API to dynamically generate a copy association schema from each dependent service * Add spec for copy schema representer * Add payload representer spec * Also validate the model to pass the validations when copying * Make description optional and add note to schemas.apib * Add send_notifications to representer * Allow to configure sendNotifications * Allow bodied to receive a state process callback That allows us to manage the meta state on the API level, not on the service level * Make other services compatible with BaseCallable * Fix params passing from BaseCallable Wrapping a single hash into kwargs obviously loses their key indifference and we can't expect all services to use a single params object. Older services use kwargs * Copy wiki page with parent_id This will save some memory instead of memoizing the entire wiki page * Fix typo * Default to true for all copy associations That means if only a true value is passed, all other options will still be true * Do not try to copy attachments if the base dependency wasnt copied * Ensure null identifier gets rendered * Fix paths to the form and commit * Change redirect to an URL * Extend documentation on meta properties as table * Ensure we pass a default params if incoming params are nil Now that SetAttributes needs to splat params, they do no longer correctly get the no-param-default behavior of Ruby, so we need to explictly assign a default params hash * Fix expect for trailing path	4 years ago
ulferts	901cbada65	Feature/gem update task (#9165 ) * task for updating gems * task for updating used rubocop on codeclimate * combine into default update task * bump aws-partitions * bump aws-sdk-core * bump aws-sdk-s3 * bump bootsnap * bump debug_inspector & i18n & loofah & nokogiri * bump delayed_job_active_record * bump doorkeeper * bump dry-logic * bump excon * bump connection_pool & faraday & faraday-excon & faraday-net_http_persistent & net-http-persistent * bump fog-aws * bump marcel * bump nokogumbo * bump oj * bump parallel_tests & ruby-saml * bump parser * bump prawn-markup * bump rexml * bump rspec-rails * bump rubocop * bump sentry-delayed_job * bump sentry-rails * bump sentry-ruby & sentry-ruby-core * bump unicorn & unicorn-worker-killer * bump webmock * use rubocop-1-10-0 on codeclimate * whitelist i18n patch * bump listen * rename update task to avoid misconceptions * bump faraday & faraday-excon & faraday-net_http_persistent	4 years ago
Oliver Günther	412302a093	Better database connection check Fixes the MySQL output and adds a rake task to properly check the connection This will e.g., output something like this ``` Database connection failed with error: FATAL: Datenbank »bla« existiert nicht ```	4 years ago
ulferts	5ad8fae4ab	add task to print all api routes (#9161 )	4 years ago
Philipp Tessenow	bd906716e5	[#36153 ] link manually created pull request to a work package using the GitHub integration plug-in (#9070 ) * Receiving and Parsing GitHub webhooks * added services for upserting PullRequests, GitHub users, and, checks. * added the datamodels for storing these entities * added logic to parse GitHub webhooks and save the entities above * fix some specs, added model specs * let UpsertPartialPullRequest return the upserted PR * added the last missing specs * avoid double-posts when editing pull requestsx * attempt to reduce flakiness * added pull requests API endpoint * handle edge case of converting partial PRs to full PRs * name raw input of an upsert service 'payload' to differentiate it from the prepared params * handle edge case: partial upsert after full PR creation * github_user does not reference users anymore * fixed a doc comment * use enums instead of custom validations * WIP * pairing with jens and some cleanup and test writing * better migration, clear up old PRs with a cron job * handle case of non-edit events which do not introduce new linked work packages, but still require a comment	4 years ago
Oliver Günther	2b0bce6b5c	Improve message when nulldb is being used (#9156 )	4 years ago
ulferts	72abb45249	Fix/project status flaws (#9138 ) * fix documentation on project statusExplanation * correctly denote the type of the project status * don`t reloy on faulty backend type	4 years ago
Oliver Günther	693d01f8c7	Bump Sentry and implement log handling in core (#9133 ) * Bump Sentry and implement log handling in core * Manually insert the sentry middlewares * Also add user locale as tags * Add performance tracing * Update sentry host to sentry2 * Update frontend sentry-reporter to the new sdk * Silence delayed_job's own logger since activejob logs already Delayed::Job will otherwise always log all arguments, which we disable by design * Remove default sentry host	4 years ago
Oliver Günther	26acf03e7a	Add schema location attribute (#9140 ) * Extend schema with a location property * Extend specs to test for location presence * Document location property * Fix typo Co-authored-by: Philipp Tessenow <tessi@bitcrowd.net> Co-authored-by: Philipp Tessenow <tessi@bitcrowd.net>	4 years ago
Benjamin Bädorf	2667cd1581	Refactor/app header (#9110 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Basic BEM changes * Remove old classes * Update more classes * Update togling logic * Fixed menu opening and some styles * Added op-menu * Fix some help menu styles * Add op-menu to help menug * Add avatar border * Fix auth_provider_spec * Fix zen mode * Fix static link help menu * Fixed top menu specs * Fix self registration specs * Fix logout spec * Fix bim revit navigation spec * Fixed menu permissions spec * Fix homescreen onboarding tour spec * Fix top menu item spec * Remove unused file * Fix a lot of mobile styles * Fix more mobile styles * Fixed build * Move quick add menu to right hand side * Improve quick-add-button styles, fix main-menu-toggle close icon * Remove add new project spec * Fix spec * Update project dropdown styles * Fix click handler for chrome mobile, update some styles Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago

... 5 6 7 8 9 ...

6053 Commits (a0cadd28ed94d4326ceb1ef8a90365c1ce4cb9cd)