53 Commits (a16d2940163be0787e33858e364bc739b2c377cd)

Author	SHA1	Message	Date
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	b8ca382d34	Group API (#9034) ... * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007) ... * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948) ... * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	a112999dcc	fix ruby 2.7 deprecations (#8867)	4 years ago
Oliver Günther	80e747e0c6	Fix test by calling service with system user ... Adds this to the factory to avoid using the system user all over the place	5 years ago
Oliver Günther	9b91112c36	Throw error in Group#add_members! if call failed ... This shadowed the permission check in the test	5 years ago
Oliver Günther	e4dcc6c5ea	Avoid usage of `users <<` pattern in group ... This will no longer trigger the addition	5 years ago
Oliver Günther	d93ff52a27	Handle add_users with a separate service with CTE	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	8c364aff89	optimize watcher pruning on group modifications ... Less db queries when * removing a member from a group * removing a group from a project * removing a group Mostly this is done by * adding eager load statements where neessary * pruning watchers only once Please note, that the last is only possible via hack which consists of passing a flag which prevents calling prune when we already know that the pruning will take place later on anyway.	8 years ago
Markus Kahl	d2bc4202ad	make group deletion fast	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Jens Ulferts	0b2f482797	move :preference to principal ... This allows for eager loading preference. As the UserPreferences are pretty specific to users we don't want groups to actually receive a UserPreference, though. The methods added by has_one are therefore undefined on the Group model.	9 years ago
Alex Coles	787a35c9db	Add explicit join references in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	b2790b8db1	Migrate deprecated .update_all with conditions ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	064d66449a	Migrate AR finder/query methods in models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	55a2207631	Replace GroupUser join model w/ habtm association ... Active Record 4.x does not generate correct DELETE SQL statements when deleting groups for a given `User` (the `GroupUser` join model does not have a primary key). Callbacks (e.g. `after_remove`) *are* invoked on `has_and_belongs_to_many` associations. This effectively reverts 6c5239c4e2 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	c12410a736	Fix whitespace in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Hagen Schink	cdfdbbd2c1	Removes validation restriction	11 years ago
Jonas Heinrich	a97ffd14c4	made an update possible for the uniqueness validator	11 years ago
Jonas Heinrich	06f2b8b8bf	found another prettier way	11 years ago
Philipp Tessenow	22eb5c1fbc	accidentaly included wrong attribute protection module into group	11 years ago
Philipp Tessenow	860eb61fda	use permitted_params for group_controller	11 years ago
Jens Ulferts	44dee8bb54	assign packages to deleted user upon group deletion	11 years ago
Jens Ulferts	23c3fa4291	replace Issue with WorkPackage	11 years ago
Jean-Philippe Lang	3f0a7fa15d	Ability to assign issues to groups (#2964). ... Option is disabled by default. It can be turned on in application settings. Conflicts: app/controllers/reports_controller.rb app/models/issue.rb app/models/issue_category.rb app/models/mail_handler.rb app/models/project.rb app/views/issue_categories/_form.rhtml app/views/settings/_issues.rhtml config/locales/bg.yml config/locales/bs.yml config/locales/ca.yml config/locales/cs.yml config/locales/da.yml config/locales/de.yml config/locales/el.yml config/locales/en-GB.yml config/locales/en.yml config/locales/es.yml config/locales/eu.yml config/locales/fa.yml config/locales/fi.yml config/locales/fr.yml config/locales/gl.yml config/locales/he.yml config/locales/hr.yml config/locales/hu.yml config/locales/id.yml config/locales/it.yml config/locales/ja.yml config/locales/ko.yml config/locales/lt.yml config/locales/lv.yml config/locales/mk.yml config/locales/mn.yml config/locales/nl.yml config/locales/no.yml config/locales/pl.yml config/locales/pt-BR.yml config/locales/pt.yml config/locales/ro.yml config/locales/ru.yml config/locales/sk.yml config/locales/sl.yml config/locales/sr-YU.yml config/locales/sr.yml config/locales/sv.yml config/locales/th.yml config/locales/tr.yml config/locales/uk.yml config/locales/vi.yml config/locales/zh-TW.yml config/locales/zh.yml test/functional/issues_controller_test.rb test/unit/issue_category_test.rb Conflicts: app/models/issue.rb app/models/user.rb config/locales/de.yml test/functional/issues_controller_test.rb test/unit/issue_test.rb	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Michael Frister	b12e40c66b	Fix member not being deleted when a user was removed from a group	11 years ago
Michael Frister	cd8859b16a	Refactor member role management ... Rename methods so they make clear whether they save and/or potentially destroy a member.	11 years ago
Michael Frister	a66ccfb0f2	Refactor Member and MemberRole: Disallow Member.destroy ... MemberRoles can't be destroyed by themselves anymore, but Member must be asked to do this. This allows Member to have control over validating that each Member has at least one MemberRole and over deleting the Member itself when no MemberRole is left. An ugly piece of code makes MemberRole.destroy raise an Exception when something tries to call it. This should prevent people from accidentally using it.	11 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice ... This was done using the rake task: rake copyright:update	12 years ago
Christian Rijke	1b997cd7ee	bug fix: removing a user from a group should also delete project memberships if the user has no own roles left in the project.	12 years ago
Martin Linkhorst	6c5239c4e2	DEPRECATION FIX: make a badly named GroupUser model to acts as the join model for a has_many :through between groups and users. ... this replaces a has_and_belongs_to_many association, that contained additional parameters like :after_add and :after_destroy. these additional parameters aren't supported for habtm beginning with rails 3.1.0	12 years ago
Jens Ulferts	225629e45d	adds helper method for adding a group member	12 years ago
Jens Ulferts	3f7e293e22	fixes creation and destroying of member roles inherited from a group ... * mass assignment protection prevented the successful creation before	12 years ago
Holger Just	91070236db	Set source encoding to UTF-8	13 years ago
Holger Just	07185fb169	[#436] Remove trailing whitespace	14 years ago
Eric Davis	99507a0391	[#197] Upgrade the copyright in the code files	14 years ago
Eric Davis	e131c3b531	[#197] Remove old copyrights	14 years ago