63 Commits (a16d2940163be0787e33858e364bc739b2c377cd)

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	2154701a02	hide derived_* from form configuration	4 years ago
Oliver Günther	6663a3e404	Don't raise error if to-destroy groups are not found	4 years ago
Oliver Günther	2feaec1101	[33678] Priority needs to be a require field ... Priority was marked non-required for it to turn up in the attribute form configuration. But priority _is actually required_. This results in the frontend adding an optional placeholder `-` value, which makes the resource unsavable. This commit adds priority to the form, but keeps it required as it should be. https://community.openproject.com/wp/33678	4 years ago
Oliver Günther	38e913cb00	Skip schedule_manually in attributes ... [ci skip]	4 years ago
ulferts	1b16dbcc07	avoid double submit of form configuration ... The form configuration used to be submitted at least twice. In most cases, the first submit was canceled fast enough to not reach the backend. But if it was not canceled fast enough, the duplicate post lead to some errors when e.g. the referenced queries where already deleted.	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	bc682f6b01	bail on inexistent related resource ... * status * type * assignee * priority	5 years ago
Oliver Günther	d4644c7c30	[31260] Correctly remove group key from attribute group ... The attribute group key is used in the frontend to detect whether the group is treated as an internal symbol (translation key). When renaming the group, the key is removed in the frontend, but always returned again by the backend. When saving that form again (e.g., rename another group), it is treated as internal again with a wrong key, resulting in the `no key` error. This error is removed by stripping the key field from JSON. Additionally, not found keys are being returned as is, ensuring groups are now named correctly even if they were erroneous before https://community.openproject.com/wp/31260	5 years ago
ulferts	a9213a39cc	remove duplicate permissions	5 years ago
ulferts	0dcb1777d6	reduce db hits for wp schemas	5 years ago
Wieland Lindenthal	79990c1cf8	Remove BCF thumbnail from default form configuration ... (cherry picked from commit 904f709ea3)	5 years ago
Wieland Lindenthal	4eba5f11d5	Fix .travis.yml for including BIM groups to release and dev branches	5 years ago
Wieland Lindenthal	d1e708d6a8	Remove BCF thumbnail from default form configuration ... (cherry picked from commit 904f709ea3)	5 years ago
Wieland Lindenthal	e128899875	Remove BCF thumbnail from default form configuration ... (cherry picked from commit 904f709ea3)	5 years ago
Oliver Günther	73441bfea0	Continued conversion of type form	5 years ago
Wieland Lindenthal	904f709ea3	Remove BCF thumbnail from default form configuration	5 years ago
Oliver Günther	2474978636	[30151] Perform attribute group validations when changed ... Also adds a better error message to let users find out which attribute is invalid. https://community.openproject.com/wp/30151	6 years ago
Oliver Günther	79befe97b3	Bump capybara and rspec	6 years ago
Oliver Günther	f42ff4bdd6	[28543] Validate Type#attribute_groups in contract ... Validating attribute groups is only relevant when creating or updating the type in the administration. There's no need to validate this in the type itself. https://community.openproject.com/wp/28543	6 years ago
Oliver Günther	b08a5874f5	Remove project responsible and type	6 years ago
Jens Ulferts	93b0d34a36	handle errorenous embedded queries on form configuration	6 years ago
Oliver Günther	d05c1ff087	[27940] Don't sort members of attribute groups ... This will result in wrong orders https://community.openproject.com/wp/27940	6 years ago
Oliver Günther	e8216bb16e	[27611] Restore relations tab (#6300) ... * [27611] Restore relations tab * Remove default children query [ci skip]	7 years ago
Oliver Günther	ca8ef3ed7c	Fix creating a task without resetting the group objects ... When creating a task with custom_fields through the factory, it will create the task and hit the attribute_groups during validation, resulting in them being cached and no longer changing due to the custom_field_ids being changed.	7 years ago
Oliver Günther	0904ed5dbf	[27487] Properly reset custom fields when resetting attribute groups ... CF on types can still be set through `custom_field_ids=` and is used in e.g., a number of tests as is the standard way to define custom fields. This is no problem until resetting the attribute groups, where the default attribute groups will contain the custom fields formerly defined. Thus, explicitly resetting the attribute groups must also reset the custom_field_ids. https://community.openproject.com/wp/27487	7 years ago
Jens Ulferts	d7a4e16007	prevent saving attribute_groups if they are the defaults	7 years ago
Jens Ulferts	919badbf81	keep attribute_groups on changes to position	7 years ago
Jens Ulferts	7051fe771e	fix resetting the attribute_groups	7 years ago
Oliver Günther	1acccb444a	Fix attribute groups model now that fixed children query is removed	7 years ago
Oliver Günther	7c3766e694	Fix form configuration specs	7 years ago
Oliver Günther	1ae368c31a	Render attribute and query groups in backend	7 years ago
Jens Ulferts	4fc7e9d439	linting	7 years ago
Jens Ulferts	17d7d2c511	handle query saving, updating, deletion	7 years ago
Jens Ulferts	5a5e3494f9	turn attribute group into dedicated object	7 years ago
Jens Ulferts	fa2b0fa1d9	clean up templated filter values	7 years ago
Jens Ulferts	14dd5c77f4	introduce a :context value for parent filter	7 years ago
Jens Ulferts	941c1ec25d	fix type attribute_groups validation	7 years ago
Jens Ulferts	5e7f1f8df9	hardwire default group to every attribute_group	7 years ago
Jens Ulferts	9e4f5053bc	hack having the children table provisioned from the backend	7 years ago
Jens Ulferts	a33b0bbbbd	WIP - return Query as an attribute group ... * only default query for now * only returned when no custom configuration is applied * start to turn attribute groups into ressources	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	9fabaaaf13	Show only attributes from the type attributes and status, project	7 years ago
Oliver Günther	8956700408	[25374] Remove attribute visibility	7 years ago
ulferts	3f4bfb52ee	memoize custom_field evaluation for default_attribute_group (#5627) ... This can become quite costly when the same calculation is done 200 times (for each custom field that could be active on the type) [ci skip]	8 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465) ... * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603) ... The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
Oliver Günther	5d50acc50e	[25288] Re-add translations to default attribute groups (#5515) ... * [25288] Re-add translations to default attribute groups Uses symbols to mark internal attribute groups and translates them in the schema representer to the user's locale. * Extend form configuration front end for translated default groups * fixing specs * fix feature spec for attribute groups * Add symbol test to attribute groups [ci skip]	8 years ago
Jens Ulferts	2672fb20ae	allow empty groups in type form configuration	8 years ago