openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Oliver Günther	a65992c354	Allow placeholder and group assignment to custom field (#8972 ) * Allow placeholder and group assignment to custom field * Review feedback	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
Oliver Günther	459c8414c0	[32501] Make long test CF creation form show WYSIWYG editor	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	bfb23a2710	Add test for inline editing of project custom fields	5 years ago
Henriette Dinger	6f92035ccc	Rename EditField classes used for tests and remove WorkPackage reference	5 years ago
Henriette Dinger	f47a75d153	[31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726 ) * Check edit fields for Work package dependencies * Make EditForm, NotificationService, EditContext indepenedent of Work Packages * Make EventsService independent of WorkPackages * Start renaming WpNotificationService (WiP) * Fix more references * Fix typescript errors * Add basic halEditingService * Rename to global halResourceEditingService (WiP) * Move typing from class to methods (WiP) * Fix typescript errors * Remove space in type * Add test project widget && generalize the editFieldGroup * Rename editing portal service [ci skip] * Rename WpEditFieldComponent * Rename WpDisplayFields * Rename display-XX-field to XX-display-field [ci skip] * Add WP specific ID field to distinguish between resources * Re-add state in work package resource * Generalize display field renderer * Rename spent-time to wp-spent-time and fix highlight specifics [ci skip] * Actually load the project schema and make field editable * Make edit-field-group.component an edit-form.component and subclass EditForm * Remove edit context in favor of specialized EditForm * Add special cases for work package editing * Fix edit actions bar * Fix codeclimate issues * Use WorkPackageNotificationService if necessary * Override NotificationService for WPs to allow WP specififc notifications (WiP) * Correctly provide wpNotification service Because the ui-router doesn't seem to correctly use the parent element's injector, we need to provide the wpNotification service not in the wp-base, but rather the wp-list component as well as in the isolated query space. * Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage) * Remove superfluous cell class constant * Start renaming selectors for wp-edit-field into generics * Remove wp-table--cell-span in favor of display field selector * Consolidate other display and edit field styles * Provide specialized service for transitions in active edit forms * Remove superfluous overflowSelector * Accept that date field contains some work package specifics * Ignore unreadable files * Provide the changeset for work packages as a hook Since hal resource editing service is provided per query space, we cannot register them once (would only work globally) * Fix dangerfile * Remove another todo in halResourceNotification service * Fix npm TestBed for changed dependencies * Show inplace edit field in project details widget * Fix highlighting in single view * Provide HalResourceEditingService outside of project context * Used typedState for single-view * Also provide wpNotification service in split view * Correct check for resource type in eventsService * Fix getSchemaName in display field renderer * Fix passing ids into `halEditing.stopEditing` * Do not globally inject the halResourceEditingService There's a bug(?) in ui-router that gives you the global service before the parent injected service for a ui-view * Fix wpCreate service on copying and parallel creation * Remove test project widget * Revert changes for project details widget	5 years ago
Oliver Günther	148efb322d	Revert 10.0 PR	5 years ago
Oliver Günther	b4c851ad21	[31123] Only cast numeric custom values It turns out that community still has some custom values that have not been turned into custom_options with their values a numeric reference. This results in trying to cast string values that cannot be casted as numeric. We can avoid this without migrating all custom values again by checking their format with a regex. This is slower as executed on every sort, but will only affect multi-select list custom field sorting, which is one sort criteria on the query: https://community.openproject.com/projects/openproject/work_packages?query_id=1910 https://community.openproject.com/wp/31123	5 years ago
Henriette Dinger	147d4f4c9f	Add test for inline creation of versions from within WP view && adapt tests to new component	6 years ago
Oliver Günther	02fd9365c9	Avoid change detection error by wrapping attach in timeout	6 years ago
Oliver Günther	595a664753	[29683] Fix order statements of CF list Custom fields of type list have been refactored quite some time ago to contain a reference to a `custom_option` in their `custom_value.value`. The sort statements still sort by the `custom_value.value` without joining properly, which results in sorting the internal IDs and not the correct positions. https://community.openproject.com/wp/29683	6 years ago
Oliver Günther	8ab4f2a663	Boards module (#7008 ) * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Push boards on grid * Use base class in scope [ci skip] * Extend api for options * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Save queries in grids [ci skip] * Renaming queries [ci skip] * Add existing work packages to board [ci skip] * Introduce card view component for work packages * Extend grids to allow project scope for boards (#7025) Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards). For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented. * introduce project association for boards * have dedicated grid registration classes * update and create form for board grids * extract defaults into grid registration [ci skip] * Add drag and drop to card view [ci skip] * Add options to grid * Fix option migration name * Renaming boards [ci skip] * Frontend deletion of boards * Avoid map on NodeList which doesnt exist [ci skip] * Add inline create to boards [ci skip] * Smaller create button [ci skip] * Add navigation for boards * Make inner grid same height * Replace index page with table * Workaround for widget registration [ci skip] * Fixed height for cards and tables [ci skip] * Implement escape as cancel d&d action [ci skip] * Fix and extend grid specs for name and options * Extend board specs for required name * Fix migration for MySQL references https://stackoverflow.com/a/45825566/420614 * Make board list extend from widget Since we cannot configure widgets yet, it's not yet possible to use a board-list widget anywhere. * Fix specs * Fix escape listener removal [ci skip] * Fix renamed to_path in relation spec [ci skip] * Allow deletion of grids for boards * Avoid reloading resource multiple times with replays * Frontend synchronization on deletion [ci skip] * Delete through table * Use work packages board path * Use work packages board path * Fix augmented columns breaking re-rendering * Fix duplicated permission with forums * Strengthen tab switch in specs * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * private queries * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * Move boards below work packages * Add Board configuration modal * Fix reloading with onPush * Saving / Switching of display mode [ci skip] * Extract wp-query-selectable-title into common component * Fix renaming of board-list * Fix auto-hide notifications in boards * Add permissions to seeders * Reorder lists in board * Linting * Remove default gravatar from settings * Show assignees avatar in the card view of WPs * Fix specs * Add missing method * Fix timeline icon * Use URL as input to be able to show avatars for groups, too * Fix test * Add further specs * Use correct data attribute to avoid unnecessary data base calls * Add further specs * Deletion of board lists * Pass permission via gon to decide whether we can create boards * Fix rename spec * Cherry-pick of `7873d59` and `30abc7f`	6 years ago
Henriette Dinger	1b8aa2b3e2	[29257] Auto completion for work package attributes (#6988 ) * Introduce ng-select component on WP pages * Remove multiselect switch within multiselect component * Append autocomleter dropdown to attribute group to better handle the two colum layout * Add overflow selector to edit contexts to allow adding to it * Set correct element to append to on WP table and WP view * Make dropdown in Subject row visible and start fixing tests * Fix tests * Append wp autocomplete dropdown to body * Pass user activation requests to edit field [ci skip] * Directly open select fields on click * Include ng-select from own fork * Add path to tsconfig.json to resolve the module * Make attributes group id fix, so that it stays the same after reinitialisation (e.g. type change) [ci skip]	6 years ago
Inga Mai	7344eb0af3	Codeclimate and tests fixed	6 years ago
Jens Ulferts	a19b3f036c	structure spec support pages into appropriate directories	6 years ago
Jens Ulferts	951bf3e7f1	replace cf visible in project cuke	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Jens Ulferts	8b6fa75664	bump capybara, cucumber-rails & capybara-screenshot	7 years ago
Oliver Günther	339ed9deaa	Re-add hal resources npm test	7 years ago
Oliver Günther	7257feef89	Fix projecting selected valueOption from ngOptions	7 years ago
Oliver Günther	e22f0bc1ff	Fix hierarchy test helper	7 years ago
Oliver Günther	e456b18ac8	Wait for frontend to be initialized https://travis-ci.org/opf/openproject-ce/jobs/348004376 [ci skip]	7 years ago
Oliver Günther	42a59fdd9b	Wait for initialized CF [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	b0fed3768d	turn into enterprise feature	7 years ago
Jens Ulferts	690e0ffc60	wp create/update/destroy via services	7 years ago
Oliver Günther	7802034bac	[26611] Avoid global preventDefault This causes the multivalue change event to fail complete in Chrome. For consistency, I added the ngModelOptions to clarify use of getter/setter on the model variable. https://community.openproject.com/wp/26611	7 years ago
ulferts	4d95cc815f	Feature/guarded relation columns (#5784 ) * refactor case statement * guard relation columns by enterprise token [ci skip]	7 years ago
ulferts	75f501e897	Fix/custom field lacking options (#5768 ) * enforce having at least one custom option for a list cf Removes the hand written nested attributes handling by accept_nested_attributes_for. Removes the arbitrary boundary of having 500 custom options. * i18n for custom option mgmt [ci skip]	7 years ago
Jens Ulferts	f88f5f0ee7	fix whitespace on wp display field for multiple resources	8 years ago
Oliver Günther	edd17b75bc	Fix tests due to changed default query	8 years ago
Oliver Günther	93dcd386f4	Remove usage of CF translations	8 years ago
Oliver Günther	5a02ec8935	Add spec for multi-value CF	8 years ago
Oliver Günther	8d381651c8	Fix specs	8 years ago
Henriette Dinger	8990a02734	Change representation of multiCF && correct spelling mistake	8 years ago
Henriette Dinger	847f9a5ce1	Take care of test && add localized labels	8 years ago
Markus Kahl	de584216e8	fixed (and added spec for) adding options to existing cf	8 years ago
Markus Kahl	dfd6d4141f	multi user custom field feature spec	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Till Breuer	2f9691dc7d	Add lang tag for work package column headers and columns	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago

50 Commits (a18954b2c9c8a1b3f2891cff9910b2b96306b7c0)