2156 Commits (a30c500a58ff60a92806b52ec24262e1d4bb64f0)

Author	SHA1	Message	Date
Oliver Günther	4cc339eb48	toggleClass requires actual booleans	9 years ago
Oliver Günther	5f942ee1db	Move wp-context-menu-helper	9 years ago
Oliver Günther	a76e6b249d	Fix invalid links to work package actions	9 years ago
Oliver Günther	70f5135e12	Fix invalid schema when switching types ... When switching types, new required fields MAY be added to the schema (e.g., a custom field) and are returned from the form, but the work package schema is not properly updated. Thus, 1. Post only the raw payload, instead of the hal-resource (this). 2. Merge the properties based on the form payload 3. Update the work package schema in the resource	9 years ago
Oliver Günther	10877ecd37	Use focus="true" instead of autofocus (#4379)	9 years ago
Oliver Günther	bc3223ae04	Header: Set currentGroup to placeholder value (#4378)	9 years ago
Oliver Günther	f12c8295e7	Use autofocus instead of focus directive ... This should also focus the select field in Firefox correctly. https://community.openproject.com/work_packages/20140/activity	9 years ago
Oliver Günther	92e4d63f3a	Open last selected work package using details view (#4372)	9 years ago
Oliver Günther	776b585699	ui-components is not actually required anymore, remove traces (#4369) ... There are still ui_components, however that module has long been integrated into the core.	9 years ago
Oliver Günther	141cbfa4e4	[22624] Display 'Open this work package in full screen' correctly (#4363) ... * Display 'Open this work package in full screen' correctly Currently, the 'Click here to open this work package in fullscreen view.' is not implemented correctly: 1. It is not only shown for update and create, but also delete in the table 2. It is not shown for inline create / edit 3. It is shown in full screen This reimplements the functionality without requring deep knowledge in NotificationsService. * Move NotificationsService * Move notification box directive * Move DetailsTabOverviewController	9 years ago
Oliver Günther	78dc9548f3	[Bugfix] Work package grouping header (#4360) ... * Refactor how table grouping is applied and refreshed Currently, changes to groupBy causes the work package to be immediately refreshed before the actual groups are collected from the backend. This watch has been removed, since its unneeded. The work package table is now tracked by the row id and the current group, which causes the ng-repeat to re-evaluate when the group changes, thus fixing the group header bug. Additionally, we now carry the groupByColumn in the wpTableService, where the other grouping values are derived as well. * Allow nil aggregation group This should fix https://community.openproject.com/work_packages/22816/activity * Hide empty group header when groupName not defined This avoids showing an empty header for inline create row. Also forces the create button to disappear when the table is explictly refreshed (e.g., when grouping on another attribute).	9 years ago
Markus Kahl	50e40f324a	wp form config polish (#4364) ... * allow hiding fields with defaults; consider name_source * sort types by name; move projects config to bottom * updated translations (default => active) * no extra visibility behaviour for new WPs * allow hiding even type; always show details header though otherwise the 'show all attributes' button may vanish * updated specs to include new info	9 years ago
Oliver Günther	5d51594b81	Show table even when empty (#4362)	9 years ago
Alex Dik	b1734be9b9	Fix TypeScript karma tests (#4361)	9 years ago
Alex Dik	116c4ec5c1	Refactor WP filter related components (#4348) ... * Implement WP filter button directive * Tidy up the WP inline create button controller * Reformat WP list route code * Move Filter model to components * Move filter constants to filters component directory * Move query filters directive * Move query filter directive * Add filter container directive Vote furinvader for less copy pasta! * Refactor filter visibility code * Move filters helper * Move query model service * Make the query service a part of the filters module * Remove getFilterCount test from WP list controller * Fix query model module import * Fix karma tests Importing Angular modules within the test files is not possible yet. * Move filter visibility to a dedicated service * Get rid of the FiltersHelper service	9 years ago
Oliver Günther	2c10ee75d2	Fix webpack Typescript warnings (#4357) ... Resolve TypeScript warnings output merged earlier in #4355	9 years ago
Oliver Günther	d34c89ee94	Preselect values of new work package from filter values (#4355) ... This allows to assign default values for new work packages from the current query filter. Due to the incompatibility in APIexperimental query filters APIv3 values, this link is made solely for the types assignees and types.	9 years ago
Oliver Günther	e25d9764a1	Add redirect for /styleguide ... Adds a development-only route for `/styleguide` as an alias to `/assets/styleguide.html`.	9 years ago
Oliver Günther	e49c163d00	Remove gulp with simpler npm tasks ... This removes `gulp` and provides a simpler `karma` and `webpack`, `webpack-watch` npm scripts. For actual development, users will need the Rails stack anyway, so it won't make sense to keep a separate set of dependencies up to date. * Instead of `gulp webpack`, use `npm run webpack`. * Instead of `gulp watch`, use `npm run webpack-watch`, which is *drastically* faster than gulp watch-polling. * Instead of `gulp tests:karma` use `npm run karma`, or just `npm test`. This also removes all traces of express and restores the Rails styleguide. It is not whitelisted for precompilation and is only available in the context of the development mode. To access the styleguide, use `/assets/styleguide.html`.	9 years ago
Oliver Günther	21842335ac	Rewrite removed frontend tests with feature specs (#4350) ... This PR adds two feature specs: Replacement for work-packages-modal-focus-spec.js Replacement for parent-relations-handler-spec.js The remainig tests removed with #4346 are already covered as follows: activity-with-revisions-spec.js (covered by activity_comments_spec.rb) details-pane-editable-spec.js (covered by edit_work_package_spec.rb) details-pane-show-hide-accessibility-spec.js (obsolete) details-pane-spec.js (covered by several feature specs)	9 years ago
Oliver Günther	6e61150c1b	[Inline Edit / Create] Changes and bug fixes (#4336) ... * Open work package on single click when already in split view * Replace (new) with empty string for new IDs * Replace trash icon with cancel icon	9 years ago
Oliver Günther	d9be51c30f	Remove protractor E2E tests (#4346) ... In agreement with @furinvader, we have decided to remove protractor testing from OpenProject. Frontend tests are implemented in karma and test single units of work as before. Since the freshness of APIv3 JSON mocks are getting ouf hand and we have covered almost all E2E protractor tests with Rails, we're going to resort to Rails to write concise *actual* integration test with correct data.	9 years ago
Markus Kahl	5f9579ec1a	put visibility info into wp schema and use that	9 years ago
Markus Kahl	6679c9075a	don't force unrequired fields	9 years ago
Alex Dik	59fc573ea8	Undo removal of isModuleEnabled method	9 years ago
Oliver Günther	42cb4a7a78	Show inline-create in global work package list (#4340) ... When no project context is available, this fetches the `available_projects` endpoint and suggests using the first project for creating a new row.	9 years ago
Markus Kahl	148a3fff14	work package form configuration	9 years ago
Alex Dik	db11fc28de	Refactor config service (#4339)	9 years ago
Oliver Günther	b70f102060	Select query filter keys correctly (#4337) ... Fixes a regression from https://github.com/opf/openproject/pull/4333	9 years ago
Oliver Günther	386d4b53e7	Use default loading of table for details pane (#4335)	9 years ago
Oliver Günther	96535b5361	Remove remainingFilterNames $filter (#4333) ... This replaces the filter for remaining filter types, which is executed many times for any digest and causes a significant performance impact with a watch on the query and according changes when adding/removing a filter.	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290) ... * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago
HDinger	df7484e4e1	Set html titles for wiki and wp pages (#4311) ... Closely related to #4308 this PR sets the html titles for wiki and WP pages.	9 years ago
HDinger	b17f1d5fa4	Change field widths (#4312)	9 years ago
HDinger	a5c5aaa381	Remove role attribute to avoid incorrect screen reader output ... This removes the role attribute from submenu to avoid incorrect screen reader output. The screen reader reads otherwise that the user shall navigate with arrow keys but this is done by tab.	9 years ago
HDinger	90d245ff68	Set overflow values except for columns modal ... This sets the overflow values for the modal windows opened in the WP overview. Thus when the font size is increased or the window size decreased there appears a scrollbar.	9 years ago
HDinger	d6413d18c6	[21808] [Accessibility] Make wp view mode buttons accessible ... * Make list view button focusable by tab * Don't use 'disabled' as attribute	9 years ago
HDinger	6077b8ef89	[20397] [Accessibility] Navigating through the entries of some drop down lists causes a page update	9 years ago
Oliver Günther	166813677f	Avoid submitting an invalid query with empty status	9 years ago
Manu Schiller	67a2d89d11	[20140] modals: fixes for accessibility of modals by keyboard	9 years ago
Oliver Günther	f9fe1a5d79	[22916] Inline edit only on attribute text, double click to fullscreen ... * Reduce editable field to wp-table--cell-span * Allow macs to CMD-click for multiselect * Set double click to full screen * Set focus expectation to anchor * Fix flickering in inline expectation * Update selector for double clicks * Simplify innerMostSpan * Add spec for double click full view	9 years ago
Alex Dik	32d229bdab	Fix karma tests ... * Exit karma with the given exit code after tests have run * Fix NotificationBox directive test * Set karma singleRun to true * Refactor loadingIndicator service * Fix apiV3 service tests * Fix HalLink service tests * Fix HalResource tests * Reformat WP list controller test code * Fix WP list controller tests * Refactor wpContextMenu and fix its tests	9 years ago
Henriette Dinger	680730011f	Set name to enable access by arrow keys	9 years ago
Henriette Dinger	6570ad1749	Set focus on first element in WP header menu	9 years ago
Henriette Dinger	89cba4ff14	Add labels for better accessibility of wp table header	9 years ago
Henriette Dinger	4f11edcb22	Set focus on first element of 'settings-' and 'new WP'-menu	9 years ago
manuschiller	4ea9213f0d	Correct controlling when the link should be displayed and I18-Support	9 years ago
Henriette Dinger	9d9f038bf7	Accessibility issues on WP page	9 years ago
Oliver Günther	3211ad1373	Add fullscreen link to table context menu	9 years ago
manuschiller	fa41b77717	[22752] show all fields in edit mode	9 years ago