openproject

Commit Graph

Author	SHA1	Message	Date
Jens Ulferts	17d9cba625	do not throw internal error on invalid custom field	6 years ago
Jens Ulferts	e58a96515c	allow setting attachments through wp post/patch	7 years ago
Jens Ulferts	d04b86da9c	introduce custom eager loading for work package list Reduces the amount of AR models instantiated when handing wp#index requests by: * Calculating part of the checksum for caching in the db. This is done by using the id and the updated_at/on field of associated models whose representation is cached in the wp representer. * Reusing instantiated models for multiple associations. e.g instances of Project are used in various places (the work package itself, it's ancestors and children). Instead of using Rails' eager loading which would instantiate a project potentially once for every association path, the code now assigns the same instance to all those associations. Additionally, the commit streamlines the creation of custom field injected representers. Now only one class is created for all work packages when before it would be one class for every uniq set of custom fields. On top of that, the class can be reused if the set of custom fields does not change.	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Wieland Lindenthal	4e22681e78	User mentions feature (#5897 ) * Extend syntax for linking users via their ID * Allow login names for linking user profiles. * User require_relative for legacy tests * Add specs for login name based user links; Fixes other specs, too. * Notify mentioned users * Notify linked users; - require quotes for login names in user links as login names can contain spaces, dots that are typical word boundaries - Adding specs * For the decision who gets notified due to mentions only the visibility permissions of the recipient are relevant. * Rubucop satisfaction * Add autocomplete for user names to work pack package descriptions and activity - Uses API V3 Principals endpoint. - Extends API endpoint with name filter and name order. - Make it activate when user types an "@" or a "user#" - Still for work packages only. * Directly show a list of users after typing '@' and allow navigating list with cursor keys * Add an '@' before the rendered user link * Adopting spec as WP autocompleter now expects whitespace before hash sign * Adding spec for using user autocompleter * Introduce magic pageSize of 0 for maximum length * Add id filter for principals * Allow pagination for principals and protect from falling back to a too low default value * Fixing specs * fixing typo in spec * Add magic number 0 for user custom fields * Add a toParams method for ApiV3FilterBuilder * User ApiV3FilterBuilder in path helper service * Add test for mentions principals to path helper * WIP * Convert auto complete helper to TS [ci skip]	7 years ago
ulferts	7154caec85	Fix/consolidate representers (#5732 ) * consolidate representers Minimizes the need for extensive payload representers by: * introducing the payload_representer module which removes all non writable propertyies from a representer * introducing the resource/resources/associated_resource/associated_ressources helper methods which provide a framework for having a representer suitable for parsing and rendering Additionally increases the importance of the contracts by using them to calculate the writeable attributes. * remove unused endpoint [ci skip]	7 years ago
ulferts	0c0b16508b	Fix/bump representable (#5465 ) * bump reform and roar -> bumps representer * adapt to changed validation interface * disable initializer patch for now * adapt to changed representable attr interface * can no longer have private methods inside a representer * private no longer possible for representer * bump reform * wip - restyle validation * remove commented out patch * apply injection as prescribed * reactivate reform error symbols patch * remove patch to Hash superfluous wit ruby 2.3 * remove outdated human_attribute_name patch * whitespace fixes * adapt filter name after removal of human_attribute_name patch * adapt filter specs to no longer rely on human_attribute_name patch * fix version filter name * remove reliance on no longer existing human_attribute_name patch * use correct key in journal formatter * remove private from representer * adapt to altered setter interface * reenable i18n for error messages in contracts * no private methods in representer * defined model for contracts * fix validaton * instantiate correct Object * define model for contract * circumvent now existing render method on reform * replace deprecated constant * patch correct reform class - not the module - via prepend * refactor too complex method * replace deprations * remove remnants of parentId * prevent error symbols from existing twice * adapt user representer to altered setter interface * adapt watcher representer to altered setter interface * remove now unnessary patch * adapt setter to altered interface * adapt spec * fix custom field setters * remove parentId from wp representer As the parent is a wp resource, clients should use the parent link instead * adapt spec to changed valid? interface * remove parentId from wp schema * replace references of parentId in frontend * remove TODO [ci skip]	8 years ago
Oliver Günther	94234bd5ee	[25432] Correctly transmit hasDefault to frontend (#5603 ) The default value for CFs is '', which is obviously not nil despite not being a default, however the frontend only _always_ shows the attribute when it is required and has no default. This PR also adds a 'always visible' flag to the form configuration when the CF is set required. [ci skip]	8 years ago
Oliver Günther	303109340d	[25339] Pass the context to format_text in formattable (#5541 ) [ci skip]	8 years ago
Jens Ulferts	f4a195f11b	fix link to allowed values for user cf Only: * users * member of the project * not builtin and not locked	8 years ago
Jens Ulferts	8a08856748	replace string object by custom option for list custom fields	8 years ago
Markus Kahl	c25a85cd5a	display and edit user multi select	8 years ago
Markus Kahl	f5a57e3f42	list custom field normalisation and multi select	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	ac8936260e	have title attribute for cv links	8 years ago
Jens Ulferts	5a7bda366e	no longer embed cf values if wp representer is rendered inside a collection	8 years ago
Jens Ulferts	0a6d4a9278	fix mutable constants	8 years ago
Jens Ulferts	d18b028599	use assignable_custom_field_values for version as well	9 years ago
Jens Ulferts	5948249c77	no longer show available values for a typed schema Before, the available values where always embedded into every schema. Because a deep copy is performed in the front end, this would downgrade the performance of the wp list in cases where a schema has a list cf with a lot of available values	9 years ago
Oliver Günther	f3da772a58	Use default Setting.text_formatting for text CF This changes the forced formatting of 'plain' to the default formatting, thus allowing textile formatting.	9 years ago
Markus Kahl	50e40f324a	wp form config polish (#4364 ) * allow hiding fields with defaults; consider name_source * sort types by name; move projects config to bottom * updated translations (default => active) * no extra visibility behaviour for new WPs * allow hiding even type; always show details header though otherwise the 'show all attributes' button may vanish * updated specs to include new info	9 years ago
Jens Ulferts	e1b3845582	cache classes with dynamically injected custom attributes	9 years ago
Oliver Günther	876203c096	Add writable to other custom field injectors This was missed in https://github.com/opf/openproject/pull/3728 and properly disguised by a faulty spec fix from my side.	9 years ago
Jan Sandbrink	0702683116	Fix bad method call for version custom fields exploring the down sides of isolated unit testing :(	9 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	62ed35e56c	fix CF links if value is nil The custom field value seems to be actually an empty string rather than nil... I <3 custom fields!	10 years ago
Jan Sandbrink	a86ad7729e	allow to have invalid links in payload	10 years ago
Jan Sandbrink	f42f8c4305	evaluate localization of schema names per call - allows real localization instead of one-time localization at startup - either request a callback for a name or a symbol passable to human_attribute_name	10 years ago
Jan Sandbrink	36e071087e	some renaming we are generifying the interpretation of the parameter we receive... added some words about assumptions...	10 years ago
Jan Sandbrink	9986466e15	use direct CF accessors in CF injector	10 years ago
Jan Sandbrink	6f90674440	include more schema details for custom fields	10 years ago
Jan Sandbrink	ec4d228956	split method	10 years ago
Jan Sandbrink	ff72c7760c	embed CF versions, users and string objects	10 years ago
Jan Sandbrink	9e88d73022	move creation logic into injector class helpers should be quite reusable across customizables	10 years ago
Jan Sandbrink	d61c2ff4aa	add remaining specs for CF injector	10 years ago
Jan Sandbrink	05884417f7	let custom values return typed values this allows to have type-correct JSON output, e.g.: 12 instead of "12" true instead of "1"	10 years ago
Jan Sandbrink	a5e58dc8d0	add more specs for the CF Injector - fixing the worst typo ever - failing for bool, float and int...	10 years ago
Jan Sandbrink	1278ea221b	make a formattable of text custom fields	10 years ago
Jan Sandbrink	5c3eae32f6	style	10 years ago
Jan Sandbrink	e1948206fa	extract method into ResourceLinkParser - similar code was already used in two different places - now the error message makes sense for both occurences	10 years ago
Jan Sandbrink	03c6fcdf6f	rewrite ResourceLinkParser - use own RegExp instead of borrowing the ones from Grape routes - add specs	10 years ago
Jan Sandbrink	8998f60635	fix patching of empty string objects	10 years ago
Jan Sandbrink	53b9f7738f	enable patching of linked properties	10 years ago
Jan Sandbrink	4c8fc69eb5	enable linked properties for WP - disabling wrong representation in payload	10 years ago
Jan Sandbrink	c576641579	style	10 years ago
Jan Sandbrink	e32c056b96	fix value injection for nil values	10 years ago
Jan Sandbrink	a60b433b5c	specs for all paths of :inject_schema	10 years ago
Jan Sandbrink	c1ed80f3a3	allow injector to inject allowed values	10 years ago
Jan Sandbrink	a5e1c33733	new custom value representation in WP representer - also allows writing custom values	10 years ago
Jan Sandbrink	b10a08a9de	add schema information for basic custom fields	10 years ago

50 Commits (a61598d76b8001b54f0480f077ad3f27d12506fe)