1619 Commits (a7a25d49589e1bfbbfc97835c0d07ef5fb963c67)

Author	SHA1	Message	Date
Jan Sandbrink	0dd77ecb5f	use merge! method of Reform::Contract::Errors ... - this is more concise, but more importantly: - it uses our patched in symbol merging, thereby correctly transferring symbol information	9 years ago
Jan Sandbrink	bc30b28558	extract attribute name conversion into extra class ... - consider special renaming rules for well known attribute names -> currently covering wp attributes and createdAt, updatedAt	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs ... - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	662f99808a	apply basic attribute name transformations ... those are the ones that were present earlier already. They do not cover the hard cases, where the backend has completely different names form the API	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	3e87d10980	fix bogus errors in contracts ... - AR tried to read properties that are undefined on the contract (:error_read_only) - now that we actually use Contract properties the copy-validations stuff started to do things, however: - we already went another path to simultaneously validate contract + model - validation was apparently broken, e.g. though the subject was not empty, there were subject :blank errors	9 years ago
Jan Sandbrink	13b9042293	treat all 422 errors the same for forms ... That means: Do render the form for all HTTP 422 errors, problems are highlighted within the form	9 years ago
Jan Sandbrink	a0e2c26deb	define properties on contract ... Actually it is documented that a :property needs to be defined on the contract (see https://github.com/apotonick/reform#contracts). We just did not do that until now, because it was not neccessary when abusing AR::Errors as hard as we did.	9 years ago
Jan Sandbrink	ac9cffe741	remove tautology and add apropriate specs	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts ... - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Jan Sandbrink	eec35308ce	use contract directly in WP create too	9 years ago
Jan Sandbrink	ce0b906d91	dirty trick to allow using a Hash as mock ... also removes default value from initializer, which was never sane	9 years ago
Jan Sandbrink	e5dd8732fc	fix stupid mistakes ... - reference to method by old name - not knowing how to call a super-method	9 years ago
Jan Sandbrink	88d7944bb1	hide error merging behind contract.validate	9 years ago
Jan Sandbrink	e22334a5f6	rename local	9 years ago
Jan Sandbrink	025f3f589e	remove side effect from Validation.create ... I just don't know what the original author thought...	9 years ago
Jan Sandbrink	0b7b4bf329	extract error merging into contract	9 years ago
Alex Coles	29d9814347	Prefer Project.allowed_to to .allowed_to_condition ... Use `ActiveRecord::Relation#merge` to merge scopes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	837265c257	Fix API v3 WorkPackageSchema for AR::Relation ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	9abbe5c4f7	Remove deprecated Relation#all in lib ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Markus Kahl	3865ce4f1f	polish	10 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	10 years ago
Markus Kahl	d854df5175	suppress browser prompt on authenticate failure	10 years ago
Alex Coles	a6212fb304	Fix syntax (w/Rubocop) in lib code ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jan Sandbrink	4054c2ae22	add a removeWatcher link to work packages	10 years ago
Jan Sandbrink	0d31367a94	specify identifier for parse error	10 years ago
Jan Sandbrink	6b1bda3389	do not use exceptions for code flow ... I have to admit that I personally would not even care about this error condition, as I'd expect my errors to listen to :identifier	10 years ago
Markus Kahl	173fc83ec0	refactored huge switch; fixed null id. in dev mode	10 years ago
Alexander Bach	82d8b4500d	Remove temporal coupling	10 years ago
Alexander Bach	ca06ce47be	Properly use caching mechanism	10 years ago
Alexander Bach	cbc22efc8e	Fix dumb mistake	10 years ago
Alexander Bach	8d26d6a52c	Explicitly specify PayloadRepresenter	10 years ago
Alexander Bach	6c19dc58ff	Move helper method to helpers	10 years ago
Alexander Bach	eaa98420a5	Use proper inherited variable	10 years ago
Alexander Bach	517540e730	Remove activity self link title	10 years ago
Alexander Bach	0312378ef3	Lull the hound	10 years ago
Alexander Bach	e2a43472b9	Correct wp create endpoint refactoring	10 years ago
Alexander Bach	c7d5d266d8	Remove superfluous variable	10 years ago
Alexander Bach	a7ff19e620	Move service creation into post	10 years ago
Alexander Bach	b25302590a	Remove duplicated permission check	10 years ago
Alexander Bach	a0ae511f99	Add complimentary post	10 years ago
Alexander Bach	e506a49733	Shorten form_representer by inheriting from single	10 years ago
Alexander Bach	866ab1a5e5	Use implicit getter	10 years ago
Alexander Bach	bbd46ef8bd	Unify activity path declaration	10 years ago
Alexander Bach	e14256addf	Add condition to else	10 years ago
Alexander Bach	ac17928cde	Clarify comment	10 years ago
Alexander Bach	71fa1fa912	Tiny style fix	10 years ago
Alexander Bach	673d9366ff	Improve shared helper encapsulation	10 years ago